Completed
Push — refonte ( c098ff...64e01a )
by Arnaud
02:21
created
src/Field/ActionCollectionField.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
                 'template' => '@LAGAdmin/Field/actionCollection.html.twig',
40 40
                 'actions' => [],
41 41
             ])
42
-            ->setNormalizer('actions', function (Options $options, $value) use ($actionConfiguration, $defaultActions) {
42
+            ->setNormalizer('actions', function(Options $options, $value) use ($actionConfiguration, $defaultActions) {
43 43
                 if (!is_array($value) || 0 === count($value)) {
44 44
                     $value = [
45 45
                         'edit' => [],
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
                 '_self',
139 139
                 '_blank',
140 140
             ])
141
-            ->setNormalizer('route', function (Options $options, $value) use ($actionConfiguration) {
141
+            ->setNormalizer('route', function(Options $options, $value) use ($actionConfiguration) {
142 142
                 // route or url should be defined
143 143
                 if (!$value && !$options->offsetGet('url') && !$options->offsetGet('admin')) {
144 144
                     throw new InvalidOptionsException(
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
 
157 157
                 return $value;
158 158
             })
159
-            ->setNormalizer('admin', function (Options $options, $value) {
159
+            ->setNormalizer('admin', function(Options $options, $value) {
160 160
                 // if a Admin is defined, an Action should be defined too
161 161
                 if ($value && !$options->offsetGet('action')) {
162 162
                     throw new InvalidOptionsException(
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 
167 167
                 return $value;
168 168
             })
169
-            ->setNormalizer('parameters', function (Options $options, $values) {
169
+            ->setNormalizer('parameters', function(Options $options, $values) {
170 170
                 $cleanedValues = [];
171 171
 
172 172
                 foreach ($values as $name => $method) {
Please login to merge, or discard this patch.
src/Factory/MenuFactory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
     public function __construct(
33 33
         RequestStack $requestStack,
34 34
         ApplicationConfigurationStorage $applicationConfigurationStorage
35
-    ){
35
+    ) {
36 36
         $this->requestStack = $requestStack;
37 37
         $this->applicationConfiguration = $applicationConfigurationStorage->getConfiguration();
38 38
     }
Please login to merge, or discard this patch.
src/Event/Subscriber/ExtraConfigurationSubscriber.php 1 patch
Doc Comments   +8 added lines, -1 removed lines patch added patch discarded remove patch
@@ -138,6 +138,10 @@  discard block
 block discarded – undo
138 138
         ];
139 139
     }
140 140
 
141
+    /**
142
+     * @param string $entityClass
143
+     * @param string $adminName
144
+     */
141 145
     private function addDefaultFields(array &$configuration, $entityClass, $adminName)
142 146
     {
143 147
         $fieldsMapping = [
@@ -343,7 +347,7 @@  discard block
 block discarded – undo
343 347
     /**
344 348
      * Return the default action field if found.
345 349
      *
346
-     * @param array $fields
350
+     * @param string[] $fields
347 351
      *
348 352
      * @return string|null
349 353
      */
@@ -420,6 +424,9 @@  discard block
 block discarded – undo
420 424
         return $metadata;
421 425
     }
422 426
 
427
+    /**
428
+     * @param string $type
429
+     */
423 430
     private function getOperatorFromFieldType($type)
424 431
     {
425 432
         $mapping = [
Please login to merge, or discard this patch.
src/Factory/FieldFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -172,7 +172,7 @@
 block discarded – undo
172 172
     /**
173 173
      * @param array               $configuration
174 174
      * @param ActionConfiguration $actionConfiguration
175
-     * @return array
175
+     * @return string
176 176
      * @throws Exception
177 177
      */
178 178
     private function resolveTopLevelConfiguration(array $configuration, ActionConfiguration $actionConfiguration)
Please login to merge, or discard this patch.
tests/AdminBundle/Bridge/Doctrine/ORM/DataProvider/ORMDataProviderTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
         $eventDispatcher
90 90
             ->expects($this->once())
91 91
             ->method('dispatch')
92
-            ->willReturnCallback(function ($eventName, $event) use ($queryBuilder, $admin) {
92
+            ->willReturnCallback(function($eventName, $event) use ($queryBuilder, $admin) {
93 93
                 $this->assertEquals(AdminEvents::DOCTRINE_ORM_FILTER, $eventName);
94 94
                 /** @var DoctrineOrmFilterEvent $event */
95 95
                 $this->assertInstanceOf(DoctrineOrmFilterEvent::class, $event);
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
             $requestStack
218 218
         );
219 219
 
220
-        $this->assertExceptionRaised(Exception::class, function () use ($provider, $admin) {
220
+        $this->assertExceptionRaised(Exception::class, function() use ($provider, $admin) {
221 221
             $provider->get($admin, 42);
222 222
         });
223 223
     }
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
         /** @var RequestStack|MockObject $requestStack */
231 231
         $requestStack = $this->createMock(RequestStack::class);
232 232
 
233
-        $entity =new EntityFixture(42);
233
+        $entity = new EntityFixture(42);
234 234
 
235 235
         /** @var EntityManagerInterface|MockObject $entityManager */
236 236
         $entityManager = $this->createMock(EntityManagerInterface::class);
Please login to merge, or discard this patch.
tests/AdminBundle/Event/Subscriber/AdminSubscriberTest.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
         $admin = $this->createMock(AdminInterface::class);
97 97
         $event = new AdminEvent($admin, $request);
98 98
 
99
-        $this->assertExceptionRaised(Exception::class, function () use ($subscriber, $event) {
99
+        $this->assertExceptionRaised(Exception::class, function() use ($subscriber, $event) {
100 100
             $subscriber->handleRequest($event);
101 101
         });
102 102
     }
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
      */
107 107
     public function testCreateView()
108 108
     {
109
-        list($subscriber, , $viewFactory) = $this->createAdminSubscriberMock();
109
+        list($subscriber,, $viewFactory) = $this->createAdminSubscriberMock();
110 110
         $view = $this->createMock(ViewInterface::class);
111 111
 
112 112
         $actionConfiguration = $this->createMock(ActionConfiguration::class);
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
      */
245 245
     public function testLoadEntitiesWithMultipleStrategy()
246 246
     {
247
-        list($subscriber, , , $dataProviderFactory, , , ,) = $this->createAdminSubscriberMock();
247
+        list($subscriber,,, $dataProviderFactory,,,,) = $this->createAdminSubscriberMock();
248 248
 
249 249
         $actionConfiguration = $this->createMock(ActionConfiguration::class);
250 250
         $actionConfiguration
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
      */
315 315
     public function testLoadEntitiesWithUniqueStrategy()
316 316
     {
317
-        list($subscriber, , , $dataProviderFactory) = $this->createAdminSubscriberMock();
317
+        list($subscriber,,, $dataProviderFactory) = $this->createAdminSubscriberMock();
318 318
 
319 319
         $actionConfiguration = $this->createMock(ActionConfiguration::class);
320 320
         $actionConfiguration
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
      */
388 388
     public function testLoadEntitiesWithoutIdentifier()
389 389
     {
390
-        list($subscriber, , , $dataProviderFactory) = $this->createAdminSubscriberMock();
390
+        list($subscriber,,, $dataProviderFactory) = $this->createAdminSubscriberMock();
391 391
 
392 392
         $actionConfiguration = $this->createMock(ActionConfiguration::class);
393 393
         $actionConfiguration
@@ -444,7 +444,7 @@  discard block
 block discarded – undo
444 444
         $request = new Request();
445 445
         $event = new EntityEvent($admin, $request);
446 446
 
447
-        $this->assertExceptionRaised(Exception::class, function () use ($subscriber, $event) {
447
+        $this->assertExceptionRaised(Exception::class, function() use ($subscriber, $event) {
448 448
             $subscriber->loadEntities($event);
449 449
         });
450 450
     }
@@ -454,7 +454,7 @@  discard block
 block discarded – undo
454 454
      */
455 455
     public function testSaveEntity()
456 456
     {
457
-        list($subscriber, , , $dataProviderFactory, , $session, $translator) = $this->createAdminSubscriberMock();
457
+        list($subscriber,,, $dataProviderFactory,, $session, $translator) = $this->createAdminSubscriberMock();
458 458
 
459 459
         $adminConfiguration = $this->createMock(AdminConfiguration::class);
460 460
         $adminConfiguration
Please login to merge, or discard this patch.