AdminFactoryTest - Code Metrics - Inspection of "Add a test for the admin factory" - larriereguichet/AdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — refonte ( 50d758...cd6451 )

by Arnaud

created 2018-10-02 21:31 UTC

AdminFactoryTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	204
Duplicated Lines	84.8 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	5
lcom	1
cbo	4
dl	173
loc	204
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Duplication	Size	Complexity
B	testCreateFromRequest()	66	66	1
A	testCreateFromRequestWithoutRouteParams()	19	19	1
A	testCreateFromRequestWithoutAdminParams()	21	21	1
A	testCreateFromRequestWithoutExistingAdmin()	0	24	1
B	testCreateFromRequestWithInvalidAdminClass()	67	67	1

How to fix Duplicated Code

<?php

namespace LAG\AdminBundle\Tests\Factory;

use LAG\AdminBundle\Admin\Admin;
use LAG\AdminBundle\Configuration\AdminConfiguration;
use LAG\AdminBundle\Configuration\ApplicationConfiguration;
use LAG\AdminBundle\Configuration\ApplicationConfigurationStorage;
use LAG\AdminBundle\Exception\Exception;
use LAG\AdminBundle\Factory\AdminFactory;
use LAG\AdminBundle\Factory\ConfigurationFactory;
use LAG\AdminBundle\Resource\AdminResource;
use LAG\AdminBundle\Resource\ResourceCollection;
use LAG\AdminBundle\Tests\AdminTestBase;
use LAG\AdminBundle\Tests\Fixtures\FakeAdmin;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\HttpFoundation\Request;

class AdminFactoryTest extends AdminTestBase
{
    public function testCreateFromRequest()

    {
        $resource = $this->getMockWithoutConstructor(AdminResource::class);
        $resource
            ->expects($this->atLeastOnce())
            ->method('getName')
            ->willReturn('MyLittleTaunTaun')
        ;

        $resourceCollection = $this->getMockWithoutConstructor(ResourceCollection::class);
        $resourceCollection
            ->expects($this->once())
            ->method('has')
            ->with('MyLittleTaunTaun')
            ->willReturn(true)
        ;
        $resourceCollection
            ->expects($this->once())
            ->method('get')
            ->with('MyLittleTaunTaun')
            ->willReturn($resource)
        ;

        $adminConfiguration = $this->getMockWithoutConstructor(AdminConfiguration::class);
        $adminConfiguration
            ->expects($this->once())
            ->method('getParameter')
            ->with('class')
            ->willReturn(Admin::class)
        ;

        $configurationFactory = $this->getMockWithoutConstructor(ConfigurationFactory::class);
        $configurationFactory
            ->expects($this->once())
            ->method('createAdminConfiguration')
            ->with('MyLittleTaunTaun')
            ->willReturn($adminConfiguration)
        ;

        $eventDispatcher = $this->getMockWithoutConstructor(EventDispatcherInterface::class);

        $applicationConfiguration = new ApplicationConfiguration();
        $applicationConfigurationStorage = $this->getMockWithoutConstructor(ApplicationConfigurationStorage::class);
        $applicationConfigurationStorage
            ->expects($this->once())
            ->method('getConfiguration')
            ->willReturn($applicationConfiguration)
        ;

        $request = new Request([
            '_admin' => 'MyLittleTaunTaun',
            '_route_params' => [
                '_admin' => 'MyLittleTaunTaun',
                '_action' => 'jump',
            ],
        ]);

        $adminFactory = new AdminFactory(
            $resourceCollection,
            $eventDispatcher,
            $configurationFactory,
            $applicationConfigurationStorage
        );

        $adminFactory->createFromRequest($request);
    }

    public function testCreateFromRequestWithoutRouteParams()

    {
        $resourceCollection = $this->getMockWithoutConstructor(ResourceCollection::class);
        $eventDispatcher = $this->getMockWithoutConstructor(EventDispatcherInterface::class);
        $configurationFactory = $this->getMockWithoutConstructor(ConfigurationFactory::class);
        $applicationConfigurationStorage = $this->getMockWithoutConstructor(ApplicationConfigurationStorage::class);

        $request = new Request();

        $adminFactory = new AdminFactory(
            $resourceCollection,
            $eventDispatcher,
            $configurationFactory,
            $applicationConfigurationStorage
        );

        $this->expectException(Exception::class);
        $adminFactory->createFromRequest($request);
    }

    public function testCreateFromRequestWithoutAdminParams()

    {
        $resourceCollection = $this->getMockWithoutConstructor(ResourceCollection::class);
        $eventDispatcher = $this->getMockWithoutConstructor(EventDispatcherInterface::class);
        $configurationFactory = $this->getMockWithoutConstructor(ConfigurationFactory::class);
        $applicationConfigurationStorage = $this->getMockWithoutConstructor(ApplicationConfigurationStorage::class);

        $request = new Request([
            '_route_params' => [],
        ]);

        $adminFactory = new AdminFactory(
            $resourceCollection,
            $eventDispatcher,
            $configurationFactory,
            $applicationConfigurationStorage
        );

        $this->expectException(Exception::class);
        $adminFactory->createFromRequest($request);
    }

    public function testCreateFromRequestWithoutExistingAdmin()
    {
        $resourceCollection = $this->getMockWithoutConstructor(ResourceCollection::class);
        $eventDispatcher = $this->getMockWithoutConstructor(EventDispatcherInterface::class);
        $configurationFactory = $this->getMockWithoutConstructor(ConfigurationFactory::class);
        $applicationConfigurationStorage = $this->getMockWithoutConstructor(ApplicationConfigurationStorage::class);

        $request = new Request([
            '_route_params' => [
                '_admin' => 'MyLittleTaunTaun',
                '_action' => 'jump',
            ],
        ]);

        $adminFactory = new AdminFactory(
            $resourceCollection,
            $eventDispatcher,
            $configurationFactory,
            $applicationConfigurationStorage
        );

        $this->expectException(Exception::class);
        $adminFactory->createFromRequest($request);
    }

    public function testCreateFromRequestWithInvalidAdminClass()

    {
        $resource = $this->getMockWithoutConstructor(AdminResource::class);
        $resource
            ->expects($this->atLeastOnce())
            ->method('getName')
            ->willReturn('MyLittleTaunTaun')
        ;

        $resourceCollection = $this->getMockWithoutConstructor(ResourceCollection::class);
        $resourceCollection
            ->expects($this->once())
            ->method('has')
            ->with('MyLittleTaunTaun')
            ->willReturn(true)
        ;
        $resourceCollection
            ->expects($this->once())
            ->method('get')
            ->with('MyLittleTaunTaun')
            ->willReturn($resource)
        ;

        $adminConfiguration = $this->getMockWithoutConstructor(AdminConfiguration::class);
        $adminConfiguration
            ->expects($this->once())
            ->method('getParameter')
            ->with('class')
            ->willReturn(FakeAdmin::class)
        ;

        $configurationFactory = $this->getMockWithoutConstructor(ConfigurationFactory::class);
        $configurationFactory
            ->expects($this->once())
            ->method('createAdminConfiguration')
            ->with('MyLittleTaunTaun')
            ->willReturn($adminConfiguration)
        ;

        $eventDispatcher = $this->getMockWithoutConstructor(EventDispatcherInterface::class);

        $applicationConfiguration = new ApplicationConfiguration();
        $applicationConfigurationStorage = $this->getMockWithoutConstructor(ApplicationConfigurationStorage::class);
        $applicationConfigurationStorage
            ->expects($this->once())
            ->method('getConfiguration')
            ->willReturn($applicationConfiguration)
        ;

        $request = new Request([
            '_admin' => 'MyLittleTaunTaun',
            '_route_params' => [
                '_admin' => 'MyLittleTaunTaun',
                '_action' => 'jump',
            ],
        ]);

        $adminFactory = new AdminFactory(
            $resourceCollection,
            $eventDispatcher,
            $configurationFactory,
            $applicationConfigurationStorage
        );

        $this->expectException(Exception::class);
        $adminFactory->createFromRequest($request);
    }
}


1		<?php
2
3		namespace LAG\AdminBundle\Tests\Factory;
4
5		use LAG\AdminBundle\Admin\Admin;
6		use LAG\AdminBundle\Configuration\AdminConfiguration;
7		use LAG\AdminBundle\Configuration\ApplicationConfiguration;
8		use LAG\AdminBundle\Configuration\ApplicationConfigurationStorage;
9		use LAG\AdminBundle\Exception\Exception;
10		use LAG\AdminBundle\Factory\AdminFactory;
11		use LAG\AdminBundle\Factory\ConfigurationFactory;
12		use LAG\AdminBundle\Resource\AdminResource;
13		use LAG\AdminBundle\Resource\ResourceCollection;
14		use LAG\AdminBundle\Tests\AdminTestBase;
15		use LAG\AdminBundle\Tests\Fixtures\FakeAdmin;
16		use Symfony\Component\EventDispatcher\EventDispatcherInterface;
17		use Symfony\Component\HttpFoundation\Request;
18
19		class AdminFactoryTest extends AdminTestBase
20		{
21	View Code Duplication	public function testCreateFromRequest()
		1 ignored issue – show Duplication introduced 2018-10-02 21:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22		{
23		$resource = $this->getMockWithoutConstructor(AdminResource::class);
24		$resource
25		->expects($this->atLeastOnce())
26		->method('getName')
27		->willReturn('MyLittleTaunTaun')
28		;
29
30		$resourceCollection = $this->getMockWithoutConstructor(ResourceCollection::class);
31		$resourceCollection
32		->expects($this->once())
33		->method('has')
34		->with('MyLittleTaunTaun')
35		->willReturn(true)
36		;
37		$resourceCollection
38		->expects($this->once())
39		->method('get')
40		->with('MyLittleTaunTaun')
41		->willReturn($resource)
42		;
43
44		$adminConfiguration = $this->getMockWithoutConstructor(AdminConfiguration::class);
45		$adminConfiguration
46		->expects($this->once())
47		->method('getParameter')
48		->with('class')
49		->willReturn(Admin::class)
50		;
51
52		$configurationFactory = $this->getMockWithoutConstructor(ConfigurationFactory::class);
53		$configurationFactory
54		->expects($this->once())
55		->method('createAdminConfiguration')
56		->with('MyLittleTaunTaun')
57		->willReturn($adminConfiguration)
58		;
59
60		$eventDispatcher = $this->getMockWithoutConstructor(EventDispatcherInterface::class);
61
62		$applicationConfiguration = new ApplicationConfiguration();
63		$applicationConfigurationStorage = $this->getMockWithoutConstructor(ApplicationConfigurationStorage::class);
64		$applicationConfigurationStorage
65		->expects($this->once())
66		->method('getConfiguration')
67		->willReturn($applicationConfiguration)
68		;
69
70		$request = new Request([
71		'_admin' => 'MyLittleTaunTaun',
72		'_route_params' => [
73		'_admin' => 'MyLittleTaunTaun',
74		'_action' => 'jump',
75		],
76		]);
77
78		$adminFactory = new AdminFactory(
79		$resourceCollection,
80		$eventDispatcher,
81		$configurationFactory,
82		$applicationConfigurationStorage
83		);
84
85		$adminFactory->createFromRequest($request);
86		}
87
88	View Code Duplication	public function testCreateFromRequestWithoutRouteParams()
		1 ignored issue – show Duplication introduced 2018-10-02 21:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
89		{
90		$resourceCollection = $this->getMockWithoutConstructor(ResourceCollection::class);
91		$eventDispatcher = $this->getMockWithoutConstructor(EventDispatcherInterface::class);
92		$configurationFactory = $this->getMockWithoutConstructor(ConfigurationFactory::class);
93		$applicationConfigurationStorage = $this->getMockWithoutConstructor(ApplicationConfigurationStorage::class);
94
95		$request = new Request();
96
97		$adminFactory = new AdminFactory(
98		$resourceCollection,
99		$eventDispatcher,
100		$configurationFactory,
101		$applicationConfigurationStorage
102		);
103
104		$this->expectException(Exception::class);
105		$adminFactory->createFromRequest($request);
106		}
107
108	View Code Duplication	public function testCreateFromRequestWithoutAdminParams()
		1 ignored issue – show Duplication introduced 2018-10-02 21:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
109		{
110		$resourceCollection = $this->getMockWithoutConstructor(ResourceCollection::class);
111		$eventDispatcher = $this->getMockWithoutConstructor(EventDispatcherInterface::class);
112		$configurationFactory = $this->getMockWithoutConstructor(ConfigurationFactory::class);
113		$applicationConfigurationStorage = $this->getMockWithoutConstructor(ApplicationConfigurationStorage::class);
114
115		$request = new Request([
116		'_route_params' => [],
117		]);
118
119		$adminFactory = new AdminFactory(
120		$resourceCollection,
121		$eventDispatcher,
122		$configurationFactory,
123		$applicationConfigurationStorage
124		);
125
126		$this->expectException(Exception::class);
127		$adminFactory->createFromRequest($request);
128		}
129
130		public function testCreateFromRequestWithoutExistingAdmin()
131		{
132		$resourceCollection = $this->getMockWithoutConstructor(ResourceCollection::class);
133		$eventDispatcher = $this->getMockWithoutConstructor(EventDispatcherInterface::class);
134		$configurationFactory = $this->getMockWithoutConstructor(ConfigurationFactory::class);
135		$applicationConfigurationStorage = $this->getMockWithoutConstructor(ApplicationConfigurationStorage::class);
136
137		$request = new Request([
138		'_route_params' => [
139		'_admin' => 'MyLittleTaunTaun',
140		'_action' => 'jump',
141		],
142		]);
143
144		$adminFactory = new AdminFactory(
145		$resourceCollection,
146		$eventDispatcher,
147		$configurationFactory,
148		$applicationConfigurationStorage
149		);
150
151		$this->expectException(Exception::class);
152		$adminFactory->createFromRequest($request);
153		}
154
155	View Code Duplication	public function testCreateFromRequestWithInvalidAdminClass()
		1 ignored issue – show Duplication introduced 2018-10-02 21:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
156		{
157		$resource = $this->getMockWithoutConstructor(AdminResource::class);
158		$resource
159		->expects($this->atLeastOnce())
160		->method('getName')
161		->willReturn('MyLittleTaunTaun')
162		;
163
164		$resourceCollection = $this->getMockWithoutConstructor(ResourceCollection::class);
165		$resourceCollection
166		->expects($this->once())
167		->method('has')
168		->with('MyLittleTaunTaun')
169		->willReturn(true)
170		;
171		$resourceCollection
172		->expects($this->once())
173		->method('get')
174		->with('MyLittleTaunTaun')
175		->willReturn($resource)
176		;
177
178		$adminConfiguration = $this->getMockWithoutConstructor(AdminConfiguration::class);
179		$adminConfiguration
180		->expects($this->once())
181		->method('getParameter')
182		->with('class')
183		->willReturn(FakeAdmin::class)
184		;
185
186		$configurationFactory = $this->getMockWithoutConstructor(ConfigurationFactory::class);
187		$configurationFactory
188		->expects($this->once())
189		->method('createAdminConfiguration')
190		->with('MyLittleTaunTaun')
191		->willReturn($adminConfiguration)
192		;
193
194		$eventDispatcher = $this->getMockWithoutConstructor(EventDispatcherInterface::class);
195
196		$applicationConfiguration = new ApplicationConfiguration();
197		$applicationConfigurationStorage = $this->getMockWithoutConstructor(ApplicationConfigurationStorage::class);
198		$applicationConfigurationStorage
199		->expects($this->once())
200		->method('getConfiguration')
201		->willReturn($applicationConfiguration)
202		;
203
204		$request = new Request([
205		'_admin' => 'MyLittleTaunTaun',
206		'_route_params' => [
207		'_admin' => 'MyLittleTaunTaun',
208		'_action' => 'jump',
209		],
210		]);
211
212		$adminFactory = new AdminFactory(
213		$resourceCollection,
214		$eventDispatcher,
215		$configurationFactory,
216		$applicationConfigurationStorage
217		);
218
219		$this->expectException(Exception::class);
220		$adminFactory->createFromRequest($request);
221		}
222		}
223

larriereguichet / AdminBundle

Push — refonte ( 50d758...cd6451 )

AdminFactoryTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like