LAG\AdminBundle\Utils\TranslationKeyTrait

Complexity

Total Complexity

3

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getTranslationKey()	0	11	3

<?php

namespace LAG\AdminBundle\Utils;

use LAG\AdminBundle\Application\Configuration\ApplicationConfiguration;

trait TranslationKeyTrait
{
    /**
     * @param ApplicationConfiguration $configuration
     * @param $key
     * @param string $adminName
     * @return string
     */
    public function getTranslationKey(ApplicationConfiguration $configuration, $key, $adminName = null)
    {
        $translationKey = $configuration->getParameter('translation')['pattern'];

        if (strstr($configuration->getParameter('translation')['pattern'], '{admin}') && $adminName != null) {

It seems like you are loosely comparing $adminName of type string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

            $translationKey = str_replace('{admin}', $adminName, $translationKey);
        }
        $translationKey = str_replace('{key}', $key, $translationKey);

        return $translationKey;
    }
}