ORMSubscriberTest::testAddOrder() - Code Metrics - Inspection of "Add test for the ORM data provider" - larriereguichet/AdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — refonte ( 225502...fa24e9 )

by Arnaud

created 2018-09-04 20:33 UTC

ORMSubscriberTest::testAddOrder() B

↳ Parent: ORMSubscriberTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	62
rs	8.829
c	0
b	0
f	0
cc	1
nc	1
nop	0

How to fix Long Method

<?php

namespace LAG\AdminBundle\Tests\Bridge\Doctrine\ORM\Event\Subscriber;

use Doctrine\ORM\QueryBuilder;
use LAG\AdminBundle\Admin\ActionInterface;
use LAG\AdminBundle\Admin\AdminInterface;
use LAG\AdminBundle\Bridge\Doctrine\ORM\Event\Subscriber\ORMSubscriber;
use LAG\AdminBundle\Configuration\ActionConfiguration;
use LAG\AdminBundle\Event\AdminEvents;
use LAG\AdminBundle\Event\DoctrineOrmFilterEvent;
use LAG\AdminBundle\Filter\FilterInterface;
use LAG\AdminBundle\Tests\AdminTestBase;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;

class ORMSubscriberTest extends AdminTestBase
{
    public function testGetSubscribedEvents()
    {
        $events = ORMSubscriber::getSubscribedEvents();
        $this->assertArrayHasKey(AdminEvents::DOCTRINE_ORM_FILTER, $events);
        $this->assertContains('addOrder', $events[AdminEvents::DOCTRINE_ORM_FILTER][0]);
        $this->assertContains('addFilters', $events[AdminEvents::DOCTRINE_ORM_FILTER][1]);
    }

    public function testAddOrder()
    {
        $request = new Request();

        $requestStack = $this->getMockWithoutConstructor(RequestStack::class);
        $requestStack
            ->expects($this->atLeastOnce())
            ->method('getMasterRequest')
            ->willReturn($request)
        ;
        $admin = $this->getMockWithoutConstructor(AdminInterface::class);
        $action = $this->getMockWithoutConstructor(ActionInterface::class);

        $configuration = $this->getMockWithoutConstructor(ActionConfiguration::class);
        $configuration
            ->expects($this->once())
            ->method('getParameter')
            ->with('order')
            ->willReturn([
                'id' => 'desc',
            ])
        ;

        $queryBuilder = $this->getMockWithoutConstructor(QueryBuilder::class);
        $queryBuilder
            ->expects($this->once())
            ->method('getRootAliases')
            ->willReturn([
                'entity',
            ])
        ;
        $queryBuilder
            ->expects($this->once())
            ->method('addOrderBy')
            ->with('entity.id', 'desc')
        ;

        $event = $this->getMockWithoutConstructor(DoctrineOrmFilterEvent::class);
        $event
            ->expects($this->once())
            ->method('getQueryBuilder')
            ->willReturn($queryBuilder)
        ;
        $event
            ->expects($this->once())
            ->method('getAdmin')
            ->willReturn($admin)
        ;
        $admin
            ->expects($this->once())
            ->method('getAction')
            ->willReturn($action)
        ;
        $action
            ->expects($this->once())
            ->method('getConfiguration')
            ->willReturn($configuration)
        ;

        $subscriber = new ORMSubscriber($requestStack);
        $subscriber->addOrder($event);
    }

    public function testAddFilters()
    {
        $requestStack = $this->getMockWithoutConstructor(RequestStack::class);
        $queryBuilder = $this->getMockWithoutConstructor(QueryBuilder::class);
        $queryBuilder
            ->expects($this->once())
            ->method('getRootAliases')
            ->willReturn([
                'entity',
            ])
        ;
        $queryBuilder
            ->expects($this->once())
            ->method('andWhere')
            ->with('entity.name like :filter_name')
        ;
        $queryBuilder
            ->expects($this->once())
            ->method('setParameter')
            ->with('filter_name', '%test%')
        ;

        $filter1 = $this->getMockWithoutConstructor(FilterInterface::class);
        $filter1
            ->method('getName')
            ->willReturn('name')
        ;
        $filter1
            ->method('getOperator')
            ->willReturn('like')
        ;
        $filter1
            ->expects($this->once())
            ->method('getValue')
            ->willReturn('test')
        ;

        $event = $this->getMockWithoutConstructor(DoctrineOrmFilterEvent::class);
        $event
            ->expects($this->once())
            ->method('getQueryBuilder')
            ->willReturn($queryBuilder)
        ;
        $event
            ->expects($this->once())
            ->method('getFilters')
            ->willReturn([
                $filter1,
            ])
        ;

        $subscriber = new ORMSubscriber($requestStack);
        $subscriber->addFilters($event);
    }
}


1			<?php
2
3			namespace LAG\AdminBundle\Tests\Bridge\Doctrine\ORM\Event\Subscriber;
4
5			use Doctrine\ORM\QueryBuilder;
6			use LAG\AdminBundle\Admin\ActionInterface;
7			use LAG\AdminBundle\Admin\AdminInterface;
8			use LAG\AdminBundle\Bridge\Doctrine\ORM\Event\Subscriber\ORMSubscriber;
9			use LAG\AdminBundle\Configuration\ActionConfiguration;
10			use LAG\AdminBundle\Event\AdminEvents;
11			use LAG\AdminBundle\Event\DoctrineOrmFilterEvent;
12			use LAG\AdminBundle\Filter\FilterInterface;
13			use LAG\AdminBundle\Tests\AdminTestBase;
14			use Symfony\Component\HttpFoundation\Request;
15			use Symfony\Component\HttpFoundation\RequestStack;
16
17			class ORMSubscriberTest extends AdminTestBase
18			{
19			public function testGetSubscribedEvents()
20			{
21			$events = ORMSubscriber::getSubscribedEvents();
22			$this->assertArrayHasKey(AdminEvents::DOCTRINE_ORM_FILTER, $events);
23			$this->assertContains('addOrder', $events[AdminEvents::DOCTRINE_ORM_FILTER][0]);
24			$this->assertContains('addFilters', $events[AdminEvents::DOCTRINE_ORM_FILTER][1]);
25			}
26
27			public function testAddOrder()
28			{
29			$request = new Request();
30
31			$requestStack = $this->getMockWithoutConstructor(RequestStack::class);
32			$requestStack
33			->expects($this->atLeastOnce())
34			->method('getMasterRequest')
35			->willReturn($request)
36			;
37			$admin = $this->getMockWithoutConstructor(AdminInterface::class);
38			$action = $this->getMockWithoutConstructor(ActionInterface::class);
39
40			$configuration = $this->getMockWithoutConstructor(ActionConfiguration::class);
41			$configuration
42			->expects($this->once())
43			->method('getParameter')
44			->with('order')
45			->willReturn([
46			'id' => 'desc',
47			])
48			;
49
50			$queryBuilder = $this->getMockWithoutConstructor(QueryBuilder::class);
51			$queryBuilder
52			->expects($this->once())
53			->method('getRootAliases')
54			->willReturn([
55			'entity',
56			])
57			;
58			$queryBuilder
59			->expects($this->once())
60			->method('addOrderBy')
61			->with('entity.id', 'desc')
62			;
63
64			$event = $this->getMockWithoutConstructor(DoctrineOrmFilterEvent::class);
65			$event
66			->expects($this->once())
67			->method('getQueryBuilder')
68			->willReturn($queryBuilder)
69			;
70			$event
71			->expects($this->once())
72			->method('getAdmin')
73			->willReturn($admin)
74			;
75			$admin
76			->expects($this->once())
77			->method('getAction')
78			->willReturn($action)
79			;
80			$action
81			->expects($this->once())
82			->method('getConfiguration')
83			->willReturn($configuration)
84			;
85
86			$subscriber = new ORMSubscriber($requestStack);
87			$subscriber->addOrder($event);
88			}
89
90			public function testAddFilters()
91			{
92			$requestStack = $this->getMockWithoutConstructor(RequestStack::class);
93			$queryBuilder = $this->getMockWithoutConstructor(QueryBuilder::class);
94			$queryBuilder
95			->expects($this->once())
96			->method('getRootAliases')
97			->willReturn([
98			'entity',
99			])
100			;
101			$queryBuilder
102			->expects($this->once())
103			->method('andWhere')
104			->with('entity.name like :filter_name')
105			;
106			$queryBuilder
107			->expects($this->once())
108			->method('setParameter')
109			->with('filter_name', '%test%')
110			;
111
112			$filter1 = $this->getMockWithoutConstructor(FilterInterface::class);
113			$filter1
114			->method('getName')
115			->willReturn('name')
116			;
117			$filter1
118			->method('getOperator')
119			->willReturn('like')
120			;
121			$filter1
122			->expects($this->once())
123			->method('getValue')
124			->willReturn('test')
125			;
126
127			$event = $this->getMockWithoutConstructor(DoctrineOrmFilterEvent::class);
128			$event
129			->expects($this->once())
130			->method('getQueryBuilder')
131			->willReturn($queryBuilder)
132			;
133			$event
134			->expects($this->once())
135			->method('getFilters')
136			->willReturn([
137			$filter1,
138			])
139			;
140
141			$subscriber = new ORMSubscriber($requestStack);
142			$subscriber->addFilters($event);
143			}
144			}
145

larriereguichet / AdminBundle

Push — refonte ( 225502...fa24e9 )

ORMSubscriberTest::testAddOrder() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like