Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 8 | View Code Duplication | class ActionCreateEvent extends Event |
|
| 9 | { |
||
| 10 | /** |
||
| 11 | * @var array |
||
| 12 | */ |
||
| 13 | protected $actionConfiguration; |
||
| 14 | |||
| 15 | /** |
||
| 16 | * @var string |
||
| 17 | */ |
||
| 18 | protected $actionName; |
||
| 19 | |||
| 20 | /** |
||
| 21 | * @var AdminInterface |
||
| 22 | */ |
||
| 23 | protected $admin; |
||
| 24 | |||
| 25 | /** |
||
| 26 | * ActionCreateEvent constructor. |
||
| 27 | * |
||
| 28 | * @param string $actionName |
||
| 29 | * @param array $actionConfiguration |
||
| 30 | * @param AdminInterface $admin |
||
| 31 | */ |
||
| 32 | 3 | public function __construct($actionName, array $actionConfiguration, AdminInterface $admin) |
|
| 38 | |||
| 39 | /** |
||
| 40 | * @return array |
||
| 41 | */ |
||
| 42 | 1 | public function getActionConfiguration() |
|
| 46 | |||
| 47 | /** |
||
| 48 | * @return string |
||
| 49 | */ |
||
| 50 | 1 | public function getActionName() |
|
| 54 | |||
| 55 | /** |
||
| 56 | * @return AdminInterface |
||
| 57 | */ |
||
| 58 | 1 | public function getAdmin() |
|
| 62 | |||
| 63 | /** |
||
| 64 | * @param array $actionConfiguration |
||
| 65 | */ |
||
| 66 | 1 | public function setActionConfiguration($actionConfiguration) |
|
| 70 | } |
||
| 71 |