ViewFactoryTest::testCreate() - Code Metrics - Inspection of "Fix duplicate key in translation files" - larriereguichet/AdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — refonte ( 545937...700c72 )

by Arnaud

created 2018-08-04 18:25 UTC

ViewFactoryTest::testCreate() A

↳ Parent: ViewFactoryTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	46
rs	9.1781
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace LAG\AdminBundle\Tests\Factory;

use LAG\AdminBundle\Configuration\ActionConfiguration;
use LAG\AdminBundle\Configuration\AdminConfiguration;
use LAG\AdminBundle\Factory\ConfigurationFactory;
use LAG\AdminBundle\Factory\FieldFactory;
use LAG\AdminBundle\Factory\MenuFactory;
use LAG\AdminBundle\Factory\ViewFactory;
use LAG\AdminBundle\Tests\AdminTestBase;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Routing\RouterInterface;

class ViewFactoryTest extends AdminTestBase
{
    public function testCreate()
    {
        $request = new Request();
        $adminConfiguration = $this->getMockWithoutConstructor(AdminConfiguration::class);
        $actionConfiguration = $this->getMockWithoutConstructor(ActionConfiguration::class);
        $entities = [];

        $configurationFactory = $this->getMockWithoutConstructor(ConfigurationFactory::class);

        $fieldFactory = $this->getMockWithoutConstructor(FieldFactory::class);
        $fieldFactory
            ->expects($this->once())
            ->method('getFields')
            ->with($actionConfiguration)
            ->willReturn([])
        ;

        $menuFactory = $this->getMockWithoutConstructor(MenuFactory::class);
        $router = $this->getMockWithoutConstructor(RouterInterface::class);

        $factory = new ViewFactory(
            $configurationFactory,
            $fieldFactory,
            $menuFactory,
            $router
        );

        $form = $this->getMockWithoutConstructor(FormInterface::class);
        $form
            ->expects($this->once())
            ->method('createView')
        ;
        $forms = [
            'planet_form' => $form,
        ];

        $view = $factory->create(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $request,
            'atomize',
            'planet',
            $adminConfiguration,
            $actionConfiguration,
            $entities,
            $forms
        );
    }

    public function testCreateWithRedirection()
    {
        $request = new Request([
            'submit_and_redirect' => 'submit_and_redirect',
        ]);
        $entities = [];

        $adminConfiguration = $this->getMockWithoutConstructor(AdminConfiguration::class);
        $adminConfiguration
            ->expects($this->atLeastOnce())
            ->method('getParameter')
            ->willReturnMap([
                ['actions', [
                    'list' => [],
                ]],
                ['routing_name_pattern', '{admin}.{action}'],
            ])
        ;
        $actionConfiguration = $this->getMockWithoutConstructor(ActionConfiguration::class);

        $entityForm = $this->getMockWithoutConstructor(FormInterface::class);
        $entityForm
            ->expects($this->once())
            ->method('isSubmitted')
            ->willReturn(true)
        ;
        $entityForm
            ->expects($this->once())
            ->method('isValid')
            ->willReturn(true)
        ;
        $forms = [
            'entity' => $entityForm,
        ];

        $configurationFactory = $this->getMockWithoutConstructor(ConfigurationFactory::class);

        $fieldFactory = $this->getMockWithoutConstructor(FieldFactory::class);
        $fieldFactory
            ->expects($this->never())
            ->method('getFields')
        ;

        $menuFactory = $this->getMockWithoutConstructor(MenuFactory::class);
        $router = $this->getMockWithoutConstructor(RouterInterface::class);
        $router
            ->expects($this->once())
            ->method('generate')
            ->with('planet.list')
            ->willReturn('/planet/atomize')
        ;

        $factory = new ViewFactory(
            $configurationFactory,
            $fieldFactory,
            $menuFactory,
            $router
        );

        $factory->create(
            $request,
            'atomize',
            'planet',
            $adminConfiguration,
            $actionConfiguration,
            $entities,
            $forms
        );
    }
}


1			<?php
2
3			namespace LAG\AdminBundle\Tests\Factory;
4
5			use LAG\AdminBundle\Configuration\ActionConfiguration;
6			use LAG\AdminBundle\Configuration\AdminConfiguration;
7			use LAG\AdminBundle\Factory\ConfigurationFactory;
8			use LAG\AdminBundle\Factory\FieldFactory;
9			use LAG\AdminBundle\Factory\MenuFactory;
10			use LAG\AdminBundle\Factory\ViewFactory;
11			use LAG\AdminBundle\Tests\AdminTestBase;
12			use Symfony\Component\Form\FormInterface;
13			use Symfony\Component\HttpFoundation\Request;
14			use Symfony\Component\Routing\RouterInterface;
15
16			class ViewFactoryTest extends AdminTestBase
17			{
18			public function testCreate()
19			{
20			$request = new Request();
21			$adminConfiguration = $this->getMockWithoutConstructor(AdminConfiguration::class);
22			$actionConfiguration = $this->getMockWithoutConstructor(ActionConfiguration::class);
23			$entities = [];
24
25			$configurationFactory = $this->getMockWithoutConstructor(ConfigurationFactory::class);
26
27			$fieldFactory = $this->getMockWithoutConstructor(FieldFactory::class);
28			$fieldFactory
29			->expects($this->once())
30			->method('getFields')
31			->with($actionConfiguration)
32			->willReturn([])
33			;
34
35			$menuFactory = $this->getMockWithoutConstructor(MenuFactory::class);
36			$router = $this->getMockWithoutConstructor(RouterInterface::class);
37
38			$factory = new ViewFactory(
39			$configurationFactory,
40			$fieldFactory,
41			$menuFactory,
42			$router
43			);
44
45			$form = $this->getMockWithoutConstructor(FormInterface::class);
46			$form
47			->expects($this->once())
48			->method('createView')
49			;
50			$forms = [
51			'planet_form' => $form,
52			];
53
54			$view = $factory->create(
			0 ignored issues – show Unused Code introduced 2018-08-04 18:27 UTC by Report Bug Copy Issue Report `$view` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
55			$request,
56			'atomize',
57			'planet',
58			$adminConfiguration,
59			$actionConfiguration,
60			$entities,
61			$forms
62			);
63			}
64
65			public function testCreateWithRedirection()
66			{
67			$request = new Request([
68			'submit_and_redirect' => 'submit_and_redirect',
69			]);
70			$entities = [];
71
72			$adminConfiguration = $this->getMockWithoutConstructor(AdminConfiguration::class);
73			$adminConfiguration
74			->expects($this->atLeastOnce())
75			->method('getParameter')
76			->willReturnMap([
77			['actions', [
78			'list' => [],
79			]],
80			['routing_name_pattern', '{admin}.{action}'],
81			])
82			;
83			$actionConfiguration = $this->getMockWithoutConstructor(ActionConfiguration::class);
84
85			$entityForm = $this->getMockWithoutConstructor(FormInterface::class);
86			$entityForm
87			->expects($this->once())
88			->method('isSubmitted')
89			->willReturn(true)
90			;
91			$entityForm
92			->expects($this->once())
93			->method('isValid')
94			->willReturn(true)
95			;
96			$forms = [
97			'entity' => $entityForm,
98			];
99
100			$configurationFactory = $this->getMockWithoutConstructor(ConfigurationFactory::class);
101
102			$fieldFactory = $this->getMockWithoutConstructor(FieldFactory::class);
103			$fieldFactory
104			->expects($this->never())
105			->method('getFields')
106			;
107
108			$menuFactory = $this->getMockWithoutConstructor(MenuFactory::class);
109			$router = $this->getMockWithoutConstructor(RouterInterface::class);
110			$router
111			->expects($this->once())
112			->method('generate')
113			->with('planet.list')
114			->willReturn('/planet/atomize')
115			;
116
117			$factory = new ViewFactory(
118			$configurationFactory,
119			$fieldFactory,
120			$menuFactory,
121			$router
122			);
123
124			$factory->create(
125			$request,
126			'atomize',
127			'planet',
128			$adminConfiguration,
129			$actionConfiguration,
130			$entities,
131			$forms
132			);
133			}
134			}
135

larriereguichet / AdminBundle

Push — refonte ( 545937...700c72 )

ViewFactoryTest::testCreate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like