View::haveToPaginate() - Code Metrics - Inspection of "V.1.0" - larriereguichet/AdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#90)

by Arnaud

created 2017-12-08 23:57 UTC

View::haveToPaginate() A

↳ Parent: View

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

namespace LAG\AdminBundle\View;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use LAG\AdminBundle\Action\Configuration\ActionConfiguration;
use LAG\AdminBundle\Admin\Configuration\AdminConfiguration;
use LAG\AdminBundle\Field\FieldInterface;
use Pagerfanta\Pagerfanta;

class View implements ViewInterface
{
    /**
     * @var string
     */
    private $actionName;
    
    /**
     * @var ActionConfiguration
     */
    private $configuration;
    
    /**
     * @var string
     */
    private $adminName;
    
    /**
     * @var array|Collection
     */
    private $entities = [];
    
    /**
     * @var FieldInterface[]
     */
    private $fields;
    
    /**
     * @var AdminConfiguration
     */
    private $adminConfiguration;
    
    /**
     * @var bool
     */
    private $haveToPaginate = false;
    
    /**
     * @var int
     */
    private $totalCount = 0;
    
    /**
     * @var Pagerfanta
     */
    private $pager;
    
    /**
     * View constructor.
     *
     * @param                     $actionName
     * @param                     $adminName
     * @param ActionConfiguration $configuration
     * @param AdminConfiguration  $adminConfiguration
     * @param array               $fields
     */
    public function __construct(
        $actionName,
        $adminName,
        ActionConfiguration $configuration,
        AdminConfiguration $adminConfiguration,
        array $fields = []
    ) {
        $this->actionName = $actionName;
        $this->configuration = $configuration;
        $this->adminName = $adminName;
        $this->fields = $fields;
        $this->adminConfiguration = $adminConfiguration;
    }
    
    /**
     * @return ActionConfiguration
     */
    public function getConfiguration()
    {
        return $this->configuration;
    }
    
    /**
     * @return string
     */
    public function getActionName()
    {
        return $this->actionName;
    }
    
    /**
     * @return array
     */
    public function getEntities()
    {
        return $this->entities;
    }
    
    /**
     * @param $entities
     */
    public function setEntities($entities)
    {
        if ($entities instanceof Pagerfanta) {
            $this->pager = $entities;
            $this->entities = new ArrayCollection($entities->getCurrentPageResults());

            $this->haveToPaginate = true;
            $this->totalCount = $entities->count();
        } else {
            $this->entities = $entities;
            $this->totalCount = count($entities);
        }
    }
    
    /**
     * @return string
     */
    public function getName()
    {
        return $this->adminName;
    }
    
    /**
     * @return FieldInterface[]
     */
    public function getFields()
    {
        return $this->fields;
    }
    
    /**
     * @return AdminConfiguration
     */
    public function getAdminConfiguration()
    {
        return $this->adminConfiguration;
    }
    
    /**
     * @return bool
     */
    public function haveToPaginate()
    {
        return $this->haveToPaginate;
    }
    
    /**
     * @return int
     */
    public function getTotalCount()
    {
        return $this->totalCount;
    }
    
    /**
     * @return Pagerfanta|null
     */
    public function getPager()
    {
        return $this->pager;
    }
}


1			<?php
2
3			namespace LAG\AdminBundle\View;
4
5			use Doctrine\Common\Collections\ArrayCollection;
6			use Doctrine\Common\Collections\Collection;
7			use LAG\AdminBundle\Action\Configuration\ActionConfiguration;
8			use LAG\AdminBundle\Admin\Configuration\AdminConfiguration;
9			use LAG\AdminBundle\Field\FieldInterface;
10			use Pagerfanta\Pagerfanta;
11
12			class View implements ViewInterface
13			{
14			/**
15			* @var string
16			*/
17			private $actionName;
18
19			/**
20			* @var ActionConfiguration
21			*/
22			private $configuration;
23
24			/**
25			* @var string
26			*/
27			private $adminName;
28
29			/**
30			* @var array\|Collection
31			*/
32			private $entities = [];
33
34			/**
35			* @var FieldInterface[]
36			*/
37			private $fields;
38
39			/**
40			* @var AdminConfiguration
41			*/
42			private $adminConfiguration;
43
44			/**
45			* @var bool
46			*/
47			private $haveToPaginate = false;
48
49			/**
50			* @var int
51			*/
52			private $totalCount = 0;
53
54			/**
55			* @var Pagerfanta
56			*/
57			private $pager;
58
59			/**
60			* View constructor.
61			*
62			* @param $actionName
63			* @param $adminName
64			* @param ActionConfiguration $configuration
65			* @param AdminConfiguration $adminConfiguration
66			* @param array $fields
67			*/
68			public function __construct(
69			$actionName,
70			$adminName,
71			ActionConfiguration $configuration,
72			AdminConfiguration $adminConfiguration,
73			array $fields = []
74			) {
75			$this->actionName = $actionName;
76			$this->configuration = $configuration;
77			$this->adminName = $adminName;
78			$this->fields = $fields;
79			$this->adminConfiguration = $adminConfiguration;
80			}
81
82			/**
83			* @return ActionConfiguration
84			*/
85			public function getConfiguration()
86			{
87			return $this->configuration;
88			}
89
90			/**
91			* @return string
92			*/
93			public function getActionName()
94			{
95			return $this->actionName;
96			}
97
98			/**
99			* @return array
100			*/
101			public function getEntities()
102			{
103			return $this->entities;
104			}
105
106			/**
107			* @param $entities
108			*/
109			public function setEntities($entities)
110			{
111			if ($entities instanceof Pagerfanta) {
112			$this->pager = $entities;
113			$this->entities = new ArrayCollection($entities->getCurrentPageResults());
			0 ignored issues – show Bug introduced 2017-10-08 21:39 UTC by Report Bug Copy Issue Report It seems like `$entities->getCurrentPageResults()` targeting `Pagerfanta\Pagerfanta::getCurrentPageResults()` can also be of type `object<Traversable>`; however, `Doctrine\Common\Collecti...llection::__construct()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
114			$this->haveToPaginate = true;
115			$this->totalCount = $entities->count();
116			} else {
117			$this->entities = $entities;
118			$this->totalCount = count($entities);
119			}
120			}
121
122			/**
123			* @return string
124			*/
125			public function getName()
126			{
127			return $this->adminName;
128			}
129
130			/**
131			* @return FieldInterface[]
132			*/
133			public function getFields()
134			{
135			return $this->fields;
136			}
137
138			/**
139			* @return AdminConfiguration
140			*/
141			public function getAdminConfiguration()
142			{
143			return $this->adminConfiguration;
144			}
145
146			/**
147			* @return bool
148			*/
149			public function haveToPaginate()
150			{
151			return $this->haveToPaginate;
152			}
153
154			/**
155			* @return int
156			*/
157			public function getTotalCount()
158			{
159			return $this->totalCount;
160			}
161
162			/**
163			* @return Pagerfanta\|null
164			*/
165			public function getPager()
166			{
167			return $this->pager;
168			}
169			}
170

larriereguichet / AdminBundle

Pull Request — master (#90)

View::haveToPaginate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like