Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 10 | class LoadParameterExtractor |
||
| 11 | { |
||
| 12 | /** |
||
| 13 | * @var ActionConfiguration |
||
| 14 | */ |
||
| 15 | private $configuration; |
||
| 16 | |||
| 17 | /** |
||
| 18 | * @var array |
||
| 19 | */ |
||
| 20 | private $criteria = []; |
||
| 21 | |||
| 22 | /** |
||
| 23 | * @var array |
||
| 24 | */ |
||
| 25 | private $order = []; |
||
| 26 | |||
| 27 | /** |
||
| 28 | * @var int |
||
| 29 | */ |
||
| 30 | private $maxPerPage = 5000; |
||
| 31 | |||
| 32 | /** |
||
| 33 | * @var int |
||
| 34 | */ |
||
| 35 | private $page = 1; |
||
| 36 | |||
| 37 | /** |
||
| 38 | * LoadParameterExtractor constructor. |
||
| 39 | * |
||
| 40 | * @param ActionConfiguration $configuration |
||
| 41 | 4 | * @param array $filters |
|
| 42 | * |
||
| 43 | 4 | * @throws Exception |
|
| 44 | 4 | */ |
|
| 45 | public function __construct(ActionConfiguration $configuration, array $filters = []) |
||
| 65 | 4 | ||
| 66 | /** |
||
| 67 | * @param Request $request |
||
| 68 | 4 | */ |
|
| 69 | public function load(Request $request) |
||
| 75 | 4 | ||
| 76 | /** |
||
| 77 | * Get the criteria values. |
||
| 78 | * |
||
| 79 | * @param Request $request |
||
| 80 | 4 | */ |
|
| 81 | private function loadCriteria(Request $request) |
||
| 96 | |||
| 97 | /** |
||
| 98 | * @param Request $request |
||
| 99 | */ |
||
| 100 | private function loadOrder(Request $request) |
||
| 122 | |||
| 123 | /** |
||
| 124 | 4 | * Get the pagination values. |
|
| 125 | * |
||
| 126 | * @param Request $request |
||
| 127 | */ |
||
| 128 | private function loadPagination(Request $request) |
||
| 151 | |||
| 152 | /** |
||
| 153 | 4 | * @return array |
|
| 154 | */ |
||
| 155 | 4 | public function getCriteria() |
|
| 159 | |||
| 160 | /** |
||
| 161 | * @return array |
||
| 162 | */ |
||
| 163 | public function getOrder() |
||
| 167 | |||
| 168 | /** |
||
| 169 | * @return int |
||
| 170 | */ |
||
| 171 | public function getMaxPerPage() |
||
| 175 | |||
| 176 | /** |
||
| 177 | * @return int |
||
| 178 | */ |
||
| 179 | public function getPage() |
||
| 183 | } |
||
| 184 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.