Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | class ConfigurationFactory |
||
| 12 | { |
||
| 13 | /** |
||
| 14 | * @var ApplicationConfiguration |
||
| 15 | */ |
||
| 16 | protected $applicationConfiguration; |
||
| 17 | |||
| 18 | /** |
||
| 19 | * Create an action configuration object. |
||
| 20 | * |
||
| 21 | * @param $actionName |
||
| 22 | * @param AdminInterface $admin |
||
| 23 | * @param array $configuration |
||
| 24 | * @return ActionConfiguration |
||
| 25 | */ |
||
| 26 | 1 | View Code Duplication | public function createActionConfiguration($actionName, AdminInterface $admin, array $configuration = []) |
| 27 | { |
||
| 28 | 1 | $resolver = new OptionsResolver(); |
|
| 29 | 1 | $actionConfiguration = new ActionConfiguration($actionName, $admin); |
|
| 30 | 1 | $actionConfiguration->configureOptions($resolver); |
|
| 31 | 1 | $actionConfiguration->setParameters($resolver->resolve($configuration)); |
|
| 32 | |||
| 33 | 1 | return $actionConfiguration; |
|
| 34 | } |
||
| 35 | |||
| 36 | /** |
||
| 37 | * Create an application configuration object. |
||
| 38 | * |
||
| 39 | * @param array $configuration |
||
| 40 | * @return ApplicationConfiguration |
||
| 41 | */ |
||
| 42 | 12 | public function createApplicationConfiguration(array $configuration = []) |
|
| 51 | |||
| 52 | /** |
||
| 53 | * Create an admin configuration object. |
||
| 54 | * |
||
| 55 | * @param array $configuration |
||
| 56 | * @return AdminConfiguration |
||
| 57 | */ |
||
| 58 | 5 | View Code Duplication | public function createAdminConfiguration(array $configuration = []) |
| 59 | { |
||
| 60 | 5 | $resolver = new OptionsResolver(); |
|
| 61 | 5 | $adminConfiguration = new AdminConfiguration($this->applicationConfiguration); |
|
| 62 | 5 | $adminConfiguration->configureOptions($resolver); |
|
| 63 | 5 | $adminConfiguration->setParameters($resolver->resolve($configuration)); |
|
| 64 | |||
| 65 | 5 | return $adminConfiguration; |
|
| 66 | } |
||
| 67 | |||
| 68 | /** |
||
| 69 | * @return ApplicationConfiguration |
||
| 70 | */ |
||
| 71 | 3 | public function getApplicationConfiguration() |
|
| 75 | } |
||
| 76 |