LAG\AdminBundle\Configuration\Factory\ConfigurationFactory

Complexity

Total Complexity

4

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	createActionConfiguration()	0	9	1
A	createApplicationConfiguration()	0	9	1
A	createAdminConfiguration()	0	9	1
A	getApplicationConfiguration()	0	4	1

<?php

namespace LAG\AdminBundle\Configuration\Factory;

use LAG\AdminBundle\Action\Configuration\ActionConfiguration;
use LAG\AdminBundle\Admin\AdminInterface;
use LAG\AdminBundle\Admin\Configuration\AdminConfiguration;
use LAG\AdminBundle\Application\Configuration\ApplicationConfiguration;
use Symfony\Component\OptionsResolver\OptionsResolver;

class ConfigurationFactory
{
    /**
     * @var ApplicationConfiguration
     */
    protected $applicationConfiguration;

    /**
     * Create an action configuration object.
     *
     * @param $actionName
     * @param AdminInterface|null $admin
     * @param array $configuration
     * @return ActionConfiguration
     */
    public function createActionConfiguration($actionName, AdminInterface $admin = null, array $configuration = [])
    {
        $resolver = new OptionsResolver();
        $actionConfiguration = new ActionConfiguration($actionName, $admin);

It seems like $admin defined by parameter $admin on line 26 can be null; however, LAG\AdminBundle\Action\Configuration\ActionConfiguration::__construct() does not accept null, maybe add an additional type check?

        $actionConfiguration->configureOptions($resolver);
        $actionConfiguration->setParameters($resolver->resolve($configuration));

        return $actionConfiguration;
    }

    /**
     * Create an application configuration object.
     *
     * @param array $configuration
     * @return ApplicationConfiguration
     */
    public function createApplicationConfiguration(array $configuration = [])
    {
        $resolver = new OptionsResolver();
        $this->applicationConfiguration = new ApplicationConfiguration();
        $this->applicationConfiguration->configureOptions($resolver);
        $this->applicationConfiguration->setParameters($resolver->resolve($configuration));

        return $this->applicationConfiguration;
    }

    /**
     * Create an admin configuration object.
     *
     * @param array $configuration
     * @return AdminConfiguration
     */
    public function createAdminConfiguration(array $configuration = [])
    {
        $resolver = new OptionsResolver();
        $adminConfiguration = new AdminConfiguration($this->applicationConfiguration);
        $adminConfiguration->configureOptions($resolver);
        $adminConfiguration->setParameters($resolver->resolve($configuration));

        return $adminConfiguration;
    }

    /**
     * @return ApplicationConfiguration
     */
    public function getApplicationConfiguration()
    {
        return $this->applicationConfiguration;
    }
}