LAG\AdminBundle\Action\ListAction

Complexity

Total Complexity

7

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	6

Test Coverage

Coverage

95.45%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setFilterFormBuilder()	0	4	1
B	__invoke()	0	43	6

<?php

namespace LAG\AdminBundle\Action;

use LAG\AdminBundle\Filter\Factory\FilterFormBuilder;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

class ListAction extends Action
{
    /**
     * @var FilterFormBuilder
     */
    private $filterFormBuilder;
    
    /**
     * @param Request $request
     *
     * @return Response
     */
    public function __invoke(Request $request)
    {
        // build the filters form
        $filterForm = $this
            ->filterFormBuilder
            ->build($this->configuration)
        ;
        $filters = [];

        // load the filters
        if (null !== $filterForm) {
            $filterForm->handleRequest($request);
    
            if ($filterForm->isSubmitted() && $filterForm->isValid()) {
                $filters = $filterForm->getData();
            }
        }
        
        // load the entities
        $this
            ->admin
            ->handleRequest($request, $filters)
        ;
    
        $form = $this
            ->formFactory
            ->create(
                $this->configuration->getParameter('form'),
                $this->admin->getEntities(),
                $this->configuration->getParameter('form_options')
            )
        ;
        $form->handleRequest($request);
    
        if ($form->isSubmitted() && $form->isValid()) {

This if statement is empty and can be removed.

            // TODO do something with the selected entities
        }
    
        return $this

The method respond does only exist in LAG\AdminBundle\Action\Responder\CreateResponder and LAG\AdminBundle\Action\Responder\DeleteResponder and LAG\AdminBundle\Action\Responder\EditResponder, but not in LAG\AdminBundle\Action\Responder\ResponderInterface.

            ->responder
            ->respond($this->configuration, $this->admin, $form, $filterForm)

$filterForm is of type object<Symfony\Component\Form\FormInterface>|null, but the function expects a object<Symfony\Component\HttpFoundation\Request>.

The call to DeleteResponder::respond() has too many arguments starting with $filterForm.

        ;
    }
    
    /**
     * @param FilterFormBuilder $filterFormBuilder
     */
    public function setFilterFormBuilder($filterFormBuilder)
    {
        $this->filterFormBuilder = $filterFormBuilder;
    }
}