Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Admin often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Admin, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
26 | class Admin implements AdminInterface |
||
27 | { |
||
28 | use AdminTrait; |
||
29 | |||
30 | /** |
||
31 | * Entities collection. |
||
32 | * |
||
33 | * @var ArrayCollection |
||
34 | */ |
||
35 | protected $entities; |
||
36 | |||
37 | /** |
||
38 | * @var MessageHandlerInterface |
||
39 | */ |
||
40 | protected $messageHandler; |
||
41 | |||
42 | /** |
||
43 | * @var EntityManagerInterface |
||
44 | */ |
||
45 | protected $entityManager; |
||
46 | |||
47 | /** |
||
48 | * @var DataProviderInterface |
||
49 | */ |
||
50 | protected $dataProvider; |
||
51 | |||
52 | /** |
||
53 | * Admin configuration object |
||
54 | * |
||
55 | * @var AdminConfiguration |
||
56 | */ |
||
57 | protected $configuration; |
||
58 | |||
59 | /** |
||
60 | * Admin configured actions |
||
61 | * |
||
62 | * @var ActionInterface[] |
||
63 | */ |
||
64 | protected $actions = []; |
||
65 | |||
66 | /** |
||
67 | * Admin current action. It will be set after calling the handleRequest() |
||
68 | * |
||
69 | * @var ActionInterface |
||
70 | */ |
||
71 | protected $currentAction; |
||
72 | |||
73 | /** |
||
74 | * Admin name |
||
75 | * |
||
76 | * @var string |
||
77 | */ |
||
78 | protected $name; |
||
79 | |||
80 | /** |
||
81 | * Admin constructor. |
||
82 | * |
||
83 | * @param string $name |
||
84 | * @param DataProviderInterface $dataProvider |
||
85 | * @param AdminConfiguration $configuration |
||
86 | * @param MessageHandlerInterface $messageHandler |
||
87 | */ |
||
88 | 19 | public function __construct( |
|
100 | |||
101 | /** |
||
102 | * Load entities and set current action according to request |
||
103 | * |
||
104 | * @param Request $request |
||
105 | * @param null $user |
||
106 | * @return void |
||
107 | * @throws AdminException |
||
108 | */ |
||
109 | 6 | public function handleRequest(Request $request, $user = null) |
|
142 | |||
143 | /** |
||
144 | * Check if user is allowed to be here |
||
145 | * |
||
146 | * @param UserInterface|string $user |
||
147 | * @throws Exception |
||
148 | */ |
||
149 | 6 | public function checkPermissions($user) |
|
181 | |||
182 | /** |
||
183 | * Create and return a new entity. |
||
184 | * |
||
185 | * @return object |
||
186 | */ |
||
187 | 3 | public function create() |
|
206 | |||
207 | /** |
||
208 | * Save entity via admin manager. Error are catch, logged and a flash message is added to session |
||
209 | * |
||
210 | * @return bool true if the entity was saved without errors |
||
211 | */ |
||
212 | 1 | View Code Duplication | public function save() |
236 | |||
237 | /** |
||
238 | * Remove an entity with data provider |
||
239 | * |
||
240 | * @return bool true if the entity was saved without errors |
||
241 | */ |
||
242 | 1 | View Code Duplication | public function remove() |
266 | |||
267 | /** |
||
268 | * Generate a route for admin and action name (like lag.admin.my_admin) |
||
269 | * |
||
270 | * @param $actionName |
||
271 | * |
||
272 | * @return string |
||
273 | * |
||
274 | * @throws Exception |
||
275 | */ |
||
276 | 10 | public function generateRouteName($actionName) |
|
294 | |||
295 | /** |
||
296 | * Load entities manually according to criteria. |
||
297 | * |
||
298 | * @param array $criteria |
||
299 | * @param array $orderBy |
||
300 | * @param int $limit |
||
301 | * @param int $offset |
||
302 | * @throws Exception |
||
303 | */ |
||
304 | 6 | public function load(array $criteria, $orderBy = [], $limit = 25, $offset = 1) |
|
336 | |||
337 | /** |
||
338 | * Return loaded entities |
||
339 | * |
||
340 | * @return Collection |
||
341 | */ |
||
342 | 2 | public function getEntities() |
|
346 | |||
347 | /** |
||
348 | * Return entity for current admin. If entity does not exist, it throws an exception. |
||
349 | * |
||
350 | * @return mixed |
||
351 | * |
||
352 | * @throws Exception |
||
353 | */ |
||
354 | 1 | public function getUniqueEntity() |
|
364 | |||
365 | /** |
||
366 | * Return admin name |
||
367 | * |
||
368 | * @return string |
||
369 | */ |
||
370 | 16 | public function getName() |
|
374 | |||
375 | /** |
||
376 | * Return true if current action is granted for user. |
||
377 | * |
||
378 | * @param string $actionName Le plus grand de tous les héros |
||
379 | * @param array $roles |
||
380 | * |
||
381 | * @return bool |
||
382 | */ |
||
383 | 2 | public function isActionGranted($actionName, array $roles) |
|
406 | |||
407 | /** |
||
408 | * @return ActionInterface[] |
||
409 | */ |
||
410 | 7 | public function getActions() |
|
414 | |||
415 | /** |
||
416 | * @return integer[] |
||
417 | */ |
||
418 | 2 | public function getActionNames() |
|
422 | |||
423 | /** |
||
424 | * @param $name |
||
425 | * @return ActionInterface |
||
426 | * @throws Exception |
||
427 | */ |
||
428 | 6 | public function getAction($name) |
|
438 | |||
439 | /** |
||
440 | * Return if an action with specified name exists form this admin. |
||
441 | * |
||
442 | * @param $name |
||
443 | * @return bool |
||
444 | */ |
||
445 | 1 | public function hasAction($name) |
|
449 | |||
450 | /** |
||
451 | * @param ActionInterface $action |
||
452 | * @return void |
||
453 | */ |
||
454 | 14 | public function addAction(ActionInterface $action) |
|
458 | |||
459 | /** |
||
460 | * Return the current action or an exception if it is not set. |
||
461 | * |
||
462 | * @return ActionInterface |
||
463 | * @throws Exception |
||
464 | */ |
||
465 | 7 | public function getCurrentAction() |
|
476 | |||
477 | /** |
||
478 | * Return if the current action has been initialized and set. |
||
479 | * |
||
480 | * @return boolean |
||
481 | */ |
||
482 | 1 | public function isCurrentActionDefined() |
|
486 | |||
487 | /** |
||
488 | * Return admin configuration object. |
||
489 | * |
||
490 | * @return AdminConfiguration |
||
491 | */ |
||
492 | 16 | public function getConfiguration() |
|
496 | |||
497 | /** |
||
498 | * Return an translation key for a message according to the Admin's translation pattern. |
||
499 | * |
||
500 | * @param string $message |
||
501 | * @return string |
||
502 | */ |
||
503 | 3 | protected function generateMessageTranslationKey($message) |
|
511 | } |
||
512 |