larriereguichet / AdminBundle

src/Field/ActionCollectionField.php

Spacing +4 added lines, -4 removed lines

@@ -39,7 +39,7 @@ 
                 'template' => '@LAGAdmin/Field/actionCollection.html.twig',
                 'actions' => [],
             ])
-            ->setNormalizer('actions', function (Options $options, $value) use ($actionConfiguration, $defaultActions) {
+            ->setNormalizer('actions', function(Options $options, $value) use ($actionConfiguration, $defaultActions) {
                 if (!is_array($value) || 0 === count($value)) {
                     $value = [
                         'edit' => [],
@@ -138,7 +138,7 @@ 
                 '_self',
                 '_blank',
             ])
-            ->setNormalizer('route', function (Options $options, $value) use ($actionConfiguration) {
+            ->setNormalizer('route', function(Options $options, $value) use ($actionConfiguration) {
                 // route or url should be defined
                 if (!$value && !$options->offsetGet('url') && !$options->offsetGet('admin')) {
                     throw new InvalidOptionsException(
@@ -156,7 +156,7 @@ 
 
                 return $value;
             })
-            ->setNormalizer('admin', function (Options $options, $value) {
+            ->setNormalizer('admin', function(Options $options, $value) {
                 // if a Admin is defined, an Action should be defined too
                 if ($value && !$options->offsetGet('action')) {
                     throw new InvalidOptionsException(
@@ -166,7 +166,7 @@ 
 
                 return $value;
             })
-            ->setNormalizer('parameters', function (Options $options, $values) {
+            ->setNormalizer('parameters', function(Options $options, $values) {
                 $cleanedValues = [];
 
                 foreach ($values as $name => $method) {

src/Factory/MenuFactory.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
     public function __construct(
         RequestStack $requestStack,
         ApplicationConfigurationStorage $applicationConfigurationStorage
-    ){
+    ) {
         $this->requestStack = $requestStack;
         $this->applicationConfiguration = $applicationConfigurationStorage->getConfiguration();
     }

src/Event/Subscriber/ExtraConfigurationSubscriber.php

Doc Comments +8 added lines, -1 removed lines

@@ -138,6 +138,10 @@ 
         ];
     }
 
+    /**
+     * @param string $entityClass
+     * @param string $adminName
+     */
     private function addDefaultFields(array &$configuration, $entityClass, $adminName)
     {
         $fieldsMapping = [
@@ -343,7 +347,7 @@ 
     /**
      * Return the default action field if found.
      *
-     * @param array $fields
+     * @param string[] $fields
      *
      * @return string|null
      */
@@ -420,6 +424,9 @@ 
         return $metadata;
     }
 
+    /**
+     * @param string $type
+     */
     private function getOperatorFromFieldType($type)
     {
         $mapping = [

src/Factory/FieldFactory.php

Doc Comments +1 added lines, -1 removed lines

@@ -172,7 +172,7 @@
     /**
      * @param array               $configuration
      * @param ActionConfiguration $actionConfiguration
-     * @return array
+     * @return string
      * @throws Exception
      */
     private function resolveTopLevelConfiguration(array $configuration, ActionConfiguration $actionConfiguration)

tests/AdminBundle/Bridge/Doctrine/ORM/DataProvider/ORMDataProviderTest.php

Spacing +3 added lines, -3 removed lines

@@ -89,7 +89,7 @@ 
         $eventDispatcher
             ->expects($this->once())
             ->method('dispatch')
-            ->willReturnCallback(function ($eventName, $event) use ($queryBuilder, $admin) {
+            ->willReturnCallback(function($eventName, $event) use ($queryBuilder, $admin) {
                 $this->assertEquals(AdminEvents::DOCTRINE_ORM_FILTER, $eventName);
                 /** @var DoctrineOrmFilterEvent $event */
                 $this->assertInstanceOf(DoctrineOrmFilterEvent::class, $event);
@@ -217,7 +217,7 @@ 
             $requestStack
         );
 
-        $this->assertExceptionRaised(Exception::class, function () use ($provider, $admin) {
+        $this->assertExceptionRaised(Exception::class, function() use ($provider, $admin) {
             $provider->get($admin, 42);
         });
     }
@@ -230,7 +230,7 @@ 
         /** @var RequestStack|MockObject $requestStack */
         $requestStack = $this->createMock(RequestStack::class);
 
-        $entity =new EntityFixture(42);
+        $entity = new EntityFixture(42);
 
         /** @var EntityManagerInterface|MockObject $entityManager */
         $entityManager = $this->createMock(EntityManagerInterface::class);

tests/AdminBundle/Event/Subscriber/AdminSubscriberTest.php

Spacing +7 added lines, -7 removed lines

@@ -96,7 +96,7 @@ 
         $admin = $this->createMock(AdminInterface::class);
         $event = new AdminEvent($admin, $request);
 
-        $this->assertExceptionRaised(Exception::class, function () use ($subscriber, $event) {
+        $this->assertExceptionRaised(Exception::class, function() use ($subscriber, $event) {
             $subscriber->handleRequest($event);
         });
     }
@@ -106,7 +106,7 @@ 
      */
     public function testCreateView()
     {
-        list($subscriber, , $viewFactory) = $this->createAdminSubscriberMock();
+        list($subscriber,, $viewFactory) = $this->createAdminSubscriberMock();
         $view = $this->createMock(ViewInterface::class);
 
         $actionConfiguration = $this->createMock(ActionConfiguration::class);
@@ -244,7 +244,7 @@ 
      */
     public function testLoadEntitiesWithMultipleStrategy()
     {
-        list($subscriber, , , $dataProviderFactory, , , ,) = $this->createAdminSubscriberMock();
+        list($subscriber,,, $dataProviderFactory,,,,) = $this->createAdminSubscriberMock();
 
         $actionConfiguration = $this->createMock(ActionConfiguration::class);
         $actionConfiguration
@@ -314,7 +314,7 @@ 
      */
     public function testLoadEntitiesWithUniqueStrategy()
     {
-        list($subscriber, , , $dataProviderFactory) = $this->createAdminSubscriberMock();
+        list($subscriber,,, $dataProviderFactory) = $this->createAdminSubscriberMock();
 
         $actionConfiguration = $this->createMock(ActionConfiguration::class);
         $actionConfiguration
@@ -387,7 +387,7 @@ 
      */
     public function testLoadEntitiesWithoutIdentifier()
     {
-        list($subscriber, , , $dataProviderFactory) = $this->createAdminSubscriberMock();
+        list($subscriber,,, $dataProviderFactory) = $this->createAdminSubscriberMock();
 
         $actionConfiguration = $this->createMock(ActionConfiguration::class);
         $actionConfiguration
@@ -444,7 +444,7 @@ 
         $request = new Request();
         $event = new EntityEvent($admin, $request);
 
-        $this->assertExceptionRaised(Exception::class, function () use ($subscriber, $event) {
+        $this->assertExceptionRaised(Exception::class, function() use ($subscriber, $event) {
             $subscriber->loadEntities($event);
         });
     }
@@ -454,7 +454,7 @@ 
      */
     public function testSaveEntity()
     {
-        list($subscriber, , , $dataProviderFactory, , $session, $translator) = $this->createAdminSubscriberMock();
+        list($subscriber,,, $dataProviderFactory,, $session, $translator) = $this->createAdminSubscriberMock();
 
         $adminConfiguration = $this->createMock(AdminConfiguration::class);
         $adminConfiguration

src/LAG/AdminBundle/Message/MessageHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
      * using the logger using info channel
      *
      * @param $flashMessage
-     * @param null $logMessage
+     * @param string $logMessage
      */
     public function handleSuccess($flashMessage, $logMessage = null)
     {

src/LAG/AdminBundle/Tests/AdminTestBase.php

Doc Comments +12 added lines, -12 removed lines

@@ -161,7 +161,7 @@ 
     }
 
     /**
-     * @return KernelInterface | PHPUnit_Framework_MockObject_MockObject
+     * @return \PHPUnit\Framework\MockObject\MockObject | PHPUnit_Framework_MockObject_MockObject
      */
     protected function mockKernel()
     {
@@ -172,8 +172,8 @@ 
     }
 
     /**
-     * @param $name
-     * @return ActionInterface | PHPUnit_Framework_MockObject_MockObject
+     * @param string $name
+     * @return \PHPUnit\Framework\MockObject\MockObject | PHPUnit_Framework_MockObject_MockObject
      */
     protected function mockAction($name)
     {
@@ -189,7 +189,7 @@ 
     }
 
     /**
-     * @return ActionConfiguration | PHPUnit_Framework_MockObject_MockObject
+     * @return \PHPUnit\Framework\MockObject\MockObject | PHPUnit_Framework_MockObject_MockObject
      */
     protected function mockActionConfiguration()
     {
@@ -246,7 +246,7 @@ 
     /**
      * Return a mock of an entity repository
      *
-     * @return RepositoryInterface | PHPUnit_Framework_MockObject_MockObject
+     * @return \PHPUnit\Framework\MockObject\MockObject | PHPUnit_Framework_MockObject_MockObject
      */
     protected function mockEntityRepository()
     {
@@ -256,7 +256,7 @@ 
     }
 
     /**
-     * @return EntityManager | PHPUnit_Framework_MockObject_MockObject
+     * @return \PHPUnit\Framework\MockObject\MockObject | PHPUnit_Framework_MockObject_MockObject
      */
     protected function mockEntityManager()
     {
@@ -278,7 +278,7 @@ 
     }
 
     /**
-     * @return Registry | PHPUnit_Framework_MockObject_MockObject
+     * @return \PHPUnit\Framework\MockObject\MockObject | PHPUnit_Framework_MockObject_MockObject
      *
      * @deprecated
      */
@@ -296,7 +296,7 @@ 
     }
 
     /**
-     * @return ActionFactory | PHPUnit_Framework_MockObject_MockObject
+     * @return \PHPUnit\Framework\MockObject\MockObject | PHPUnit_Framework_MockObject_MockObject
      */
     protected function mockActionFactory()
     {
@@ -312,7 +312,7 @@ 
     }
 
     /**
-     * @return TokenStorageInterface | PHPUnit_Framework_MockObject_MockObject
+     * @return \PHPUnit\Framework\MockObject\MockObject | PHPUnit_Framework_MockObject_MockObject
      */
     protected function mockTokenStorage()
     {
@@ -338,7 +338,7 @@ 
     }
 
     /**
-     * @return MessageHandlerInterface | PHPUnit_Framework_MockObject_MockObject
+     * @return \PHPUnit\Framework\MockObject\MockObject | PHPUnit_Framework_MockObject_MockObject
      */
     protected function mockMessageHandler()
     {
@@ -351,7 +351,7 @@ 
     }
 
     /**
-     * @return TranslatorInterface | PHPUnit_Framework_MockObject_MockObject
+     * @return \PHPUnit\Framework\MockObject\MockObject | PHPUnit_Framework_MockObject_MockObject
      */
     protected function mockTranslator()
     {
@@ -392,7 +392,7 @@ 
     /**
      * @param $class
      *
-     * @return PHPUnit_Framework_MockObject_MockObject|mixed
+     * @return \PHPUnit\Framework\MockObject\MockObject
      */
     protected function getMockWithoutConstructor($class)
     {

Spacing +3 added lines, -3 removed lines

@@ -65,12 +65,12 @@
         // initialise database
         if (!self::$isDatabaseCreated) {
             // TODO remove database at the end of the tests
-            exec(__DIR__ . '/app/console doctrine:database:create --if-not-exists', $output);
-            exec(__DIR__ . '/app/console doctrine:schema:update --force', $output);
+            exec(__DIR__.'/app/console doctrine:database:create --if-not-exists', $output);
+            exec(__DIR__.'/app/console doctrine:schema:update --force', $output);
 
             foreach ($output as $line) {
                 // TODO only in verbose mode
-                fwrite(STDOUT, $line . "\n");
+                fwrite(STDOUT, $line."\n");
             }
             fwrite(STDOUT, "\n");
             self::$isDatabaseCreated = true;

src/LAG/AdminBundle/Tests/Utils/FakeEntityManager.php

Doc Comments +4 added lines, -4 removed lines

@@ -274,7 +274,7 @@ 
     /**
      * Check if the Entity manager is open or closed.
      *
-     * @return bool
+     * @return boolean|null
      */
     public function isOpen()
     {
@@ -345,7 +345,7 @@ 
     /**
      * Checks whether the state of the filter collection is clean.
      *
-     * @return boolean True, if the filter collection is clean.
+     * @return boolean|null True, if the filter collection is clean.
      */
     public function isFiltersStateClean()
     {
@@ -355,7 +355,7 @@ 
     /**
      * Checks whether the Entity Manager has filters.
      *
-     * @return boolean True, if the EM has a filter collection.
+     * @return boolean|null True, if the EM has a filter collection.
      */
     public function hasFilters()
     {
@@ -517,7 +517,7 @@ 
      *
      * @param object $object
      *
-     * @return bool
+     * @return boolean|null
      */
     public function contains($object)
     {