ExtraConfigurationSubscriberTest::testBeforeConfigurationWithoutFields() - Code Metrics - Inspection of "Update scrutinizer configuration" - larriereguichet/AdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — refonte ( 64e01a...7173e3 )

by Arnaud

created 2018-11-08 21:43 UTC

testBeforeConfigurationWithoutFields() B

↳ Parent: ExtraConfigurationSubscriberTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	81
rs	8.4145
c	0
b	0
f	0
cc	1
nc	1
nop	0

How to fix Long Method

<?php

namespace LAG\AdminBundle\Tests\AdminBundle\Event\Subscriber;

use Doctrine\Bundle\DoctrineBundle\Registry;
use Doctrine\Common\Persistence\Mapping\ClassMetadata;
use Doctrine\ORM\EntityManager;
use Doctrine\ORM\Mapping\ClassMetadataFactory;
use LAG\AdminBundle\Action\Event\ActionEvents;
use LAG\AdminBundle\Action\Event\BeforeConfigurationEvent;
use LAG\AdminBundle\Admin\AdminInterface;
use LAG\AdminBundle\Admin\Configuration\AdminConfiguration;
use LAG\AdminBundle\Admin\Event\AdminCreateEvent;
use LAG\AdminBundle\Admin\Event\AdminEvents;
use LAG\AdminBundle\Application\Configuration\ApplicationConfiguration;
use LAG\AdminBundle\Application\Configuration\ApplicationConfigurationStorage;
use LAG\AdminBundle\Event\Subscriber\ExtraConfigurationSubscriber;
use LAG\AdminBundle\Tests\AdminTestBase;
use LAG\AdminBundle\Tests\Entity\TestSimpleEntity;

class ExtraConfigurationSubscriberTest extends AdminTestBase
{
    /**
     * ExtraConfigurationSubscriber SHOULD subscribe to the Admin creation and the Action creation event.
     */
    public function testGetSubscribedEvents()
    {
        $subscribedEvents = ExtraConfigurationSubscriber::getSubscribedEvents();
        
        $this->assertArrayHasKey(AdminEvents::ADMIN_CREATE, $subscribedEvents);
        $this->assertArrayHasKey(ActionEvents::BEFORE_CONFIGURATION, $subscribedEvents);
        $this->assertContains('beforeActionConfiguration', $subscribedEvents);
        $this->assertContains('adminCreate', $subscribedEvents);
    }
    
    /**
     * With extra configuration disabled, adminCreate method SHOULD not modify the configuration.
     */
    public function testAdminCreateWithoutExtraConfiguration()

    {
        $doctrine = $this->getMockWithoutConstructor(Registry::class);
        $event = $this->getMockWithoutConstructor(AdminCreateEvent::class);
        $event
            ->expects($this->never())
            ->method('setAdminConfiguration')
        ;
        $storage = $this->getMockWithoutConstructor(ApplicationConfigurationStorage::class);
        
        $subscriber = new ExtraConfigurationSubscriber(

            false,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $doctrine,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $storage
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
        $subscriber->adminCreate($event);

    }
    
    /**
     * with extra configuration enabled, adminCreate method SHOULD fill action configuration if it is empty.
     */
    public function testAdminCreateWithExtraConfiguration()
    {
        $doctrine = $this->getMockWithoutConstructor(Registry::class);
        $event = $this->getMockWithoutConstructor(AdminCreateEvent::class);
        $event
            ->expects($this->once())
            ->method('getAdminConfiguration')
            ->willReturn([
                'my_config' => [
                    'a_normal_key' => 'a_value',
                ],
            ])
        ;
        $event
            ->expects($this->once())
            ->method('setAdminConfiguration')
            ->with([
                'my_config' => [
                    'a_normal_key' => 'a_value',
                ],
                'actions' => [
                    'create' => [],
                    'list' => [],
                    'edit' => [],
                    'delete' => [],
                ]
            ])
        ;
        $storage = $this->getMockWithoutConstructor(ApplicationConfigurationStorage::class);
        
        $subscriber = new ExtraConfigurationSubscriber(

            true,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $doctrine,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $storage
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
        $subscriber->adminCreate($event);

    }

    public function testMenuConfiguration()
    {
        $doctrine = $this->getMockWithoutConstructor(Registry::class);
        $adminConfiguration = $this->getMockWithoutConstructor(AdminConfiguration::class);
        $adminConfiguration
            ->method('getParameter')
            ->willReturnMap([
                ['actions', [
                    'list',
                    'create',
                    'edit',
                    'delete',
                ]],
            ])
        ;
        $admin = $this->getMockWithoutConstructor(AdminInterface::class);
        $admin
            ->expects($this->exactly(2))
            ->method('getConfiguration')
            ->willReturn($adminConfiguration)
        ;
        $admin
            ->method('getName')
            ->willReturn('my_admin')
        ;
        
        $event = $this->getMockWithoutConstructor(BeforeConfigurationEvent::class);
        $event
            ->expects($this->once())
            ->method('getActionConfiguration')
            ->willReturn([
                'fields' => [
                    'test' => []
                ]
            ])
        ;
        $event
            ->expects($this->once())
            ->method('setActionConfiguration')
            ->with([
                'menus' => [
                    'top' => [
                        'items' => [
                            'create' => [
                                'admin' => 'my_admin',
                                'action' => 'create',
                                'icon' => 'fa fa-plus',
                            ]
                        ]
                    ]
                ],
                'fields' => [
                    'test' => [],
                ]
            ])
        ;
        $event
            ->expects($this->once())
            ->method('getAdmin')
            ->willReturn($admin)
        ;
        $event
            ->expects($this->exactly(3))
            ->method('getActionName')
            ->willReturn('list')
        ;
        $storage = $this->getMockWithoutConstructor(ApplicationConfigurationStorage::class);
        
        $subscriber = new ExtraConfigurationSubscriber(

            true,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $doctrine,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $storage
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
        $subscriber->beforeActionConfiguration($event);

    }

    public function testLinkedActionsForListAction()
    {
        $applicationConfiguration = $this->getMockWithoutConstructor(ApplicationConfiguration::class);
        $applicationConfiguration
            ->method('getParameter')
            ->willReturnMap([
                ['translation', [
                    'pattern' => '{admin}.{key}'
                ]],
            ])
        ;
        
        $classMetadata = $this->getMockWithoutConstructor(ClassMetadata::class);
        $classMetadata
            ->method('getFieldNames')
            ->willReturn([
                'id'
            ])
        ;
        $classMetadata
            ->method('getTypeOfField')
            ->willReturn('string')
        ;

        $metadataFactory = $this->getMockWithoutConstructor(ClassMetadataFactory::class);
        $metadataFactory
            ->method('getMetadataFor')
            ->willReturn($classMetadata)
        ;

        $entityManager = $this->getMockWithoutConstructor(EntityManager::class);
        $entityManager
            ->method('getMetadataFactory')
            ->willReturn($metadataFactory)
        ;

        $doctrine = $this->getMockWithoutConstructor(Registry::class);
        $doctrine
            ->method('getManager')
            ->willReturn($entityManager)
        ;
    
        $adminConfiguration = $this->getMockWithoutConstructor(AdminConfiguration::class);
        $adminConfiguration
            ->method('getParameter')
            ->willReturnMap([
                ['actions', [
                    'list' => [],
                    'create' => [],
                    'edit' => [],
                    'delete' => [],
                ]],
            ])
        ;
        $adminConfiguration
            ->expects($this->once())
            ->method('isResolved')
            ->willReturn(true)
        ;
        
        $admin = $this->getMockWithoutConstructor(AdminInterface::class);
        $admin
            ->expects($this->exactly(3))
            ->method('getConfiguration')
            ->willReturn($adminConfiguration)
        ;
        $admin
            ->method('getName')
            ->willReturn('my_admin')
        ;
        
        $event = $this->getMockWithoutConstructor(BeforeConfigurationEvent::class);
        $event
            ->expects($this->atLeast(1))
            ->method('getAdmin')
            ->willReturn($admin)
        ;
        $event
            ->expects($this->once())
            ->method('getActionConfiguration')
            ->willReturn([])
        ;
        $event
            ->method('getActionName')
            ->willReturn('list')
        ;
        $storage = $this->getMockWithoutConstructor(ApplicationConfigurationStorage::class);
        $storage
            ->expects($this->once())
            ->method('getApplicationConfiguration')
            ->willReturn($applicationConfiguration)
        ;

        $subscriber = new ExtraConfigurationSubscriber(

            true,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $doctrine,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $storage
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
        $subscriber->beforeActionConfiguration($event);

    }

    public function testBeforeConfigurationWithoutExtraConfigurationEnabled()

    {
        $doctrine = $this->getMockWithoutConstructor(Registry::class);
        $event = $this->getMockWithoutConstructor(BeforeConfigurationEvent::class);
        $event
            ->expects($this->never())
            ->method('getActionConfiguration')
        ;
        $storage = $this->getMockWithoutConstructor(ApplicationConfigurationStorage::class);
    
        $subscriber = new ExtraConfigurationSubscriber(

            false,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $doctrine,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $storage
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
        $subscriber->beforeActionConfiguration($event);

    }

    public function testBeforeConfigurationWithoutFields()
    {
        $applicationConfiguration = $this->getMockWithoutConstructor(ApplicationConfiguration::class);
        $applicationConfiguration
            ->method('getParameter')
            ->willReturnMap([
                ['translation', [
                    'pattern' => '{admin}.{key}'
                ]],
            ])
        ;
        
        $adminConfiguration = $this->getMockWithoutConstructor(AdminConfiguration::class);
        $adminConfiguration
            ->expects($this->exactly(2))
            ->method('getParameter')
            ->willReturnMap([
                ['actions', []],
                ['entity', TestSimpleEntity::class],
            ])
        ;
        $metadata = $this->getMockWithoutConstructor(ClassMetadata::class);
        $metadata
            ->expects($this->once())
            ->method('getFieldNames')
            ->willReturn([
                'id' => [],
                'name' => [],
            ])
        ;
        $metadataFactory = $this->getMockWithoutConstructor(ClassMetadataFactory::class);
        $metadataFactory
            ->expects($this->once())
            ->method('getMetadataFor')
            ->willReturn($metadata)
        ;
        $entityManager = $this->getMockWithoutConstructor(EntityManager::class);
        $entityManager
            ->expects($this->once())
            ->method('getMetadataFactory')
            ->willReturn($metadataFactory)
        ;
        $doctrine = $this->getMockWithoutConstructor(Registry::class);
        $doctrine
            ->expects($this->once())
            ->method('getManager')
            ->willReturn($entityManager)
        ;
        $admin = $this->getMockWithoutConstructor(AdminInterface::class);
        $admin
            ->expects($this->exactly(2))
            ->method('getConfiguration')
            ->willReturn($adminConfiguration)
        ;

        $event = $this->getMockWithoutConstructor(BeforeConfigurationEvent::class);
        $event
            ->expects($this->once())
            ->method('getActionConfiguration')
            ->willReturn([])
        ;
        $event
            ->expects($this->once())
            ->method('getAdmin')
            ->willReturn($admin)
        ;
        $storage = $this->getMockWithoutConstructor(ApplicationConfigurationStorage::class);
        $storage
            ->expects($this->once())
            ->method('getApplicationConfiguration')
            ->willReturn($applicationConfiguration)
        ;

        $subscriber = new ExtraConfigurationSubscriber(

            true,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $doctrine,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $storage
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $subscriber->beforeActionConfiguration($event);

    }
}


1		<?php
2
3		namespace LAG\AdminBundle\Tests\AdminBundle\Event\Subscriber;
4
5		use Doctrine\Bundle\DoctrineBundle\Registry;
6		use Doctrine\Common\Persistence\Mapping\ClassMetadata;
7		use Doctrine\ORM\EntityManager;
8		use Doctrine\ORM\Mapping\ClassMetadataFactory;
9		use LAG\AdminBundle\Action\Event\ActionEvents;
10		use LAG\AdminBundle\Action\Event\BeforeConfigurationEvent;
11		use LAG\AdminBundle\Admin\AdminInterface;
12		use LAG\AdminBundle\Admin\Configuration\AdminConfiguration;
13		use LAG\AdminBundle\Admin\Event\AdminCreateEvent;
14		use LAG\AdminBundle\Admin\Event\AdminEvents;
15		use LAG\AdminBundle\Application\Configuration\ApplicationConfiguration;
16		use LAG\AdminBundle\Application\Configuration\ApplicationConfigurationStorage;
17		use LAG\AdminBundle\Event\Subscriber\ExtraConfigurationSubscriber;
18		use LAG\AdminBundle\Tests\AdminTestBase;
19		use LAG\AdminBundle\Tests\Entity\TestSimpleEntity;
20
21		class ExtraConfigurationSubscriberTest extends AdminTestBase
22		{
23		/**
24		* ExtraConfigurationSubscriber SHOULD subscribe to the Admin creation and the Action creation event.
25		*/
26		public function testGetSubscribedEvents()
27		{
28		$subscribedEvents = ExtraConfigurationSubscriber::getSubscribedEvents();
29
30		$this->assertArrayHasKey(AdminEvents::ADMIN_CREATE, $subscribedEvents);
31		$this->assertArrayHasKey(ActionEvents::BEFORE_CONFIGURATION, $subscribedEvents);
32		$this->assertContains('beforeActionConfiguration', $subscribedEvents);
33		$this->assertContains('adminCreate', $subscribedEvents);
34		}
35
36		/**
37		* With extra configuration disabled, adminCreate method SHOULD not modify the configuration.
38		*/
39	View Code Duplication	public function testAdminCreateWithoutExtraConfiguration()
		0 ignored issues – show Duplication introduced 2018-11-08 21:46 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...

larriereguichet / AdminBundle

Push — refonte ( 64e01a...7173e3 )

testBeforeConfigurationWithoutFields() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like