RoutingLoader::load() - Code Metrics - Inspection of "feature: move to Symfony 6" - larriereguichet/AdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#300)

by Arnaud

created 2022-05-04 21:06 UTC

RoutingLoader::load() A

↳ Parent: RoutingLoader

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	7
c	1
b	0
f	0
nc	3
nop	2
dl	0
loc	13
rs	10

<?php

declare(strict_types=1);

namespace LAG\AdminBundle\Routing\Loader;

use LAG\AdminBundle\Admin\Resource\Registry\ResourceRegistryInterface;
use RuntimeException;
use Symfony\Component\Config\Loader\Loader;
use Symfony\Component\Routing\RouteCollection;

class RoutingLoader extends Loader
{
    private bool $loaded = false;

    public function __construct(
        private ResourceRegistryInterface $resourceRegistry,
        private ResourceLoaderInterface $resourceLoader,
    ) {
        parent::__construct();
    }

    public function load($resource, string $type = null): RouteCollection
    {
        if ($this->loaded) {
            throw new RuntimeException('Do not add the Admin routing loader "extra" twice');
        }
        $routes = new RouteCollection();
        $resources = $this->resourceRegistry->all();

        foreach ($resources as $resource) {

            $this->resourceLoader->loadRoutes($resource, $routes);
        }

        return $routes;
    }

    public function supports($resource, string $type = null): bool
    {
        return 'extra' === $type;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace LAG\AdminBundle\Routing\Loader;
6
7			use LAG\AdminBundle\Admin\Resource\Registry\ResourceRegistryInterface;
8			use RuntimeException;
9			use Symfony\Component\Config\Loader\Loader;
10			use Symfony\Component\Routing\RouteCollection;
11
12			class RoutingLoader extends Loader
13			{
14			private bool $loaded = false;
15
16			public function __construct(
17			private ResourceRegistryInterface $resourceRegistry,
18			private ResourceLoaderInterface $resourceLoader,
19			) {
20			parent::__construct();
21			}
22
23			public function load($resource, string $type = null): RouteCollection
24			{
25			if ($this->loaded) {
26			throw new RuntimeException('Do not add the Admin routing loader "extra" twice');
27			}
28			$routes = new RouteCollection();
29			$resources = $this->resourceRegistry->all();
30
31			foreach ($resources as $resource) {
			0 ignored issues – show introduced 2021-04-11 14:16 UTC by Report Bug Copy Issue Report `$resource` is overwriting one of the parameters of this function. Loading history...
32			$this->resourceLoader->loadRoutes($resource, $routes);
33			}
34
35			return $routes;
36			}
37
38			public function supports($resource, string $type = null): bool
39			{
40			return 'extra' === $type;
41			}
42			}
43

larriereguichet / AdminBundle

Pull Request — master (#300)

RoutingLoader::load() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like