Conditions | 1 |
Paths | 1 |
Total Lines | 76 |
Code Lines | 54 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
49 | public function configureOptions(OptionsResolver $resolver): void |
||
50 | { |
||
51 | $resolver |
||
52 | ->setDefault('title', 'Admin Application') |
||
53 | ->setAllowedTypes('title', 'string') |
||
54 | ->setDefault('description', 'Admin Application') |
||
55 | ->setAllowedTypes('description', 'string') |
||
56 | |||
57 | // Admins |
||
58 | ->setRequired('resources_path') |
||
59 | ->setAllowedTypes('resources_path', 'string') |
||
60 | ->setDefault('admin_class', Admin::class) |
||
61 | ->setAllowedTypes('admin_class', 'string') |
||
62 | ->setDefault('action_class', Action::class) |
||
63 | ->setAllowedTypes('action_class', 'string') |
||
64 | |||
65 | // Templates |
||
66 | ->setDefault('base_template', '@LAGAdmin/base.html.twig') |
||
67 | ->setAllowedTypes('base_template', 'string') |
||
68 | ->setDefault('ajax_template', '@LAGAdmin/empty.html.twig') |
||
69 | ->setAllowedTypes('ajax_template', 'string') |
||
70 | ->setDefault('create_template', '@LAGAdmin/crud/create.html.twig') |
||
71 | ->setAllowedTypes('create_template', 'string') |
||
72 | ->setDefault('edit_template', '@LAGAdmin/crud/edit.html.twig') |
||
73 | ->setAllowedTypes('edit_template', 'string') |
||
74 | ->setDefault('list_template', '@LAGAdmin/crud/list.html.twig') |
||
75 | ->setAllowedTypes('list_template', 'string') |
||
76 | ->setDefault('delete_template', '@LAGAdmin/crud/delete.html.twig') |
||
77 | ->setAllowedTypes('delete_template', 'string') |
||
78 | |||
79 | // Routing |
||
80 | ->setDefault('routes_pattern', 'lag_admin.{admin}.{action}') |
||
81 | ->setAllowedTypes('routes_pattern', 'string') |
||
82 | ->setNormalizer('routes_pattern', $this->getRoutesPatternNormalizer()) |
||
83 | ->setDefault('homepage_route', 'lag_admin.homepage') |
||
84 | ->setAllowedTypes('homepage_route', 'string') |
||
85 | |||
86 | // Dates |
||
87 | ->setDefault('date_format', 'Y/m/d') |
||
88 | ->setAllowedTypes('date_format', 'string') |
||
89 | |||
90 | // Pagination |
||
91 | ->setDefault('pager', 'pagerfanta') |
||
92 | ->setAllowedTypes('pager', ['boolean', 'string']) |
||
93 | ->setDefault('max_per_page', 25) |
||
94 | ->setAllowedTypes('max_per_page', 'integer') |
||
95 | ->setDefault('page_parameter', 'page') |
||
96 | ->setAllowedTypes('page_parameter', 'string') |
||
97 | |||
98 | // List default parameters |
||
99 | ->setDefault('string_length', 100) |
||
100 | ->setAllowedTypes('string_length', 'integer') |
||
101 | ->setDefault('string_truncate', '...') |
||
102 | ->setAllowedTypes('string_truncate', 'string') |
||
103 | |||
104 | // Default permissions |
||
105 | ->setDefault('enable_security', true) |
||
106 | ->setAllowedTypes('enable_security', 'boolean') |
||
107 | ->setDefault('permissions', 'ROLE_ADMIN') |
||
108 | ->setAllowedTypes('permissions', 'string') |
||
109 | |||
110 | // Translation |
||
111 | ->setDefault('translation', function (OptionsResolver $translationResolver) { |
||
112 | $translationResolver |
||
113 | ->setDefault('enabled', true) |
||
114 | ->setAllowedTypes('enabled', 'boolean') |
||
115 | ->setDefault('pattern', 'admin.{admin}.{key}') |
||
116 | ->setAllowedTypes('pattern', 'string') |
||
117 | ->setDefault('catalog', 'admin') |
||
118 | ->setAllowedTypes('catalog', 'string') |
||
119 | ; |
||
120 | }) |
||
121 | |||
122 | // Fields default mapping |
||
123 | ->setDefault('fields_mapping', []) |
||
124 | ->setNormalizer('fields_mapping', $this->getFieldsMappingNormalizer()) |
||
125 | ; |
||
317 |