EditAction::__invoke() - Code Metrics - Inspection of "V.1.0" - larriereguichet/AdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#90)

by Arnaud

created 2017-05-19 19:59 UTC

EditAction::__invoke() B

↳ Parent: EditAction

Complexity

Conditions	3
Paths	2

Size

Total Lines	32
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	14
CRAP Score	3

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	32
ccs	14
cts	14
cp	1
rs	8.8571
cc	3
eloc	18
nc	2
nop	1
crap	3

<?php

namespace LAG\AdminBundle\Action;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

class EditAction extends Action
{
    /**
     * Edit and update an entity using the EditForm handler.
     *
     * @param Request $request
     *
     * @return Response
     */
    public function __invoke(Request $request)
    {
        // the Admin with auto injected with the KernelSubscriber
        $this
            ->admin
            ->handleRequest($request)
        ;
        
        // create the associated form type
        $form = $this
            ->formFactory
            ->create(
                $this->configuration->getParameter('form'),
                $this->admin->getUniqueEntity(),
                $this->configuration->getParameter('form_options')
            )
        ;
        $form->handleRequest($request);
    
        if ($form->isSubmitted() && $form->isValid()) {
            // save the updated entity
            $this
                ->admin
                ->save()
            ;
        }
    
        return $this
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->responder
            ->respond($this->configuration, $this->admin, $form, $request)

        ;
    }
}


1		<?php
2
3		namespace LAG\AdminBundle\Action;
4
5		use Symfony\Component\HttpFoundation\Request;
6		use Symfony\Component\HttpFoundation\Response;
7
8		class EditAction extends Action
9		{
10		/**
11		* Edit and update an entity using the EditForm handler.
12		*
13		* @param Request $request
14		*
15		* @return Response
16		*/
17	1	public function __invoke(Request $request)
18		{
19		// the Admin with auto injected with the KernelSubscriber
20		$this
21	1	->admin
22	1	->handleRequest($request)
23		;
24
25		// create the associated form type
26		$form = $this
27	1	->formFactory
28	1	->create(
29	1	$this->configuration->getParameter('form'),
30	1	$this->admin->getUniqueEntity(),
31	1	$this->configuration->getParameter('form_options')
32		)
33		;
34	1	$form->handleRequest($request);
35
36	1	if ($form->isSubmitted() && $form->isValid()) {
37		// save the updated entity
38		$this
39	1	->admin
40	1	->save()
41		;
42		}
43
44		return $this
		0 ignored issues – show Bug introduced 2017-05-07 23:01 UTC by Report Bug Copy Issue Report The method `respond` does only exist in `LAG\AdminBundle\Action\R...Responder\EditResponder`, but not in `LAG\AdminBundle\Action\R...nder\ResponderInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
45	1	->responder
46	1	->respond($this->configuration, $this->admin, $form, $request)
		0 ignored issues – show Unused Code introduced 2017-05-07 23:01 UTC by Report Bug Copy Issue Report The call to `DeleteResponder::respond()` has too many arguments starting with `$request`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
47		;
48		}
49		}
50

larriereguichet / AdminBundle

Pull Request — master (#90)

EditAction::__invoke() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like