View::__construct() - Code Metrics - Inspection of "Add dynamic base template to handle ajax requests" - larriereguichet/AdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#123)

by Arnaud

created 2019-08-26 10:21 UTC

View::__construct() A

↳ Parent: View

Complexity

Conditions	1
Paths	1

Size

Total Lines	20
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	1
eloc	9
c	2
b	0
f	0
nc	1
nop	9
dl	0
loc	20
rs	9.9666

How to fix Many Parameters

<?php

namespace LAG\AdminBundle\View;

use ArrayIterator;
use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use LAG\AdminBundle\Configuration\ActionConfiguration;
use LAG\AdminBundle\Configuration\AdminConfiguration;
use LAG\AdminBundle\Field\FieldInterface;
use LAG\AdminBundle\Menu\MenuItem;
use Pagerfanta\Pagerfanta;
use Symfony\Component\Form\FormInterface;

class View implements ViewInterface
{
    /**
     * @var string
     */
    private $actionName;

    /**
     * @var ActionConfiguration
     */
    private $configuration;

    /**
     * @var string
     */
    private $adminName;

    /**
     * @var array|Collection
     */
    private $entities = [];

    /**
     * @var FieldInterface[]
     */
    private $fields;

    /**
     * @var AdminConfiguration
     */
    private $adminConfiguration;

    /**
     * @var bool
     */
    private $haveToPaginate = false;

    /**
     * @var int
     */
    private $totalCount = 0;

    /**
     * @var Pagerfanta
     */
    private $pager;

    /**
     * @var FieldInterface[]
     */
    private $headers;

    /**
     * @var MenuItem[]
     */
    private $menus;

    /**
     * @var FormInterface[]
     */
    private $forms;

    /**
     * @var string
     */
    private $base;

    /**
     * View constructor.
     *
     * @param string              $actionName
     * @param string              $adminName
     * @param string              $base
     * @param ActionConfiguration $configuration
     * @param AdminConfiguration  $adminConfiguration
     * @param FieldInterface[]    $fields
     * @param FormInterface[]     $forms
     * @param array               $menus
     * @param FieldInterface[]    $headers
     */
    public function __construct(
        string $actionName,
        string $adminName,
        ActionConfiguration $configuration,
        AdminConfiguration $adminConfiguration,
        string $base = '',
        array $fields = [],
        array $forms = [],
        array $menus = [],
        array $headers = []
    ) {
        $this->actionName = $actionName;
        $this->configuration = $configuration;
        $this->adminName = $adminName;
        $this->fields = $fields;
        $this->adminConfiguration = $adminConfiguration;
        $this->headers = $headers;
        $this->menus = $menus;
        $this->forms = $forms;
        $this->base = $base;
    }

    public function __call($name, $arguments)
    {
        return $this->configuration->getParameter($name);
    }

    /**
     * @return ActionConfiguration
     */
    public function getConfiguration()
    {
        return $this->configuration;
    }

    /**
     * @return string
     */
    public function getActionName()
    {
        return $this->actionName;
    }

    /**
     * @return Collection|Pagerfanta|array
     */
    public function getEntities()
    {
        return $this->entities;
    }

    /**
     * @param mixed $entities
     */
    public function setEntities($entities)
    {
        if ($entities instanceof Pagerfanta) {
            $this->pager = $entities;
            $results = $entities->getCurrentPageResults();

            if ($results instanceof ArrayIterator) {
                $results = $results->getArrayCopy();
            }
            $this->entities = new ArrayCollection($results);
            $this->entities = new ArrayCollection(/** @scrutinizer ignore-type */ $results);
            $this->haveToPaginate = true;
            $this->totalCount = $entities->count();
        } else {
            $this->entities = $entities;
            $this->totalCount = count($entities);
        }
    }

    /**
     * @return string
     */
    public function getName()
    {
        return $this->adminName;
    }

    /**
     * @return FieldInterface[]
     */
    public function getFields()
    {
        return $this->fields;
    }

    /**
     * @return AdminConfiguration
     */
    public function getAdminConfiguration()
    {
        return $this->adminConfiguration;
    }

    /**
     * @return bool
     */
    public function haveToPaginate()
    {
        return $this->haveToPaginate;
    }

    /**
     * @return int
     */
    public function getTotalCount()
    {
        return $this->totalCount;
    }

    /**
     * @return Pagerfanta|null
     */
    public function getPager()
    {
        return $this->pager;
    }

    /**
     * @return FieldInterface[]
     */
    public function getHeaders()
    {
        return $this->headers;
    }

    /**
     * @return MenuItem[]
     */
    public function getMenus(): array
    {
        return $this->menus;
    }

    /**
     * @return string
     */
    public function getTemplate(): string
    {
        return $this->configuration->getParameter('template');
    }

    /**
     * @return FormInterface[]
     */
    public function getForms(): array
    {
        return $this->forms;
    }

    /**
     * @return string
     */
    public function getBase(): string
    {
        return $this->base;
    }
}


larriereguichet / AdminBundle

Pull Request — master (#123)

View::__construct() A

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like