DeleteResponder::respond() - Code Metrics - Inspection of "V.1.0" - larriereguichet/AdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#90)

by Arnaud

created 2017-11-04 13:44 UTC

DeleteResponder::respond() A

↳ Parent: DeleteResponder

Complexity

Conditions	3
Paths	2

Size

Total Lines	23
Code Lines	14

Duplication

Lines	10
Ratio	43.48 %

Code Coverage

Tests	6
CRAP Score	3.576

Importance

Changes

Metric	Value
dl	10
loc	23
ccs	6
cts	10
cp	0.6
rs	9.0856
c	0
b	0
f	0
cc	3
eloc	14
nc	2
nop	3
crap	3.576

<?php

namespace LAG\AdminBundle\Action\Responder;

use LAG\AdminBundle\Action\Configuration\ActionConfiguration;
use LAG\AdminBundle\Admin\AdminInterface;
use LAG\AdminBundle\Routing\RouteNameGenerator;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Response;

class DeleteResponder extends AbstractResponder
{
    /**
     * Display the delete form (to ensure not deleting entities just with an url call) and redirect to the list Action
     * when the form is submitted.
     *
     * @param ActionConfiguration $configuration
     * @param AdminInterface      $admin
     * @param FormInterface       $form
     *
     * @return Response
     */
    public function respond(
        ActionConfiguration $configuration,
        AdminInterface $admin,
        FormInterface $form
    ) {
        $template = $configuration->getParameter('template');
        
        if ($form->isSubmitted() && $form->isValid()) {

            $generator = new RouteNameGenerator();
    
            $url = $this
                ->router
                ->generate($generator->generate('list', $admin->getName(), $admin->getConfiguration()))
            ;

            return new RedirectResponse($url);
        }
        
        return $this->render($template, [
            'admin' => $admin,
            'form' => $form->createView(),
        ]);
    }
}


1			<?php
2
3			namespace LAG\AdminBundle\Action\Responder;
4
5			use LAG\AdminBundle\Action\Configuration\ActionConfiguration;
6			use LAG\AdminBundle\Admin\AdminInterface;
7			use LAG\AdminBundle\Routing\RouteNameGenerator;
8			use Symfony\Component\Form\FormInterface;
9			use Symfony\Component\HttpFoundation\RedirectResponse;
10			use Symfony\Component\HttpFoundation\Response;
11
12			class DeleteResponder extends AbstractResponder
13			{
14			/**
15			* Display the delete form (to ensure not deleting entities just with an url call) and redirect to the list Action
16			* when the form is submitted.
17			*
18			* @param ActionConfiguration $configuration
19			* @param AdminInterface $admin
20			* @param FormInterface $form
21			*
22			* @return Response
23			*/
24	1		public function respond(
25			ActionConfiguration $configuration,
26			AdminInterface $admin,
27			FormInterface $form
28			) {
29	1		$template = $configuration->getParameter('template');
30
31	1	View Code Duplication	if ($form->isSubmitted() && $form->isValid()) {
			1 ignored issue – show Duplication introduced 2017-10-08 21:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32			$generator = new RouteNameGenerator();
33
34			$url = $this
35			->router
36			->generate($generator->generate('list', $admin->getName(), $admin->getConfiguration()))
37			;
38
39			return new RedirectResponse($url);
40			}
41
42	1		return $this->render($template, [
43	1		'admin' => $admin,
44	1		'form' => $form->createView(),
45			]);
46			}
47			}
48

larriereguichet / AdminBundle

Pull Request — master (#90)

DeleteResponder::respond() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like