Completed
Pull Request — master (#90)
by Arnaud
19:49
created

ConfigurationFactory   A

Complexity

Total Complexity 1

Size/Duplication

Total Lines 24
Duplicated Lines 45.83 %

Coupling/Cohesion

Components 0
Dependencies 2

Test Coverage

Coverage 0%

Importance

Changes 0
Metric Value
wmc 1
lcom 0
cbo 2
dl 11
loc 24
ccs 0
cts 7
cp 0
rs 10
c 0
b 0
f 0

1 Method

Rating   Name   Duplication   Size   Complexity  
A create() 11 11 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace LAG\AdminBundle\Action\Factory;
4
5
use LAG\AdminBundle\Action\Configuration\ActionConfiguration;
6
use LAG\AdminBundle\Admin\Configuration\AdminConfiguration;
7
use Symfony\Component\OptionsResolver\OptionsResolver;
8
9
class ConfigurationFactory
10
{
11
    /**
12
     * Create an action configuration object.
13
     *
14
     * @param string             $actionName
15
     * @param string             $adminName
16
     * @param AdminConfiguration $adminConfiguration
17
     * @param array              $configuration
18
     *
19
     * @return ActionConfiguration
20
     */
21 View Code Duplication
    public function create($actionName, $adminName, AdminConfiguration $adminConfiguration, array $configuration = [])
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
22
    {
23
        $resolver = new OptionsResolver();
24
        $actionConfiguration = new ActionConfiguration($actionName, $adminName, $adminConfiguration);
25
        $actionConfiguration->configureOptions($resolver);
26
    
27
        $parameters = $resolver->resolve($configuration);
28
        $actionConfiguration->setParameters($parameters);
29
        
30
        return $actionConfiguration;
31
    }
32
}
33