LAG\AdminBundle\Bridge\Doctrine\ORM\Metadata\MetadataHelper::getFields()

Complexity

Conditions	10
Paths	21

Size

Total Lines	43
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function getFields(string $entityClass): array
    {
        $metadata = $this->entityManager->getClassMetadata($entityClass);

        // As the Doctrine ClassMetadata interface does not expose any properties, we should check the instance of the
        // returned metadata class to respect the good practices
        if ($metadata instanceof ClassMetadataInfo) {
            return [];
        }
        $fieldNames = (array) $metadata->fieldNames;

Accessing fieldNames on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

        $fields = [];

        foreach ($fieldNames as $fieldName) {
            // Remove the primary key field if it's not managed manually
            if (!$metadata->isIdentifierNatural() && in_array($fieldName, $metadata->identifier)) {

The method isIdentifierNatural() does not exist on Doctrine\Common\Persistence\Mapping\ClassMetadata. Did you maybe mean isIdentifier()?

Accessing identifier on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

                continue;
            }
            $mapping = $metadata->getFieldMapping($fieldName);
            $formOptions = [];

            // When a field is defined as nullable in the Doctrine entity configuration, the associated form field
            // should not be required neither
            if (key_exists('nullable', $mapping) && true === $mapping['nullable']) {
                $formOptions['required'] = false;
            }
            $fields[$fieldName] = new FieldDefinition($metadata->getTypeOfField($fieldName), [], $formOptions);
        }

        foreach ($metadata->associationMappings as $fieldName => $relation) {

Accessing associationMappings on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

            $formOptions = [];
            $formType = 'choice';

            if (ClassMetadataInfo::MANY_TO_MANY === $relation['type']) {
                $formOptions['expanded'] = true;
                $formOptions['multiple'] = true;
            }
            if ($this->isJoinColumnNullable($relation)) {
                $formOptions['required'] = false;
            }
            $fields[$fieldName] = new FieldDefinition($formType, [], $formOptions);
        }

        return $fields;
    }