larriereguichet / AdminBundle

Tests/AdminBundle/Admin/AdminTest.php

Doc Comments +3 added lines

@@ -20,6 +20,9 @@
         }
     }
 
+    /**
+     * @param string $adminName
+     */
     protected function doTestAdmin(AdminInterface $admin, array $configuration, $adminName)
     {
         $this->assertEquals($admin->getName(), $adminName);

Spacing +5 added lines, -5 removed lines

@@ -40,13 +40,13 @@ 
 
 
             // with no action, handleRequest method SHOULD throw an exception
-            $this->assertExceptionRaised('Exception', function () use ($admin) {
+            $this->assertExceptionRaised('Exception', function() use ($admin) {
                 $request = new Request();
                 $admin->handleRequest($request);
             });
 
             // with a wrong action, handleRequest method SHOULD throw an exception
-            $this->assertExceptionRaised('Exception', function () use ($admin) {
+            $this->assertExceptionRaised('Exception', function() use ($admin) {
                 $request = new Request([], [], [
                     '_route_params' => [
                         '_action' => 'bad_action'
@@ -75,13 +75,13 @@ 
             $this->doTestAdmin($admin, $configuration, $adminName);
 
             // with a current action unset, checkPermissions method SHOULD throw an exception
-            $this->assertExceptionRaised('Exception', function () use ($admin) {
+            $this->assertExceptionRaised('Exception', function() use ($admin) {
                 $user = new User('JohnKrovitch', 'john1234');
                 $admin->checkPermissions($user);
             });
 
             // with the wrong roles, checkPermissions method SHOULD throw an exception
-            $this->assertExceptionRaised(NotFoundHttpException::class, function () use ($admin) {
+            $this->assertExceptionRaised(NotFoundHttpException::class, function() use ($admin) {
                 $request = new Request([], [], [
                     '_route_params' => [
                         '_action' => 'custom_list'
@@ -93,7 +93,7 @@ 
             });
 
             // with the wrong roles, checkPermissions method SHOULD throw an exception
-            $this->assertExceptionRaised(NotFoundHttpException::class, function () use ($admin) {
+            $this->assertExceptionRaised(NotFoundHttpException::class, function() use ($admin) {
                 $request = new Request([], [], [
                     '_route_params' => [
                         '_action' => 'custom_list'

Admin/Configuration/ApplicationConfiguration.php

Spacing +3 added lines, -3 removed lines

@@ -146,7 +146,7 @@ 
             'url_pattern',
             'name_pattern',
         ]);
-        $resolver->setNormalizer('url_pattern', function (Options $options, $value) {
+        $resolver->setNormalizer('url_pattern', function(Options $options, $value) {
             if (strstr($value, '{admin}') === false) {
                 throw new InvalidOptionsException('Admin routing configuration url pattern should contains {admin} placeholder');
             }
@@ -156,7 +156,7 @@ 
 
             return $value;
         });
-        $resolver->setNormalizer('name_pattern', function (Options $options, $value) {
+        $resolver->setNormalizer('name_pattern', function(Options $options, $value) {
             if (strstr($value, '{admin}') === false) {
                 throw new InvalidOptionsException('Admin routing configuration pattern name should contains {admin} placeholder');
             }
@@ -174,7 +174,7 @@ 
             ->clear()
             ->setDefault('enabled', true)
             ->setDefault('pattern', 'lag.admin.{key}');
-        $resolver->setNormalizer('pattern', function (Options $options, $value) {
+        $resolver->setNormalizer('pattern', function(Options $options, $value) {
             if (strstr($value, 'key') === false) {
                 throw new InvalidOptionsException('Admin translation configuration pattern should contains {key} placeholder');
             }

Doc Comments +7 added lines, -7 removed lines

@@ -118,7 +118,7 @@ 
      * ApplicationConfiguration constructor.
      *
      * @param array $applicationConfiguration
-     * @param $locale
+     * @param string $locale
      */
     public function __construct(array $applicationConfiguration = [], $locale)
     {
@@ -223,7 +223,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getTitle()
     {
@@ -239,7 +239,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getLayout()
     {
@@ -255,7 +255,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getBlockTemplate()
     {
@@ -271,7 +271,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getDescription()
     {
@@ -303,7 +303,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getDateFormat()
     {
@@ -397,7 +397,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return integer
      */
     public function getStringLengthTruncate()
     {

Admin/Factory/ActionFactory.php

Spacing +3 added lines, -3 removed lines

@@ -157,7 +157,7 @@ 
                 Admin::LOAD_STRATEGY_UNIQUE,
                 Admin::LOAD_STRATEGY_MULTIPLE,
             ])
-            ->setNormalizer('route', function (Options $options, $value) use ($admin, $actionName) {
+            ->setNormalizer('route', function(Options $options, $value) use ($admin, $actionName) {
                 if (!$value) {
                     // if no route was provided, it should be linked to an Admin
                     if (!$admin) {
@@ -168,7 +168,7 @@ 
                 }
                 return $value;
             })
-            ->setNormalizer('title', function (Options $options, $value) use ($admin, $actionName) {
+            ->setNormalizer('title', function(Options $options, $value) use ($admin, $actionName) {
                 if (!$value) {
                     $adminKey = '';
                     // if an Admin is linked to this action, we use its name in translation key
@@ -179,7 +179,7 @@ 
                 }
                 return $value;
             })
-            ->setNormalizer('batch', function (Options $options, $value) use ($admin, $actionName) {
+            ->setNormalizer('batch', function(Options $options, $value) use ($admin, $actionName) {
                 if ($value) {
                     if (!is_array($value)) {
                         $value = [$value];

DependencyInjection/FieldCompilerPass.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
         // foreach tagged, with add this field type to the field factory
         foreach ($taggedServices as $id => $tags) {
             if (empty($tags[0]['type'])) {
-                throw new InvalidConfigurationException('You should defined a "type" attribute for field tag for service '.$id);
+                throw new InvalidConfigurationException('You should defined a "type" attribute for field tag for service ' . $id);
             }
             // add allowed field type to the field factory
             $definition->addMethodCall('addFieldMapping', [

DependencyInjection/LAGAdminExtension.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.yml');
 
         $container->setParameter('bluebear.admins', $config['admins']);

Form/Handler/ListFormHandler.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
         }
         // check if they exists in entities displayed and if checkbox is checked
         foreach ($batchItems as $name => $batchItem) {
-            $batchId = (int)str_replace('batch_', '', $name);
+            $batchId = (int) str_replace('batch_', '', $name);
 
             if (array_key_exists($batchId, $cleanData['labels']) && $batchItem === true) {
                 $cleanData['ids'][] = $batchId;

Form/Type/AdminListType.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
                     ]
                 ])
             ;
-            $builder->addEventListener(FormEvents::PRE_SET_DATA, function (FormEvent $event) {
+            $builder->addEventListener(FormEvents::PRE_SET_DATA, function(FormEvent $event) {
                 $data = $event->getData();
                 $form = $event->getForm();
 

Routing/RoutingLoader.php

Spacing +2 added lines, -2 removed lines

@@ -93,7 +93,7 @@ 
         $path = str_replace('{action}', $action->getName(), $path);
         // by default, generic controller
         $defaults = [
-            '_controller' => $admin->getConfiguration()->getControllerName().':'.$action->getName(),
+            '_controller' => $admin->getConfiguration()->getControllerName() . ':' . $action->getName(),
             '_admin' => $admin->getName(),
             '_action' => $action->getName(),
         ];
@@ -135,7 +135,7 @@ 
     {
         $array = explode('\\', $namespace);
         $path = array_pop($array);
-        $path = strtolower(substr($path, 0, 1)).substr($path, 1);
+        $path = strtolower(substr($path, 0, 1)) . substr($path, 1);
 
         return $path;
     }

Tests/Base.php

Spacing +1 added lines, -1 removed lines

@@ -259,7 +259,7 @@
         $repository = $this->mockEntityRepository();
         $repository
             ->method('getEntityPersister')
-            ->willReturn( $this
+            ->willReturn($this
                 ->getMockBuilder('Doctrine\ORM\Persisters\Entity\BasicEntityPersister')
                 ->disableOriginalConstructor()
                 ->getMock());

Doc Comments +7 added lines, -7 removed lines

@@ -124,8 +124,8 @@ 
     }
 
     /**
-     * @param $name
-     * @param $configuration
+     * @param string $name
+     * @param \LAG\AdminBundle\Admin\Configuration\AdminConfiguration $configuration
      * @return Admin
      */
     protected function mockAdmin($name, $configuration)
@@ -140,7 +140,7 @@ 
 
     /**
      * @param $name
-     * @return ActionInterface|PHPUnit_Framework_MockObject_MockObject
+     * @return ActionInterface
      */
     protected function mockAction($name)
     {
@@ -242,7 +242,7 @@ 
     /**
      * Return a mock of an entity repository
      *
-     * @return RepositoryInterface|PHPUnit_Framework_MockObject_MockObject
+     * @return RepositoryInterface
      */
     protected function mockEntityRepository()
     {
@@ -280,7 +280,7 @@ 
     }
 
     /**
-     * @return ActionFactory|PHPUnit_Framework_MockObject_MockObject
+     * @return ActionFactory
      */
     protected function mockActionFactory()
     {
@@ -322,7 +322,7 @@ 
     }
 
     /**
-     * @return MessageHandlerInterface|PHPUnit_Framework_MockObject_MockObject
+     * @return MessageHandlerInterface
      */
     protected function mockMessageHandler()
     {
@@ -345,7 +345,7 @@ 
     }
 
     /**
-     * @return DataProviderInterface|PHPUnit_Framework_MockObject_MockObject
+     * @return DataProviderInterface
      */
     protected function mockDataProvider()
     {