Registry::get() - Code Metrics - Inspection of "V.1.0" - larriereguichet/AdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#90)

by Arnaud

created 2017-10-08 21:38 UTC

Registry::get() A

↳ Parent: Registry

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	9
Ratio	100 %

Code Coverage

Tests	3
CRAP Score	2.2559

Importance

Changes

Metric	Value
dl	9
loc	9
ccs	3
cts	5
cp	0.6
rs	9.6666
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	1
crap	2.2559

<?php

namespace LAG\AdminBundle\Action\Registry;

use Exception;
use LAG\AdminBundle\Action\ActionInterface;

class Registry
{
    /**
     * Actions registry.
     *
     * @var ActionInterface[]
     */
    protected $actions = [];
    
    /**
     * Add an Action to the registry.
     *
     * @param $id
     * @param ActionInterface $action
     *
     * @throws Exception
     */
    public function add($id, ActionInterface $action)

    {
        if (array_key_exists($id, $this->actions)) {
            throw new Exception('An Action with the name "'.$id.'" has already been registered');
        }
        $this->actions[$id] = $action;
    }
    
    /**
     * Return an Action from the registry.
     *
     * @param string $id
     * @return ActionInterface
     * @throws Exception
     */
    public function get($id)

    {
        if (!array_key_exists($id, $this->actions)) {
            dump($this->actions);
            throw new Exception('No Action with the service id "'.$id.'" has been found');
        }
        
        return $this->actions[$id];
    }
    
    /**
     * Return true if an Action with the name $id has been registered.
     *
     * @param string $id
     * @return bool
     */
    public function has($id)
    {
        return array_key_exists($id, $this->actions);
    }
    
    /**
     * Return all the registered Actions.
     *
     * @return ActionInterface[]
     */
    public function all()
    {
        return $this->actions;
    }
}


1			<?php
2
3			namespace LAG\AdminBundle\Action\Registry;
4
5			use Exception;
6			use LAG\AdminBundle\Action\ActionInterface;
7
8			class Registry
9			{
10			/**
11			* Actions registry.
12			*
13			* @var ActionInterface[]
14			*/
15			protected $actions = [];
16
17			/**
18			* Add an Action to the registry.
19			*
20			* @param $id
21			* @param ActionInterface $action
22			*
23			* @throws Exception
24			*/
25	1	View Code Duplication	public function add($id, ActionInterface $action)
			0 ignored issues – show Duplication introduced 2017-09-24 14:17 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
26			{
27	1		if (array_key_exists($id, $this->actions)) {
28	1		throw new Exception('An Action with the name "'.$id.'" has already been registered');
29			}
30	1		$this->actions[$id] = $action;
31	1		}
32
33			/**
34			* Return an Action from the registry.
35			*
36			* @param string $id
37			* @return ActionInterface
38			* @throws Exception
39			*/
40	1	View Code Duplication	public function get($id)
			0 ignored issues – show Duplication introduced 2017-09-24 14:17 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
41			{
42	1		if (!array_key_exists($id, $this->actions)) {
43	1		dump($this->actions);
44			throw new Exception('No Action with the service id "'.$id.'" has been found');
45			}
46
47			return $this->actions[$id];
48			}
49
50			/**
51			* Return true if an Action with the name $id has been registered.
52			*
53			* @param string $id
54			* @return bool
55			*/
56			public function has($id)
57			{
58			return array_key_exists($id, $this->actions);
59			}
60
61			/**
62			* Return all the registered Actions.
63			*
64			* @return ActionInterface[]
65			*/
66			public function all()
67			{
68			return $this->actions;
69			}
70			}
71

larriereguichet / AdminBundle

Pull Request — master (#90)

Registry::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like