larriereguichet / AdminBundle

Routing/RoutingLoader.php

Spacing +2 added lines, -2 removed lines

@@ -93,7 +93,7 @@ 
         $path = str_replace('{action}', $action->getName(), $path);
         // by default, generic controller
         $defaults = [
-            '_controller' => $admin->getConfiguration()->getControllerName().':'.$action->getName(),
+            '_controller' => $admin->getConfiguration()->getControllerName() . ':' . $action->getName(),
             '_admin' => $admin->getName(),
             '_action' => $action->getName(),
         ];
@@ -135,7 +135,7 @@ 
     {
         $array = explode('\\', $namespace);
         $path = array_pop($array);
-        $path = strtolower(substr($path, 0, 1)).substr($path, 1);
+        $path = strtolower(substr($path, 0, 1)) . substr($path, 1);
 
         return $path;
     }

Tests/AdminBundle/Admin/Factory/AdminFactoryTest.php

Spacing +1 added lines, -1 removed lines

@@ -81,7 +81,7 @@
         // test with no configuration
         $adminFactory = $this->mockAdminFactory();
         // unknow admin not exists, it should throw an exception
-        $this->assertExceptionRaised('Exception', function () use ($adminFactory) {
+        $this->assertExceptionRaised('Exception', function() use ($adminFactory) {
             $adminFactory->getAdmin('unknown_admin');
         });
         // test with configurations samples

Tests/Base.php

Spacing +1 added lines, -1 removed lines

@@ -259,7 +259,7 @@
         $repository = $this->mockEntityRepository();
         $repository
             ->method('getEntityPersister')
-            ->willReturn( $this
+            ->willReturn($this
                 ->getMockBuilder('Doctrine\ORM\Persisters\Entity\BasicEntityPersister')
                 ->disableOriginalConstructor()
                 ->getMock());

Doc Comments +8 added lines, -8 removed lines

@@ -77,7 +77,7 @@ 
     /**
      * Assert that an exception is raised in the given code.
      *
-     * @param $exceptionClass
+     * @param string $exceptionClass
      * @param Closure $closure
      */
     protected function assertExceptionRaised($exceptionClass, Closure $closure)
@@ -124,8 +124,8 @@ 
     }
 
     /**
-     * @param $name
-     * @param $configuration
+     * @param string $name
+     * @param \LAG\AdminBundle\Admin\Configuration\AdminConfiguration $configuration
      * @return Admin
      */
     protected function mockAdmin($name, $configuration)
@@ -140,7 +140,7 @@ 
 
     /**
      * @param $name
-     * @return ActionInterface|PHPUnit_Framework_MockObject_MockObject
+     * @return ActionInterface
      */
     protected function mockAction($name)
     {
@@ -237,7 +237,7 @@ 
     /**
      * Return a mock of an entity repository
      *
-     * @return RepositoryInterface|PHPUnit_Framework_MockObject_MockObject
+     * @return \Doctrine\Common\Persistence\ObjectRepository
      */
     protected function mockEntityRepository()
     {
@@ -275,7 +275,7 @@ 
     }
 
     /**
-     * @return ActionFactory|PHPUnit_Framework_MockObject_MockObject
+     * @return ActionFactory
      */
     protected function mockActionFactory()
     {
@@ -317,7 +317,7 @@ 
     }
 
     /**
-     * @return MessageHandlerInterface|PHPUnit_Framework_MockObject_MockObject
+     * @return MessageHandlerInterface
      */
     protected function mockMessageHandler()
     {
@@ -340,7 +340,7 @@ 
     }
 
     /**
-     * @return DataProviderInterface|PHPUnit_Framework_MockObject_MockObject
+     * @return DataProviderInterface
      */
     protected function mockDataProvider()
     {

Tests/app/AppKernel.php

Spacing +3 added lines, -3 removed lines

@@ -22,7 +22,7 @@ 
 
     public function registerContainerConfiguration(LoaderInterface $loader)
     {
-        $loader->load(__DIR__.'/config/config_test.yml');
+        $loader->load(__DIR__ . '/config/config_test.yml');
     }
 
     /**
@@ -30,7 +30,7 @@ 
      */
     public function getCacheDir()
     {
-        $cacheDir = sys_get_temp_dir().'/phpunit/cache';
+        $cacheDir = sys_get_temp_dir() . '/phpunit/cache';
 
         if (!is_dir($cacheDir)) {
             mkdir($cacheDir, 0777, true);
@@ -44,7 +44,7 @@ 
      */
     public function getLogDir()
     {
-        $logDir = sys_get_temp_dir().'/phpunit/logs';
+        $logDir = sys_get_temp_dir() . '/phpunit/logs';
 
         if (!is_dir($logDir)) {
             mkdir($logDir, 0777, true);

Tests/bootstrap.php

Spacing +3 added lines, -3 removed lines

@@ -4,13 +4,13 @@ 
 
 //use Symfony\Component\HttpFoundation\Request;
 
-if (!is_file($loaderFile = __DIR__.'/../vendor/autoload.php') && !is_file($loaderFile = __DIR__.'/../../../../../../vendor/autoload.php')) {
+if (!is_file($loaderFile = __DIR__ . '/../vendor/autoload.php') && !is_file($loaderFile = __DIR__ . '/../../../../../../vendor/autoload.php')) {
     throw new LogicException('Could not find autoload.php in vendor/. Did you run "composer install --dev"?');
 }
 
 /** @var \Composer\Autoload\ClassLoader $loader */
 $loader = require $loaderFile;
-$loader->add('', __DIR__.'/src/');
+$loader->add('', __DIR__ . '/src/');
 $loader->register();
 
 //require_once __DIR__ . '/src/Entity/TestEntity.php';
@@ -30,4 +30,4 @@ 
 //$loader = require_once __DIR__.'/app/bootstrap.php.cache';
 
 //require_once __DIR__ . '/src/Test/TestBundle/TestTestBundle.php';
-require_once __DIR__.'/app/AppKernel.php';
+require_once __DIR__ . '/app/AppKernel.php';

Admin/Admin.php

Doc Comments +1 added lines, -1 removed lines

@@ -358,7 +358,7 @@
     }
 
     /**
-     * @return array
+     * @return integer[]
      */
     public function getActionNames()
     {

Controller/CRUDController.php

Spacing +2 added lines, -2 removed lines

@@ -249,7 +249,7 @@ 
         $hooks = [];
 
         foreach ($fields as $fieldName) {
-            $exporter->addHook(function ($fieldValue) {
+            $exporter->addHook(function($fieldValue) {
                 // if field is an array
                 if (is_array($fieldValue)) {
                     $value = recursiveImplode(', ', $fieldValue);
@@ -294,7 +294,7 @@ 
         $this->forward404Unless(
             $admin->isActionGranted($admin->getCurrentAction()->getName(), $roles),
             sprintf('User with roles %s not allowed for action "%s"',
-                implode(', ', array_map(function (Role $role) {
+                implode(', ', array_map(function(Role $role) {
                     return $role->getRole();
                 }, $roles)),
                 $admin->getCurrentAction()->getName()

Field/Field/ArrayField.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
     public function render($value)
     {
         if (!is_array($value) && !($value instanceof Traversable)) {
-            throw new Exception('Value should be an array instead of '.gettype($value));
+            throw new Exception('Value should be an array instead of ' . gettype($value));
         }
         if ($value instanceof Collection) {
             $value = $value->toArray();

Field/Field/StringField.php

Spacing +1 added lines, -1 removed lines

@@ -83,7 +83,7 @@
      */
     public function setOptions(array $options)
     {
-        $this->length = (int)$options['length'];
+        $this->length = (int) $options['length'];
         $this->replace = $options['replace'];
         $this->translation = $options['translation'];
     }