LAG\AdminBundle\DataProvider\DataProvider

Complexity

Total Complexity

6

Size/Duplication

Total Lines	83
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	4
Bugs	1	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	findBy()	0	6	1
A	find()	0	6	1
A	save()	0	6	1
A	remove()	0	6	1
A	create()	0	6	1

<?php

namespace LAG\AdminBundle\DataProvider;

use Doctrine\Common\Collections\Collection;
use Doctrine\Common\Persistence\ObjectRepository;
use LAG\DoctrineRepositoryBundle\Repository\RepositoryInterface;

/**
 * Default data provider using generic repositories
 */
class DataProvider implements DataProviderInterface
{
    /**
     * @var RepositoryInterface
     */
    protected $repository;

    /**
     * DataProvider constructor.
     *
     * @param ObjectRepository $repository
     */
    public function __construct(
        ObjectRepository $repository
    ) {
        $this->repository = $repository;

$repository is of type object<Doctrine\Common\Persistence\ObjectRepository>, but the property $repository was declared to be of type object<LAG\DoctrineRepositoryBundle\Repository\RepositoryInterface>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    /**
     * Find entities by criteria.
     *
     * @param array $criteria
     * @param array $orderBy
     * @param int|null $limit
     * @param int|null $offset
     * @return Collection
     */
    public function findBy(array $criteria = [], $orderBy = [], $limit = null, $offset = null)
    {
        return $this

The expression $this->repository->findBy($criteria, $orderBy, $limit, $offset); of type array|Doctrine\Common\Collections\Collection adds the type array to the return on line 41 which is incompatible with the return type documented by LAG\AdminBundle\DataProvider\DataProvider::findBy of type Doctrine\Common\Collections\Collection.

            ->repository
            ->findBy($criteria, $orderBy, $limit, $offset);
    }

    /**
     * Find an entity by its unique id.
     *
     * @param $id
     * @return object
     */
    public function find($id)
    {
        return $this
            ->repository
            ->find($id);
    }

    /**
     * Save an entity.
     *
     * @param $entity
     */
    public function save($entity)
    {
        $this
            ->repository
            ->save($entity);
    }

    /**
     * Remove an entity.
     *
     * @param $entity
     */
    public function remove($entity)
    {
        $this
            ->repository
            ->delete($entity);
    }

    /**
     * Create a new entity.
     *
     * @return object
     */
    public function create()
    {
        $className = $this->repository->getClassName();

        return new $className;
    }
}