LAG\AdminBundle\Menu\Provider\MenuProvider

Complexity

Total Complexity

3

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Test Coverage

Coverage

77.78%

Importance

Changes	4
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	get()	0	5	1
A	__construct()	0	6	1
A	has()	0	3	1

<?php

declare(strict_types=1);

namespace LAG\AdminBundle\Menu\Provider;

use Knp\Menu\ItemInterface;
use Knp\Menu\Provider\MenuProviderInterface;
use LAG\AdminBundle\Menu\Factory\MenuFactoryInterface;

/**
 * Create a new KNP menu using the MenuConfiguration class to validate provided options.
 */
class MenuProvider implements MenuProviderInterface
{
    private array $menuConfigurations;
    private MenuFactoryInterface $menuFactory;

    public function __construct(
        array $menuConfigurations,
        MenuFactoryInterface $menuFactory
    ) {
        $this->menuConfigurations = $menuConfigurations;
        $this->menuFactory = $menuFactory;
    }

    public function get(string $name, array $options = []): ItemInterface
    {
        $options = array_merge($this->menuConfigurations[$name] ?? [], $options);

        return $this->menuFactory->create($name, $options);

The expression return $this->menuFactory->create($name, $options) could return the type null which is incompatible with the type-hinted return Knp\Menu\ItemInterface. Consider adding an additional type-check to rule them out.

    }

    public function has(string $name, array $options = []): bool
    {
        return \array_key_exists($name, $this->menuConfigurations);
    }
}