DataProviderTest - Code Metrics - Inspection of "Merge pull request #6 from larriereguichet/0.3-dev" - larriereguichet/AdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — dev ( 5c06f5...dcd39b )

by Arnaud

created 2016-02-16 19:01 UTC

DataProviderTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	62
Duplicated Lines	70.97 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
wmc	4
c	2
b	0
f	1
lcom	1
cbo	2
dl	44
loc	62
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
A	testSave()	11	11	1
A	testDelete()	11	11	1
A	testFind()	11	11	1
A	testfindBy()	11	11	1

How to fix Duplicated Code

<?php

namespace BlueBear\AdminBundle\Tests\AdminBundle\DataProvider;

use LAG\AdminBundle\DataProvider\DataProvider;
use LAG\AdminBundle\Tests\Base;
use stdClass;

/**
 * Test the built-in data provider
 */
class DataProviderTest extends Base
{
    /**
     * Method save SHOULD be called on the entiy repository
     */
    public function testSave()
    {
        // repository save method SHOULD be called
        $repositoryMock = $this->mockEntityRepository();
        $repositoryMock
            ->expects($this->once())
            ->method('save');

        $dataProvider = new DataProvider($repositoryMock);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $dataProvider->save(new stdClass());
    }

    /**
     * Method delete SHOULD be called on the entity repository
     */
    public function testDelete()
    {
        // entity manager delete method SHOULD be called
        $repositoryMock = $this->mockEntityRepository();
        $repositoryMock
            ->expects($this->once())
            ->method('delete');

        $dataProvider = new DataProvider($repositoryMock);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $dataProvider->remove(new stdClass());
    }

    /**
     * Method find SHOULD be called on the entity repository
     */
    public function testFind()

    {
        // repository find method SHOULD be called
        $repositoryMock = $this->mockEntityRepository();
        $repositoryMock
            ->expects($this->once())
            ->method('find');

        $dataProvider = new DataProvider($repositoryMock);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $dataProvider->find('unique_id');
    }

    /**
     * Method findBy SHOULD be called on the entity repository
     */
    public function testfindBy()
    {
        // repository findBy method SHOULD be called
        $repositoryMock = $this->mockEntityRepository();
        $repositoryMock
            ->expects($this->once())
            ->method('findBy');

        $dataProvider = new DataProvider($repositoryMock);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $dataProvider->findBy([]);
    }
}


1		<?php
2
3		namespace BlueBear\AdminBundle\Tests\AdminBundle\DataProvider;
4
5		use LAG\AdminBundle\DataProvider\DataProvider;
6		use LAG\AdminBundle\Tests\Base;
7		use stdClass;
8
9		/**
10		* Test the built-in data provider
11		*/
12		class DataProviderTest extends Base
13		{
14		/**
15		* Method save SHOULD be called on the entiy repository
16		*/
17	View Code Duplication	public function testSave()
18		{
19		// repository save method SHOULD be called
20		$repositoryMock = $this->mockEntityRepository();
21		$repositoryMock
22		->expects($this->once())
23		->method('save');
24
25		$dataProvider = new DataProvider($repositoryMock);
		0 ignored issues – show Bug introduced 2016-02-06 23:05 UTC by Report Bug Copy Issue Report It seems like `$repositoryMock` defined by `$this->mockEntityRepository()` on line `20` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `LAG\AdminBundle\DataProv...Provider::__construct()` does only seem to accept `object<LAG\DoctrineRepos...ry\RepositoryInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
26		$dataProvider->save(new stdClass());
27		}
28
29		/**
30		* Method delete SHOULD be called on the entity repository
31		*/
32	View Code Duplication	public function testDelete()
33		{
34		// entity manager delete method SHOULD be called
35		$repositoryMock = $this->mockEntityRepository();
36		$repositoryMock
37		->expects($this->once())
38		->method('delete');
39
40		$dataProvider = new DataProvider($repositoryMock);
		0 ignored issues – show Bug introduced 2016-02-06 23:05 UTC by Report Bug Copy Issue Report It seems like `$repositoryMock` defined by `$this->mockEntityRepository()` on line `35` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `LAG\AdminBundle\DataProv...Provider::__construct()` does only seem to accept `object<LAG\DoctrineRepos...ry\RepositoryInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
41		$dataProvider->remove(new stdClass());
42		}
43
44		/**
45		* Method find SHOULD be called on the entity repository
46		*/
47	View Code Duplication	public function testFind()
		0 ignored issues – show Duplication introduced 2016-01-30 13:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
48		{
49		// repository find method SHOULD be called
50		$repositoryMock = $this->mockEntityRepository();
51		$repositoryMock
52		->expects($this->once())
53		->method('find');
54
55		$dataProvider = new DataProvider($repositoryMock);
		0 ignored issues – show Bug introduced 2016-02-06 23:05 UTC by Report Bug Copy Issue Report It seems like `$repositoryMock` defined by `$this->mockEntityRepository()` on line `50` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `LAG\AdminBundle\DataProv...Provider::__construct()` does only seem to accept `object<LAG\DoctrineRepos...ry\RepositoryInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
56		$dataProvider->find('unique_id');
57		}
58
59		/**
60		* Method findBy SHOULD be called on the entity repository
61		*/
62	View Code Duplication	public function testfindBy()
63		{
64		// repository findBy method SHOULD be called
65		$repositoryMock = $this->mockEntityRepository();
66		$repositoryMock
67		->expects($this->once())
68		->method('findBy');
69
70		$dataProvider = new DataProvider($repositoryMock);
		0 ignored issues – show Bug introduced 2016-02-06 23:05 UTC by Report Bug Copy Issue Report It seems like `$repositoryMock` defined by `$this->mockEntityRepository()` on line `65` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `LAG\AdminBundle\DataProv...Provider::__construct()` does only seem to accept `object<LAG\DoctrineRepos...ry\RepositoryInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
71		$dataProvider->findBy([]);
72		}
73		}
74

larriereguichet / AdminBundle

Push — dev ( 5c06f5...dcd39b )

DataProviderTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like