Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Admin often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Admin, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 26 | class Admin implements AdminInterface |
||
| 27 | { |
||
| 28 | use AdminTrait; |
||
| 29 | |||
| 30 | /** |
||
| 31 | * Entities collection. |
||
| 32 | * |
||
| 33 | * @var ArrayCollection |
||
| 34 | */ |
||
| 35 | protected $entities; |
||
| 36 | |||
| 37 | /** |
||
| 38 | * @var MessageHandlerInterface |
||
| 39 | */ |
||
| 40 | protected $messageHandler; |
||
| 41 | |||
| 42 | /** |
||
| 43 | * @var EntityManagerInterface |
||
| 44 | */ |
||
| 45 | protected $entityManager; |
||
| 46 | |||
| 47 | /** |
||
| 48 | * @var DataProviderInterface |
||
| 49 | */ |
||
| 50 | protected $dataProvider; |
||
| 51 | |||
| 52 | /** |
||
| 53 | * Admin configuration object |
||
| 54 | * |
||
| 55 | * @var AdminConfiguration |
||
| 56 | */ |
||
| 57 | protected $configuration; |
||
| 58 | |||
| 59 | /** |
||
| 60 | * Admin configured actions |
||
| 61 | * |
||
| 62 | * @var ActionInterface[] |
||
| 63 | */ |
||
| 64 | protected $actions = []; |
||
| 65 | |||
| 66 | /** |
||
| 67 | * Admin current action. It will be set after calling the handleRequest() |
||
| 68 | * |
||
| 69 | * @var ActionInterface |
||
| 70 | */ |
||
| 71 | protected $currentAction; |
||
| 72 | |||
| 73 | /** |
||
| 74 | * Admin name |
||
| 75 | * |
||
| 76 | * @var string |
||
| 77 | */ |
||
| 78 | protected $name; |
||
| 79 | |||
| 80 | /** |
||
| 81 | * Admin constructor. |
||
| 82 | * |
||
| 83 | * @param string $name |
||
| 84 | * @param DataProviderInterface $dataProvider |
||
| 85 | * @param AdminConfiguration $configuration |
||
| 86 | * @param MessageHandlerInterface $messageHandler |
||
| 87 | */ |
||
| 88 | 19 | public function __construct( |
|
| 100 | |||
| 101 | /** |
||
| 102 | * Load entities and set current action according to request |
||
| 103 | * |
||
| 104 | * @param Request $request |
||
| 105 | * @param null $user |
||
| 106 | * @return void |
||
| 107 | * @throws AdminException |
||
| 108 | */ |
||
| 109 | 6 | public function handleRequest(Request $request, $user = null) |
|
| 110 | { |
||
| 111 | // set current action |
||
| 112 | 6 | $this->currentAction = $this->getAction($request->get('_route_params')['_action']); |
|
| 113 | // check if user is logged have required permissions to get current action |
||
| 114 | 6 | $this->checkPermissions($user); |
|
| 115 | |||
| 116 | // criteria filter request |
||
| 117 | 6 | $filter = new RequestFilter($this->currentAction->getConfiguration()->getParameter('criteria')); |
|
| 118 | 6 | $criteriaFilter = $filter->filter($request); |
|
| 119 | |||
| 120 | // pager filter request |
||
| 121 | 6 | if ($this->currentAction->getConfiguration()->getParameter('pager') == 'pagerfanta') { |
|
| 122 | 5 | $filter = new PagerfantaFilter(); |
|
| 123 | 5 | $pagerFilter = $filter->filter($request); |
|
| 124 | 5 | } else { |
|
| 125 | // empty bag |
||
| 126 | 1 | $pagerFilter = new ParameterBag(); |
|
| 127 | } |
||
| 128 | |||
| 129 | // if load strategy is none, no entity should be loaded |
||
| 130 | 6 | if ($this->currentAction->getConfiguration()->getParameter('load_strategy') == Admin::LOAD_STRATEGY_NONE) { |
|
| 131 | 1 | return; |
|
| 132 | } |
||
| 133 | |||
| 134 | // load entities according to action and request |
||
| 135 | 6 | $this->load( |
|
| 136 | 6 | $criteriaFilter->all(), |
|
| 137 | 6 | $pagerFilter->get('order', []), |
|
| 138 | 6 | $this->configuration->getParameter('max_per_page'), |
|
| 139 | 6 | $pagerFilter->get('page', 1) |
|
| 140 | 6 | ); |
|
| 141 | 6 | } |
|
| 142 | |||
| 143 | /** |
||
| 144 | * Check if user is allowed to be here |
||
| 145 | * |
||
| 146 | * @param UserInterface|string $user |
||
| 147 | * @throws Exception |
||
| 148 | */ |
||
| 149 | 6 | public function checkPermissions($user) |
|
| 150 | { |
||
| 151 | 6 | if (!($user instanceof UserInterface)) { |
|
| 152 | 6 | return; |
|
| 153 | } |
||
| 154 | 1 | if ($this->currentAction === null) { |
|
| 155 | 1 | throw new Exception('Current action should be set before checking the permissions'); |
|
| 156 | } |
||
| 157 | 1 | $roles = $user->getRoles(); |
|
| 158 | 1 | $actionName = $this |
|
| 159 | 1 | ->getCurrentAction() |
|
| 160 | 1 | ->getName(); |
|
| 161 | |||
| 162 | 1 | if (!$this->isActionGranted($actionName, $roles)) { |
|
| 163 | 1 | $rolesStringArray = []; |
|
| 164 | |||
| 165 | 1 | foreach ($roles as $role) { |
|
| 166 | |||
| 167 | 1 | if ($role instanceof Role) { |
|
| 168 | 1 | $rolesStringArray[] = $role->getRole(); |
|
| 169 | 1 | } else { |
|
| 170 | 1 | $rolesStringArray[] = $role; |
|
| 171 | } |
||
| 172 | 1 | } |
|
| 173 | |||
| 174 | 1 | $message = sprintf('User with roles %s not allowed for action "%s"', |
|
| 175 | 1 | implode(', ', $rolesStringArray), |
|
| 176 | $actionName |
||
| 177 | 1 | ); |
|
| 178 | 1 | throw new NotFoundHttpException($message); |
|
| 179 | } |
||
| 180 | 1 | } |
|
| 181 | |||
| 182 | /** |
||
| 183 | * Create and return a new entity. |
||
| 184 | * |
||
| 185 | * @return object |
||
| 186 | */ |
||
| 187 | 3 | public function create() |
|
| 206 | |||
| 207 | /** |
||
| 208 | * Save entity via admin manager. Error are catch, logged and a flash message is added to session |
||
| 209 | * |
||
| 210 | * @return bool true if the entity was saved without errors |
||
| 211 | */ |
||
| 212 | 1 | View Code Duplication | public function save() |
| 236 | |||
| 237 | /** |
||
| 238 | * Remove an entity with data provider |
||
| 239 | * |
||
| 240 | * @return bool true if the entity was saved without errors |
||
| 241 | */ |
||
| 242 | 1 | View Code Duplication | public function remove() |
| 266 | |||
| 267 | /** |
||
| 268 | * Generate a route for admin and action name (like lag.admin.my_admin) |
||
| 269 | * |
||
| 270 | * @param $actionName |
||
| 271 | * |
||
| 272 | * @return string |
||
| 273 | * |
||
| 274 | * @throws Exception |
||
| 275 | */ |
||
| 276 | 10 | public function generateRouteName($actionName) |
|
| 294 | |||
| 295 | /** |
||
| 296 | * Load entities manually according to criteria. |
||
| 297 | * |
||
| 298 | * @param array $criteria |
||
| 299 | * @param array $orderBy |
||
| 300 | * @param int $limit |
||
| 301 | * @param int $offset |
||
| 302 | * @throws Exception |
||
| 303 | */ |
||
| 304 | 6 | public function load(array $criteria, $orderBy = [], $limit = 25, $offset = 1) |
|
| 343 | |||
| 344 | 2 | /** |
|
| 345 | * Return loaded entities |
||
| 346 | * |
||
| 347 | * @return Collection |
||
| 348 | */ |
||
| 349 | public function getEntities() |
||
| 353 | |||
| 354 | 1 | /** |
|
| 355 | * Return entity for current admin. If entity does not exist, it throws an exception. |
||
| 356 | 1 | * |
|
| 357 | 1 | * @return mixed |
|
| 358 | * |
||
| 359 | 1 | * @throws Exception |
|
| 360 | 1 | */ |
|
| 361 | public function getUniqueEntity() |
||
| 371 | |||
| 372 | 16 | /** |
|
| 373 | * Return admin name |
||
| 374 | * |
||
| 375 | * @return string |
||
| 376 | */ |
||
| 377 | public function getName() |
||
| 381 | |||
| 382 | /** |
||
| 383 | 2 | * Return true if current action is granted for user. |
|
| 384 | * |
||
| 385 | 2 | * @param string $actionName Le plus grand de tous les héros |
|
| 386 | * @param array $roles |
||
| 387 | * |
||
| 388 | 2 | * @return bool |
|
| 389 | 2 | */ |
|
| 390 | public function isActionGranted($actionName, array $roles) |
||
| 413 | |||
| 414 | /** |
||
| 415 | * @return ActionInterface[] |
||
| 416 | */ |
||
| 417 | public function getActions() |
||
| 421 | |||
| 422 | /** |
||
| 423 | * @return integer[] |
||
| 424 | */ |
||
| 425 | public function getActionNames() |
||
| 429 | |||
| 430 | 6 | /** |
|
| 431 | 1 | * @param $name |
|
| 432 | 1 | * @return ActionInterface |
|
| 433 | 1 | * @throws Exception |
|
| 434 | */ |
||
| 435 | public function getAction($name) |
||
| 445 | 1 | ||
| 446 | /** |
||
| 447 | 1 | * Return if an action with specified name exists form this admin. |
|
| 448 | * |
||
| 449 | * @param $name |
||
| 450 | * @return bool |
||
| 451 | */ |
||
| 452 | public function hasAction($name) |
||
| 456 | 14 | ||
| 457 | 14 | /** |
|
| 458 | * @param ActionInterface $action |
||
| 459 | * @return void |
||
| 460 | */ |
||
| 461 | public function addAction(ActionInterface $action) |
||
| 465 | 7 | ||
| 466 | /** |
||
| 467 | 7 | * Return the current action or an exception if it is not set. |
|
| 468 | * |
||
| 469 | 1 | * @return ActionInterface |
|
| 470 | * @throws Exception |
||
| 471 | 1 | */ |
|
| 472 | public function getCurrentAction() |
||
| 483 | |||
| 484 | 1 | /** |
|
| 485 | * Return if the current action has been initialized and set. |
||
| 486 | * |
||
| 487 | * @return boolean |
||
| 488 | */ |
||
| 489 | public function isCurrentActionDefined() |
||
| 493 | |||
| 494 | 16 | /** |
|
| 495 | * Return admin configuration object. |
||
| 496 | * |
||
| 497 | * @return AdminConfiguration |
||
| 498 | */ |
||
| 499 | public function getConfiguration() |
||
| 503 | 3 | ||
| 504 | /** |
||
| 505 | 3 | * Return an translation key for a message according to the Admin's translation pattern. |
|
| 506 | 3 | * |
|
| 507 | 3 | * @param string $message |
|
| 508 | 3 | * @return string |
|
| 509 | 3 | */ |
|
| 510 | protected function generateMessageTranslationKey($message) |
||
| 518 | } |
||
| 519 |