ActionCollectionField::resolveActionLinkConfiguration() - Code Metrics - Inspection of "Improvement/scrutinizer issues" - larriereguichet/AdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#110)

by Arnaud

created 2019-02-21 22:10 UTC

resolveActionLinkConfiguration() C

↳ Parent: ActionCollectionField

Complexity

Conditions	11
Paths	4

Size

Total Lines	98
Code Lines	62

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	11
eloc	62
nc	4
nop	3
dl	0
loc	98
rs	6.6824
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

namespace LAG\AdminBundle\Field;

use LAG\AdminBundle\Configuration\ActionConfiguration;
use LAG\AdminBundle\Field\Traits\EntityAwareTrait;
use LAG\AdminBundle\Field\Traits\TwigAwareTrait;
use LAG\AdminBundle\Routing\RoutingLoader;
use LAG\AdminBundle\Utils\StringUtils;
use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException;
use Symfony\Component\OptionsResolver\Options;
use Symfony\Component\OptionsResolver\OptionsResolver;
use Symfony\Component\PropertyAccess\PropertyAccess;

class ActionCollectionField extends CollectionField implements TwigAwareFieldInterface, EntityAwareFieldInterface
{
    use TwigAwareTrait, EntityAwareTrait;

    public function configureOptions(OptionsResolver $resolver, ActionConfiguration $actionConfiguration)
    {
        parent::configureOptions($resolver, $actionConfiguration);

        $resolver
            ->setDefaults([
                'template' => '@LAGAdmin/Field/actionCollection.html.twig',
                'actions' => [],
            ])
            ->setNormalizer('actions', function (Options $options, $value) use ($actionConfiguration) {
                if (!is_array($value) || 0 === count($value)) {
                    $value = [
                        'edit' => [],
                        'delete' => [],
                    ];
                }
                $data = [];

                foreach ($value as $name => $actionLinkConfiguration) {
                    $data[$name] = $this->resolveActionLinkConfiguration(
                        $actionConfiguration,
                        $name,
                        $actionLinkConfiguration
                    );
                }

                return $data;
            })
        ;
    }

    public function isSortable(): bool
    {
        return false;
    }

    public function render($value = null): string
    {
        $accessor = PropertyAccess::createPropertyAccessor();

        if (key_exists('edit', $this->options['actions'])) {
            $this->options['actions']['edit']['parameters']['id'] = $accessor->getValue($this->entity, 'id');
        }

        if (key_exists('delete', $this->options['actions'])) {
            $this->options['actions']['delete']['parameters']['id'] = $accessor->getValue($this->entity, 'id');
        }

        return $this->twig->render($this->options['template'], [
            'actions' => $this->options['actions'],
        ]);
    }

    protected function resolveActionLinkConfiguration(
        ActionConfiguration $actionConfiguration,
        string $actionName,
        array $actionLinkConfiguration = []
    ): array {
        $translationPattern = $actionConfiguration
            ->getAdminConfiguration()
            ->getParameter('translation_pattern')
        ;

        $icon = '';
        $cssClass = '';
        $routeParameters = [];

        if ('delete' === $actionName) {
            $icon = 'remove';
            $cssClass = 'btn btn-danger btn-sm';
            $routeParameters = [
                'id' => '',
            ];
        }
        if ('edit' === $actionName) {
            $icon = 'pencil';
            $cssClass = 'btn btn-secondary btn-sm';
        }

        $resolver = new OptionsResolver();
        $resolver
            ->setDefaults([
                'title' => StringUtils::getTranslationKey(
                    $translationPattern,
                    $actionConfiguration->getAdminName(),
                    $actionName
                ),
                'icon' => $icon,
                'target' => '_self',
                'route' => '',
                'parameters' => $routeParameters,
                'url' => '',
                'text' => StringUtils::getTranslationKey(
                    $translationPattern,
                    $actionConfiguration->getAdminName(),
                    $actionName
                ),
                'admin' => $actionConfiguration->getAdminName(),
                'action' => $actionName,
                'class' => $cssClass,
            ])
            ->setAllowedTypes('route', 'string')
            ->setAllowedTypes('parameters', 'array')
            ->setAllowedTypes('url', 'string')
            ->setAllowedValues('target', [
                '_self',
                '_blank',
            ])
            ->setNormalizer('route', function (Options $options, $value) use ($actionConfiguration) {
                // route or url should be defined
                if (!$value && !$options->offsetGet('url') && !$options->offsetGet('admin')) {
                    throw new InvalidOptionsException(
                        'You must set either an url or a route for the property'
                    );
                }

                if ($options->offsetGet('admin')) {
                    $value = RoutingLoader::generateRouteName(
                        $options->offsetGet('admin'),
                        $options->offsetGet('action'),
                        $actionConfiguration->getAdminConfiguration()->getParameter('routing_name_pattern')
                    );
                }

                return $value;
            })
            ->setNormalizer('admin', function (Options $options, $value) {
                // if a Admin is defined, an Action should be defined too
                if ($value && !$options->offsetGet('action')) {
                    throw new InvalidOptionsException(
                        'An Action should be provided if an Admin is provided'
                    );
                }

                return $value;
            })
            ->setNormalizer('parameters', function (Options $options, $values) {
                $cleanedValues = [];

                foreach ($values as $name => $method) {
                    if (null === $method) {
                        $method = $name;
                    }
                    $cleanedValues[$name] = $method;
                }

                return $cleanedValues;
            })
        ;

        return $resolver->resolve($actionLinkConfiguration);
    }
}


1			<?php
2
3			namespace LAG\AdminBundle\Field;
4
5			use LAG\AdminBundle\Configuration\ActionConfiguration;
6			use LAG\AdminBundle\Field\Traits\EntityAwareTrait;
7			use LAG\AdminBundle\Field\Traits\TwigAwareTrait;
8			use LAG\AdminBundle\Routing\RoutingLoader;
9			use LAG\AdminBundle\Utils\StringUtils;
10			use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException;
11			use Symfony\Component\OptionsResolver\Options;
12			use Symfony\Component\OptionsResolver\OptionsResolver;
13			use Symfony\Component\PropertyAccess\PropertyAccess;
14
15			class ActionCollectionField extends CollectionField implements TwigAwareFieldInterface, EntityAwareFieldInterface
16			{
17			use TwigAwareTrait, EntityAwareTrait;
18
19			public function configureOptions(OptionsResolver $resolver, ActionConfiguration $actionConfiguration)
20			{
21			parent::configureOptions($resolver, $actionConfiguration);
22
23			$resolver
24			->setDefaults([
25			'template' => '@LAGAdmin/Field/actionCollection.html.twig',
26			'actions' => [],
27			])
28			->setNormalizer('actions', function (Options $options, $value) use ($actionConfiguration) {
29			if (!is_array($value) \|\| 0 === count($value)) {
30			$value = [
31			'edit' => [],
32			'delete' => [],
33			];
34			}
35			$data = [];
36
37			foreach ($value as $name => $actionLinkConfiguration) {
38			$data[$name] = $this->resolveActionLinkConfiguration(
39			$actionConfiguration,
40			$name,
41			$actionLinkConfiguration
42			);
43			}
44
45			return $data;
46			})
47			;
48			}
49
50			public function isSortable(): bool
51			{
52			return false;
53			}
54
55			public function render($value = null): string
56			{
57			$accessor = PropertyAccess::createPropertyAccessor();
58
59			if (key_exists('edit', $this->options['actions'])) {
60			$this->options['actions']['edit']['parameters']['id'] = $accessor->getValue($this->entity, 'id');
61			}
62
63			if (key_exists('delete', $this->options['actions'])) {
64			$this->options['actions']['delete']['parameters']['id'] = $accessor->getValue($this->entity, 'id');
65			}
66
67			return $this->twig->render($this->options['template'], [
68			'actions' => $this->options['actions'],
69			]);
70			}
71
72			protected function resolveActionLinkConfiguration(
73			ActionConfiguration $actionConfiguration,
74			string $actionName,
75			array $actionLinkConfiguration = []
76			): array {
77			$translationPattern = $actionConfiguration
78			->getAdminConfiguration()
79			->getParameter('translation_pattern')
80			;
81
82			$icon = '';
83			$cssClass = '';
84			$routeParameters = [];
85
86			if ('delete' === $actionName) {
87			$icon = 'remove';
88			$cssClass = 'btn btn-danger btn-sm';
89			$routeParameters = [
90			'id' => '',
91			];
92			}
93			if ('edit' === $actionName) {
94			$icon = 'pencil';
95			$cssClass = 'btn btn-secondary btn-sm';
96			}
97
98			$resolver = new OptionsResolver();
99			$resolver
100			->setDefaults([
101			'title' => StringUtils::getTranslationKey(
102			$translationPattern,
103			$actionConfiguration->getAdminName(),
104			$actionName
105			),
106			'icon' => $icon,
107			'target' => '_self',
108			'route' => '',
109			'parameters' => $routeParameters,
110			'url' => '',
111			'text' => StringUtils::getTranslationKey(
112			$translationPattern,
113			$actionConfiguration->getAdminName(),
114			$actionName
115			),
116			'admin' => $actionConfiguration->getAdminName(),
117			'action' => $actionName,
118			'class' => $cssClass,
119			])
120			->setAllowedTypes('route', 'string')
121			->setAllowedTypes('parameters', 'array')
122			->setAllowedTypes('url', 'string')
123			->setAllowedValues('target', [
124			'_self',
125			'_blank',
126			])
127			->setNormalizer('route', function (Options $options, $value) use ($actionConfiguration) {
128			// route or url should be defined
129			if (!$value && !$options->offsetGet('url') && !$options->offsetGet('admin')) {
130			throw new InvalidOptionsException(
131			'You must set either an url or a route for the property'
132			);
133			}
134
135			if ($options->offsetGet('admin')) {
136			$value = RoutingLoader::generateRouteName(
137			$options->offsetGet('admin'),
138			$options->offsetGet('action'),
139			$actionConfiguration->getAdminConfiguration()->getParameter('routing_name_pattern')
140			);
141			}
142
143			return $value;
144			})
145			->setNormalizer('admin', function (Options $options, $value) {
146			// if a Admin is defined, an Action should be defined too
147			if ($value && !$options->offsetGet('action')) {
148			throw new InvalidOptionsException(
149			'An Action should be provided if an Admin is provided'
150			);
151			}
152
153			return $value;
154			})
155			->setNormalizer('parameters', function (Options $options, $values) {
156			$cleanedValues = [];
157
158			foreach ($values as $name => $method) {
159			if (null === $method) {
160			$method = $name;
161			}
162			$cleanedValues[$name] = $method;
163			}
164
165			return $cleanedValues;
166			})
167			;
168
169			return $resolver->resolve($actionLinkConfiguration);
170			}
171			}
172

larriereguichet / AdminBundle

Pull Request — master (#110)

resolveActionLinkConfiguration() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like