LAG\AdminBundle\Event\Events\ViewEvent

Complexity

Total Complexity

5

Size/Duplication

Total Lines	61
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	5	5	1
A	getView()	4	4	1
A	setView()	4	4	1
A	getAdmin()	4	4	1
A	getRequest()	4	4	1

<?php

namespace LAG\AdminBundle\Event\Events;

use LAG\AdminBundle\Admin\AdminInterface;
use LAG\AdminBundle\View\ViewInterface;
use Symfony\Component\EventDispatcher\Event;
use Symfony\Component\HttpFoundation\Request;

class ViewEvent extends Event

This class seems to be duplicated in your project.

{
    /**
     * @var ViewInterface
     */
    private $view;

    /**
     * @var AdminInterface
     */
    private $admin;

    /**
     * @var Request
     */
    private $request;

    /**
     * ViewEvent constructor.
     *
     * @param AdminInterface $admin
     * @param Request        $request
     */
    public function __construct(AdminInterface $admin, Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->admin = $admin;
        $this->request = $request;
    }

    /**
     * @return ViewInterface
     */
    public function getView(): ViewInterface
    {
        return $this->view;
    }

    /**
     * @param ViewInterface $view
     */
    public function setView(ViewInterface $view)
    {
        $this->view = $view;
    }

    /**
     * @return AdminInterface
     */
    public function getAdmin(): AdminInterface
    {
        return $this->admin;
    }

    /**
     * @return Request
     */
    public function getRequest(): Request
    {
        return $this->request;
    }
}