EditFormHandler::__construct() - Code Metrics - Inspection of "V.1.0" - larriereguichet/AdminBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#90)

by Arnaud

created 2017-11-05 16:28 UTC

EditFormHandler::__construct() A

↳ Parent: EditFormHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	0
cts	5
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	3
crap	2

<?php

namespace LAG\AdminBundle\Form\Handler;

use LAG\AdminBundle\Admin\AdminInterface;
use LAG\AdminBundle\Routing\RouteNameGenerator;
use Symfony\Bundle\FrameworkBundle\Routing\Router;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\RouterInterface;
use Twig_Environment;

/**
 * Create a response from the form data.
 */
class EditFormHandler
{
    /**
     * @var Twig_Environment
     */
    private $twig;
    
    /**
     * @var Router
     */
    private $router;
    
    /**
     * @var RequestStack
     */
    private $requestStack;
    
    /**
     * EditFormHandler constructor.
     *
     * @param Twig_Environment $twig
     * @param RouterInterface  $router
     * @param RequestStack     $requestStack
     */
    public function __construct(Twig_Environment $twig, RouterInterface $router, RequestStack $requestStack)
    {
        $this->twig = $twig;
        $this->router = $router;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        $this->requestStack = $requestStack;
    }
    
    /**
     * Save the entity if the form is valid, and redirect to the list action if
     * required
     *
     * @param FormInterface $form
     * @param AdminInterface $admin
     *
     * @return RedirectResponse|Response
     */
    public function handle(FormInterface $form, AdminInterface $admin)
    {
        $template = $admin
            ->getView()
            ->getConfiguration()
            ->getParameter('template')
        ;
        
        if ($form->isValid()) {

            // if the form is valid, we save the entity
            $admin->save();
    
            if ($this->shouldRedirect($admin)) {
                $generator = new RouteNameGenerator();
                
                // if the redirect input is clicked and the list action exists, we redirect to the list action
                $url = $this
                    ->router
                    ->generate($generator->generate('list', $admin->getName(), $admin->getConfiguration()));
                
                return new RedirectResponse($url);
            }
        }
        // display the form after validation or not
        $content = $this
            ->twig
            ->render($template, [
                'admin' => $admin,
                'form' => $form->createView()
            ])
        ;
    
        return new Response($content);
    }
    
    /**
     * Return true if the user should be redirected to the list action.
     *
     * @param AdminInterface $admin
     *
     * @return bool
     */
    private function shouldRedirect(AdminInterface $admin)
    {
        $submit = $this
            ->requestStack
            ->getCurrentRequest()
            ->get('submit')
        ;
        
        if ('save-and-redirect' !== $submit) {
            return false;
        }
        $actions = $admin
            ->getConfiguration()
            ->getParameter('actions')
        ;
    
        if (!key_exists('list', $actions)) {
            return false;
        }
        
        return true;
    }
}


1		<?php
2
3		namespace LAG\AdminBundle\Form\Handler;
4
5		use LAG\AdminBundle\Admin\AdminInterface;
6		use LAG\AdminBundle\Routing\RouteNameGenerator;
7		use Symfony\Bundle\FrameworkBundle\Routing\Router;
8		use Symfony\Component\Form\FormInterface;
9		use Symfony\Component\HttpFoundation\RedirectResponse;
10		use Symfony\Component\HttpFoundation\RequestStack;
11		use Symfony\Component\HttpFoundation\Response;
12		use Symfony\Component\Routing\RouterInterface;
13		use Twig_Environment;
14
15		/**
16		* Create a response from the form data.
17		*/
18		class EditFormHandler
19		{
20		/**
21		* @var Twig_Environment
22		*/
23		private $twig;
24
25		/**
26		* @var Router
27		*/
28		private $router;
29
30		/**
31		* @var RequestStack
32		*/
33		private $requestStack;
34
35		/**
36		* EditFormHandler constructor.
37		*
38		* @param Twig_Environment $twig
39		* @param RouterInterface $router
40		* @param RequestStack $requestStack
41		*/
42		public function __construct(Twig_Environment $twig, RouterInterface $router, RequestStack $requestStack)
43		{
44		$this->twig = $twig;
45		$this->router = $router;
		0 ignored issues – show Documentation Bug introduced 2017-11-05 16:45 UTC by Report Bug Copy Issue Report `$router` is of type `object<Symfony\Component\Routing\RouterInterface>`, but the property `$router` was declared to be of type `object<Symfony\Bundle\Fr...kBundle\Routing\Router>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
46		$this->requestStack = $requestStack;
47		}
48
49		/**
50		* Save the entity if the form is valid, and redirect to the list action if
51		* required
52		*
53		* @param FormInterface $form
54		* @param AdminInterface $admin
55		*
56		* @return RedirectResponse\|Response
57		*/
58		public function handle(FormInterface $form, AdminInterface $admin)
59		{
60		$template = $admin
61		->getView()
62		->getConfiguration()
63		->getParameter('template')
64		;
65
66	View Code Duplication	if ($form->isValid()) {
		0 ignored issues – show Duplication introduced 2017-10-08 21:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
67		// if the form is valid, we save the entity
68		$admin->save();
69
70		if ($this->shouldRedirect($admin)) {
71		$generator = new RouteNameGenerator();
72
73		// if the redirect input is clicked and the list action exists, we redirect to the list action
74		$url = $this
75		->router
76		->generate($generator->generate('list', $admin->getName(), $admin->getConfiguration()));
77
78		return new RedirectResponse($url);
79		}
80		}
81		// display the form after validation or not
82		$content = $this
83		->twig
84		->render($template, [
85		'admin' => $admin,
86		'form' => $form->createView()
87		])
88		;
89
90		return new Response($content);
91		}
92
93		/**
94		* Return true if the user should be redirected to the list action.
95		*
96		* @param AdminInterface $admin
97		*
98		* @return bool
99		*/
100		private function shouldRedirect(AdminInterface $admin)
101		{
102		$submit = $this
103		->requestStack
104		->getCurrentRequest()
105		->get('submit')
106		;
107
108		if ('save-and-redirect' !== $submit) {
109		return false;
110		}
111		$actions = $admin
112		->getConfiguration()
113		->getParameter('actions')
114		;
115
116		if (!key_exists('list', $actions)) {
117		return false;
118		}
119
120		return true;
121		}
122		}
123

larriereguichet / AdminBundle

Pull Request — master (#90)

EditFormHandler::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like