LAG\AdminBundle\Bridge\KnpMenu\Builder\TopMenuBuilder::createMenu()

Complexity

Conditions	5
Paths	5

Size

Total Lines	46
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function createMenu(array $options = []): ItemInterface
    {
        $menu = $this->factory->createItem('root', $options);
        $request = $this->requestStack->getMainRequest();

        if (!$this->parametersExtractor->supports($request)) {

It seems like $request can also be of type null; however, parameter $request of LAG\AdminBundle\Request\Extractor\ParametersExtractorInterface::supports() does only seem to accept Symfony\Component\HttpFoundation\Request, maybe add an additional type check?

            return $menu;
        }
        $resourceName = $this->parametersExtractor->getResourceName($request);

It seems like $request can also be of type null; however, parameter $request of LAG\AdminBundle\Request\Extractor\ParametersExtractorInterface::getResourceName() does only seem to accept Symfony\Component\HttpFoundation\Request, maybe add an additional type check?

        $operationName = $this->parametersExtractor->getOperationName($request);

It seems like $request can also be of type null; however, parameter $request of LAG\AdminBundle\Request\Extractor\ParametersExtractorInterface::getOperationName() does only seem to accept Symfony\Component\HttpFoundation\Request, maybe add an additional type check?

        $resource = $this->registry->get($resourceName);
        $operation = $resource->getOperation($operationName);

        $this->eventDispatcher->dispatch($event = new MenuCreateEvent($menu), MenuEvents::MENU_CREATE);
        $this->eventDispatcher->dispatch($event = new MenuCreateEvent($event->getMenu()), sprintf(
            MenuEvents::NAMED_EVENT_PATTERN,
            'top',
        ));
        $menu = $event->getMenu();

        if (!$operation instanceof Index) {
            return $menu;
        }

        foreach ($operation->getListActions() as $listAction) {

The method getListActions() does not exist on LAG\AdminBundle\Metadata\Index.

            $route = $listAction->getRouteName();

            if ($route === null) {
                $route = $this
                    ->routeNameGenerator
                    ->generateRouteName($resource, $resource->getOperation($listAction->getOperationName()))
                ;
            }

            $menu->addChild($listAction->getLabel(), [
                'route' => $route,
            ]);
        }
        $this->eventDispatcher->dispatch(new MenuCreatedEvent($menu), MenuEvents::MENU_CREATED);
        $this->eventDispatcher->dispatch(new MenuCreatedEvent($menu), sprintf(
            MenuEvents::NAMED_EVENT_PATTERN,
            'top',
        ));

        return $menu;
    }