Issues in FlareServiceProvider.php (master) - Issues in master - laravelflare/flare - Measure and Improve Code Quality continuously with Scrutinizer

Issues (76)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Flare/FlareServiceProvider.php (6 issues)

Labels

Documentation 6

Severity

Minor 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace LaravelFlare\Flare;

use Illuminate\Foundation\AliasLoader;
use Illuminate\Support\ServiceProvider;

class FlareServiceProvider extends ServiceProvider
{
    /**
     * Array of Flare Service Providers to be Registered.
     * 
     * @var array
     */
    protected $serviceProviders = [
        \LaravelFlare\Flare\Providers\AuthServiceProvider::class,
        \LaravelFlare\Flare\Providers\ArtisanServiceProvider::class,
        \LaravelFlare\Flare\Providers\EventServiceProvider::class,
        \LaravelFlare\Flare\Providers\CompatibilityServiceProvider::class,

        // External Components
        \LaravelFlare\Fields\FieldServiceProvider::class,
    ];

    /**
     * Array of Flare assets and where they should be published to.
     * 
     * @var array
     */
    protected $assets = [
        'public/flare' => 'public/vendor/flare',
        'public/AdminLTE/dist' => 'public/vendor/flare',
        'public/AdminLTE/plugins' => 'public/vendor/flare/plugins',
        'public/AdminLTE/bootstrap' => 'public/vendor/flare/bootstrap',
    ];

    /**
     * Create a new service provider instance.
     *
     * @param \Illuminate\Contracts\Foundation\Application $app
     */
    public function __construct($app)
    {
        parent::__construct($app);

        $this->app->singleton('flare', function ($app) {
            return $app->make(\LaravelFlare\Flare\Flare::class, [$app]);
        });
    }

    /**
     * Perform post-registration booting of services.
     */
    public function boot()
    {
        $this->publishAssets();
        $this->publishConfig();
        $this->publishMigrations();
        $this->publishViews();
    }

    /**
     * Register any package services.
     */
    public function register()
    {
        $this->registerFlareFacade();
        $this->registerServiceProviders();
        $this->registerBindings();
    }

    /**
     * Register the Flare Facade.
     */
    protected function registerFlareFacade()
    {
        AliasLoader::getInstance()->alias('Flare', \LaravelFlare\Flare\Facades\Flare::class);
    }

    /**
     * Register Service Providers.
     */
    protected function registerServiceProviders()
    {
        foreach ($this->serviceProviders as $class) {
            $this->app->register($class);
        }
    }

    /**
     * Register the Flare Bindings.
     */
    protected function registerBindings()
    {
        $this->app->bind(
            \LaravelFlare\Flare\Contracts\Permissions\Permissionable::class,
            \Flare::config('permissions')
        );
    }

    /**
     * Publishes the Flare Assets to the appropriate directories.
     */
    protected function publishAssets()
    {
        $assets = [];

        foreach ($this->assets as $location => $asset) {
            $assets[$this->basePath($location)] = base_path($asset);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        $this->publishes($assets);
    }

    /**
     * Publishes the Flare Config File.
     */
    protected function publishConfig()
    {
        $this->publishes([
            $this->basePath('config/flare/config.php') => config_path('flare/config.php'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        ]);
    }

    /**
     * Publishes the Flare Database Migrations.
     */
    protected function publishMigrations()
    {
        $this->publishes([
            $this->basePath('Flare/Database/Migrations') => base_path('database/migrations'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        ]);
    }

    /**
     * Publishes the Flare Views and defines the location
     * they should be looked for in the application.
     */
    protected function publishViews()
    {
        $this->loadViewsFrom($this->basePath('resources/views'), 'flare');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->publishes([
            $this->basePath('resources/views') => base_path('resources/views/vendor/flare'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        ]);
    }

    /**
     * Returns the path to a provided file within the Flare package.
     * 
     * @param bool $fiepath
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * 
     * @return string
     */
    private function basePath($filepath = false)
    {
        return __DIR__.'/../'.$filepath;
    }
}


1			<?php
2
3			namespace LaravelFlare\Flare;
4
5			use Illuminate\Foundation\AliasLoader;
6			use Illuminate\Support\ServiceProvider;
7
8			class FlareServiceProvider extends ServiceProvider
9			{
10			/**
11			* Array of Flare Service Providers to be Registered.
12			*
13			* @var array
14			*/
15			protected $serviceProviders = [
16			\LaravelFlare\Flare\Providers\AuthServiceProvider::class,
17			\LaravelFlare\Flare\Providers\ArtisanServiceProvider::class,
18			\LaravelFlare\Flare\Providers\EventServiceProvider::class,
19			\LaravelFlare\Flare\Providers\CompatibilityServiceProvider::class,
20
21			// External Components
22			\LaravelFlare\Fields\FieldServiceProvider::class,
23			];
24
25			/**
26			* Array of Flare assets and where they should be published to.
27			*
28			* @var array
29			*/
30			protected $assets = [
31			'public/flare' => 'public/vendor/flare',
32			'public/AdminLTE/dist' => 'public/vendor/flare',
33			'public/AdminLTE/plugins' => 'public/vendor/flare/plugins',
34			'public/AdminLTE/bootstrap' => 'public/vendor/flare/bootstrap',
35			];
36
37			/**
38			* Create a new service provider instance.
39			*
40			* @param \Illuminate\Contracts\Foundation\Application $app
41			*/
42			public function __construct($app)
43			{
44			parent::__construct($app);
45
46			$this->app->singleton('flare', function ($app) {
47			return $app->make(\LaravelFlare\Flare\Flare::class, [$app]);
48			});
49			}
50
51			/**
52			* Perform post-registration booting of services.
53			*/
54			public function boot()
55			{
56			$this->publishAssets();
57			$this->publishConfig();
58			$this->publishMigrations();
59			$this->publishViews();
60			}
61
62			/**
63			* Register any package services.
64			*/
65			public function register()
66			{
67			$this->registerFlareFacade();
68			$this->registerServiceProviders();
69			$this->registerBindings();
70			}
71
72			/**
73			* Register the Flare Facade.
74			*/
75			protected function registerFlareFacade()
76			{
77			AliasLoader::getInstance()->alias('Flare', \LaravelFlare\Flare\Facades\Flare::class);
78			}
79
80			/**
81			* Register Service Providers.
82			*/
83			protected function registerServiceProviders()
84			{
85			foreach ($this->serviceProviders as $class) {
86			$this->app->register($class);
87			}
88			}
89
90			/**
91			* Register the Flare Bindings.
92			*/
93			protected function registerBindings()
94			{
95			$this->app->bind(
96			\LaravelFlare\Flare\Contracts\Permissions\Permissionable::class,
97			\Flare::config('permissions')
98			);
99			}
100
101			/**
102			* Publishes the Flare Assets to the appropriate directories.
103			*/
104			protected function publishAssets()
105			{
106			$assets = [];
107
108			foreach ($this->assets as $location => $asset) {
109			$assets[$this->basePath($location)] = base_path($asset);
			0 ignored issues – show Documentation introduced 2016-02-02 22:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$location` is of type `integer\|string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
110			}
111
112			$this->publishes($assets);
113			}
114
115			/**
116			* Publishes the Flare Config File.
117			*/
118			protected function publishConfig()
119			{
120			$this->publishes([
121			$this->basePath('config/flare/config.php') => config_path('flare/config.php'),
			0 ignored issues – show Documentation introduced 2016-02-02 22:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'config/flare/config.php'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
122			]);
123			}
124
125			/**
126			* Publishes the Flare Database Migrations.
127			*/
128			protected function publishMigrations()
129			{
130			$this->publishes([
131			$this->basePath('Flare/Database/Migrations') => base_path('database/migrations'),
			0 ignored issues – show Documentation introduced 2016-02-02 22:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'Flare/Database/Migrations'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
132			]);
133			}
134
135			/**
136			* Publishes the Flare Views and defines the location
137			* they should be looked for in the application.
138			*/
139			protected function publishViews()
140			{
141			$this->loadViewsFrom($this->basePath('resources/views'), 'flare');
			0 ignored issues – show Documentation introduced 2016-02-02 22:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'resources/views'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
142			$this->publishes([
143			$this->basePath('resources/views') => base_path('resources/views/vendor/flare'),
			0 ignored issues – show Documentation introduced 2016-02-02 22:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'resources/views'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
144			]);
145			}
146
147			/**
148			* Returns the path to a provided file within the Flare package.
149			*
150			* @param bool $fiepath
			0 ignored issues – show Documentation introduced 2016-02-02 22:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$fiepath`. Did you maybe mean `$filepath`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
151			*
152			* @return string
153			*/
154			private function basePath($filepath = false)
155			{
156			return __DIR__.'/../'.$filepath;
157			}
158			}
159

GitHub Access Token became invalid

Issues (76)

Security Analysis not enabled

src/Flare/FlareServiceProvider.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

laravelflare / flare

GitHub Access Token became invalid

Issues (76)

Security Analysis not enabled

src/Flare/FlareServiceProvider.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like