ModelSaving::afterSave() - Code Metrics - Inspection of "Large Amound of Refactoring for LTS AND Edge suppo..." - laravelflare/flare - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9e7309...ca86c4 )

by Aden

created 2016-02-25 13:03 UTC

ModelSaving::afterSave() A

↳ Parent: ModelSaving

Complexity

Conditions	4
Paths	3

Size

Total Lines	13
Code Lines	5

Duplication

Lines	3
Ratio	23.08 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	3
loc	13
rs	9.2
cc	4
eloc	5
nc	3
nop	0

<?php

namespace LaravelFlare\Flare\Admin\Models\Traits;

use LaravelFlare\Flare\Events\ModelSave;
use LaravelFlare\Flare\Events\AfterSave;
use LaravelFlare\Flare\Events\BeforeSave;
use LaravelFlare\Flare\Exceptions\ModelAdminWriteableException as WriteableException;

trait ModelSaving
{
    /**
     * Relations to Update during Save and
     * the appropriate method to fire the update with.
     * 
     * @var array
     */
    protected $doSaveRelations = ['BelongsTo' => 'associate'];

    /**
     * Relations to Update after Save and
     * the appropriate method to fire the update with.
     * 
     * @var array
     */
    protected $afterSaveRelations = ['BelongsToMany' => 'sync'];

    /**
     * Method fired before the Save action is undertaken.
     * 
     * @return
     */
    protected function beforeSave()
    {
    }

    /**
     * Save Action.
     *
     * Fires off beforeSave(), doSave() and afterSave()
     * 
     * @return
     */
    public function save()
    {
        event(new BeforeSave($this));

        $this->beforeSave();

        $this->doSave();

        $this->afterSave();

        event(new AfterSave($this));
    }

    /**
     * The actual Save action, which does all of hte pre-processing
     * required before we are able to perform the save() function.
     * 
     * @return
     */
    private function doSave()
    {
        foreach (\Request::only(array_keys($this->fields->toArray())) as $key => $value) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            if ($this->hasSetMutator($key)) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                $this->setAttribute($key, $value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                continue;
            }

            // Could swap this out for model -> getAttribute, then check if we have an attribute or a relation... getRelationValue() is helpful
            if (method_exists($this->model, $key) && is_a(call_user_func_array([$this->model, $key], []), 'Illuminate\Database\Eloquent\Relations\Relation')) {

                $this->saveRelation('doSave', $key, $value);
                continue;
            }

            $this->model->setAttribute($key, $value);
        }

        $this->model->save();

        event(new ModelSave($this));
    }

    /**
     * Method fired after the Save action is complete.
     * 
     * @return
     */
    protected function afterSave()
    {
        $this->brokenAfterSave = false;
class MyClass { }

$x = new MyClass();
$x->foo = true;

        foreach (\Request::except('_token') as $key => $value) {

            // Could swap this out for model -> getAttribute, then check if we have an attribute or a relation... getRelationValue() is helpful
            if (method_exists($this->model, $key) && is_a(call_user_func_array([$this->model, $key], []), 'Illuminate\Database\Eloquent\Relations\Relation')) {

                $this->saveRelation('afterSave', $key, $value);
            }
        }

    }

    /**
     * Method fired to Save Relations.
     *
     * @param string $action The current action (either doSave or afterSave)
     * @param string $key
     * @param string $value
     * 
     * @return
     */
    private function saveRelation($action, $key, $value)
    {
        // Could swap this out for model -> getAttribute, then check if we have an attribute or a relation... getRelationValue() is helpful
        if (method_exists($this->model, $key) && is_a(call_user_func_array([$this->model, $key], []), 'Illuminate\Database\Eloquent\Relations\Relation')) {
            foreach ($this->{$action.'Relations'} as $relationship => $method) {
                if (is_a(call_user_func_array([$this->model, $key], []), 'Illuminate\Database\Eloquent\Relations\\'.$relationship)) {
                    $this->model->$key()->$method($value);

                    return;
                }
            }
        }
    }
}


1		<?php
2
3		namespace LaravelFlare\Flare\Admin\Models\Traits;
4
5		use LaravelFlare\Flare\Events\ModelSave;
6		use LaravelFlare\Flare\Events\AfterSave;
7		use LaravelFlare\Flare\Events\BeforeSave;
8		use LaravelFlare\Flare\Exceptions\ModelAdminWriteableException as WriteableException;
9
10		trait ModelSaving
11		{
12		/**
13		* Relations to Update during Save and
14		* the appropriate method to fire the update with.
15		*
16		* @var array
17		*/
18		protected $doSaveRelations = ['BelongsTo' => 'associate'];
19
20		/**
21		* Relations to Update after Save and
22		* the appropriate method to fire the update with.
23		*
24		* @var array
25		*/
26		protected $afterSaveRelations = ['BelongsToMany' => 'sync'];
27
28		/**
29		* Method fired before the Save action is undertaken.
30		*
31		* @return
32		*/
33		protected function beforeSave()
34		{
35		}
36
37		/**
38		* Save Action.
39		*
40		* Fires off beforeSave(), doSave() and afterSave()
41		*
42		* @return
43		*/
44		public function save()
45		{
46		event(new BeforeSave($this));
47
48		$this->beforeSave();
49
50		$this->doSave();
51
52		$this->afterSave();
53
54		event(new AfterSave($this));
55		}
56
57		/**
58		* The actual Save action, which does all of hte pre-processing
59		* required before we are able to perform the save() function.
60		*
61		* @return
62		*/
63		private function doSave()
64		{
65		foreach (\Request::only(array_keys($this->fields->toArray())) as $key => $value) {
		0 ignored issues – show Bug introduced 2015-11-29 15:51 UTC by Report Bug Copy Issue Report The property `fields` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
66		if ($this->hasSetMutator($key)) {
		0 ignored issues – show Bug introduced 2016-02-09 11:48 UTC by Report Bug Copy Issue Report It seems like `hasSetMutator()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
67		$this->setAttribute($key, $value);
		0 ignored issues – show Bug introduced 2016-02-09 11:48 UTC by Report Bug Copy Issue Report It seems like `setAttribute()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
68		continue;
69		}
70
71		// Could swap this out for model -> getAttribute, then check if we have an attribute or a relation... getRelationValue() is helpful
72	View Code Duplication	if (method_exists($this->model, $key) && is_a(call_user_func_array([$this->model, $key], []), 'Illuminate\Database\Eloquent\Relations\Relation')) {
		0 ignored issues – show Duplication introduced 2016-02-25 13:43 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
73		$this->saveRelation('doSave', $key, $value);
74		continue;
75		}
76
77		$this->model->setAttribute($key, $value);
78		}
79
80		$this->model->save();
81
82		event(new ModelSave($this));
83		}
84
85		/**
86		* Method fired after the Save action is complete.
87		*
88		* @return
89		*/
90		protected function afterSave()
91		{
92		$this->brokenAfterSave = false;
		0 ignored issues – show Bug introduced 2016-02-24 11:44 UTC by Report Bug Copy Issue Report The property `brokenAfterSave` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
93
94		foreach (\Request::except('_token') as $key => $value) {
95
96		// Could swap this out for model -> getAttribute, then check if we have an attribute or a relation... getRelationValue() is helpful
97	View Code Duplication	if (method_exists($this->model, $key) && is_a(call_user_func_array([$this->model, $key], []), 'Illuminate\Database\Eloquent\Relations\Relation')) {
		0 ignored issues – show Duplication introduced 2016-02-25 13:43 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
98		$this->saveRelation('afterSave', $key, $value);
99		}
100		}
101
102		}
103
104		/**
105		* Method fired to Save Relations.
106		*
107		* @param string $action The current action (either doSave or afterSave)
108		* @param string $key
109		* @param string $value
110		*
111		* @return
112		*/
113		private function saveRelation($action, $key, $value)
114		{
115		// Could swap this out for model -> getAttribute, then check if we have an attribute or a relation... getRelationValue() is helpful
116		if (method_exists($this->model, $key) && is_a(call_user_func_array([$this->model, $key], []), 'Illuminate\Database\Eloquent\Relations\Relation')) {
117		foreach ($this->{$action.'Relations'} as $relationship => $method) {
118		if (is_a(call_user_func_array([$this->model, $key], []), 'Illuminate\Database\Eloquent\Relations\\'.$relationship)) {
119		$this->model->$key()->$method($value);
120
121		return;
122		}
123		}
124		}
125		}
126		}
127

laravelflare / flare

GitHub Access Token became invalid

Push — master ( 9e7309...ca86c4 )

ModelSaving::afterSave() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like