Permissions::check() - Code Metrics - Inspection of "Improvements to CheckPermissioins" - laravelflare/flare - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 53e94c...ee1db5 )

by Aden

created 2016-02-01 09:47 UTC

Permissions::check() A

↳ Parent: Permissions

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
c	4
b	0
f	0
dl	0
loc	12
rs	9.4285
cc	3
eloc	6
nc	3
nop	2

<?php

namespace LaravelFlare\Flare\Permissions;

use LaravelFlare\Flare\Contracts\Permissions\Permissionable;

class Permissions implements Permissionable
{
    /**
     * Checks if the currently Authenticated User
     * has access to a given action.
     *
     * @param string $class
     * @param string $action
     * 
     * @return
     */
    public static function check($class = null, $action = 'view')
    {
        if (!$class) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return \Auth::user()->is_admin;
        }

        if ((new \ReflectionClass(new $class()))->implementsInterface(\LaravelFlare\Flare\Contracts\Permissions\Permissionable::class)) {
            return \Auth::user()->can($action, $class);
        }

        return \Auth::user()->is_admin;
    }

    /**
     * Method called when a User attempts to access
     * an area of the site or admin which they do 
     * not have the permissions to interact with.
     *
     * This is typically called from the CheckPermissions
     * Middleware during a request (see: \LaravelFlare\Flare\Http\Middleware\CheckPermissions::handle())
     * and can be used to throw an exception, return a 
     * view (abort() etc.) or anything else really.
     * 
     * @param  string $class 
     * @param  string $action
     * 
     * @return [type]        

     */
    public static function denied($class = null, $action = 'view')

    {
        throw new PermissionsException('Permission denied!');
    }
}


1			<?php
2
3			namespace LaravelFlare\Flare\Permissions;
4
5			use LaravelFlare\Flare\Contracts\Permissions\Permissionable;
6
7			class Permissions implements Permissionable
8			{
9			/**
10			* Checks if the currently Authenticated User
11			* has access to a given action.
12			*
13			* @param string $class
14			* @param string $action
15			*
16			* @return
17			*/
18			public static function check($class = null, $action = 'view')
19			{
20			if (!$class) {
			0 ignored issues – show Bug Best Practice introduced 2015-12-12 13:53 UTC by Report Bug Copy Issue Report The expression `$class` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
21			return \Auth::user()->is_admin;
22			}
23
24			if ((new \ReflectionClass(new $class()))->implementsInterface(\LaravelFlare\Flare\Contracts\Permissions\Permissionable::class)) {
25			return \Auth::user()->can($action, $class);
26			}
27
28			return \Auth::user()->is_admin;
29			}
30
31			/**
32			* Method called when a User attempts to access
33			* an area of the site or admin which they do
34			* not have the permissions to interact with.
35			*
36			* This is typically called from the CheckPermissions
37			* Middleware during a request (see: \LaravelFlare\Flare\Http\Middleware\CheckPermissions::handle())
38			* and can be used to throw an exception, return a
39			* view (abort() etc.) or anything else really.
40			*
41			* @param string $class
42			* @param string $action
43			*
44			* @return [type]
			0 ignored issues – show Documentation introduced 2016-02-01 10:07 UTC by Report Bug Copy Issue Report The doc-type `[type]` could not be parsed: Unknown type name "" at position 0. [(view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
45			*/
46			public static function denied($class = null, $action = 'view')
			0 ignored issues – show Unused Code introduced 2016-02-01 10:07 UTC by Report Bug Copy Issue Report The parameter `$class` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-02-01 10:07 UTC by Report Bug Copy Issue Report The parameter `$action` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
47			{
48			throw new PermissionsException('Permission denied!');
49			}
50			}
51

laravelflare / flare

GitHub Access Token became invalid

Push — master ( 53e94c...ee1db5 )

Permissions::check() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like