AttributeCollection::formatInnerField() - Code Metrics - Inspection of "Move AttributeColllection to ModelAdmin Namespace" - laravelflare/flare - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 978098...4d47d7 )

by Aden

created 2016-02-19 11:54 UTC

AttributeCollection::formatInnerField() C

↳ Parent: AttributeCollection

Complexity

Conditions	12
Paths	8

Size

Total Lines	36
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	36
rs	5.1612
cc	12
eloc	19
nc	8
nop	2

How to fix Complexity

<?php

namespace LaravelFlare\Flare\Admin\ModelAdmin;

use Illuminate\Support\Collection;
use LaravelFlare\Fields\FieldManager;
use LaravelFlare\Fields\Types\BaseField;

class AttributeCollection extends Collection
{
    /**
     * The items contained in the collection.
     *
     * @var array
     */
    protected $items = [];

    /**
     * Field Manager Instance
     * 
     * @var \LaravelFlare\Fields\FieldManager
     */
    protected $fields;

    /**
     * ModelAdmin which contains this Attribute Collection.
     * 
     * @var \LaravelFlare\Flare\Admin\Models\ModelAdmin
     */
    protected $modelManager;

    /**
     * Create a new collection.
     *
     * @param  mixed  $items
     * 
     * @return void

     */
    public function __construct($items = [], $modelManager = null)
    {
        $this->fields = \App::make(FieldManager::class);
        $this->items = $items;

        $this->modelManager = $modelManager;

        $this->formatFields();
    }

    /**
     * Attempt to reformat the current attribute items array
     * into the most usable format (an Attribute Collection).
     * 
     * @return void
     */
    public function formatFields()
    {
        $items = $this->items;
        $formattedItems = [];

        foreach ($items as $name => $inner) {
            $formattedItems[$name] = $this->formatInnerField($name, $inner);
        }

        $this->items = $formattedItems;

        return $this;
    }

    /**
     * Allows adding fields to the Attribute Collection 
     * 
     * @param array $items
     */
    public function add($items = [])
    {
        if (!is_array($items) || func_num_args() > 1) {
            $items = func_get_args();
        }

        $this->push($this->formatInnerField(null, $items));
    }

    /**
     * Format an Inner Field which can either be in the format
     * of an Array, an instance of BaseAttribute or even an
     * AttributeCollection object (which contains more!).
     *
     * @param  mixed $name
     * @param  mixed  $inner 
     * 
     * @return mixed
     */
    protected function formatInnerField($name = null, $inner = [])
    {
        if ($inner instanceof BaseField) {
            return $inner;
        }

        if ($inner instanceof AttributeCollection) {
            $formattedItems = [];

            foreach ($inner->toArray() as $name => $inner) {
                $formattedItems[$name] = $this->formatInnerField($inner);
            }

            return $formattedItems;
        }

        if (is_scalar($inner) && $this->attributeManager->attributeTypeExists($inner)) {
            return $this->attributeManager->createAttribute($inner, $name, [], $this->modelManager);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        if (is_array($inner) && array_key_exists('type', $inner) && is_scalar($inner['type']) && $this->attributeManager->attributeTypeExists($inner['type'])) {
            $type = $inner['type'];
            array_forget($inner, 'type');
            return $this->attributeManager->createAttribute($type, $name, $inner, $this->modelManager);
        }

        if (is_array($inner)) {
            $formattedItems = [];

            foreach ($inner as $name => $inner) {
                $formattedItems[$name] = $this->formatInnerField($inner);
            }

            return $formattedItems;
        }
    }
}


1			<?php
2
3			namespace LaravelFlare\Flare\Admin\ModelAdmin;
4
5			use Illuminate\Support\Collection;
6			use LaravelFlare\Fields\FieldManager;
7			use LaravelFlare\Fields\Types\BaseField;
8
9			class AttributeCollection extends Collection
10			{
11			/**
12			* The items contained in the collection.
13			*
14			* @var array
15			*/
16			protected $items = [];
17
18			/**
19			* Field Manager Instance
20			*
21			* @var \LaravelFlare\Fields\FieldManager
22			*/
23			protected $fields;
24
25			/**
26			* ModelAdmin which contains this Attribute Collection.
27			*
28			* @var \LaravelFlare\Flare\Admin\Models\ModelAdmin
29			*/
30			protected $modelManager;
31
32			/**
33			* Create a new collection.
34			*
35			* @param mixed $items
36			*
37			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-02-19 11:56 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
38			*/
39			public function __construct($items = [], $modelManager = null)
40			{
41			$this->fields = \App::make(FieldManager::class);
42			$this->items = $items;
			0 ignored issues – show Documentation Bug introduced 2016-02-10 10:17 UTC by Report Bug Copy Issue Report It seems like `$items` of type `*` is incompatible with the declared type `array` of property `$items`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
43			$this->modelManager = $modelManager;
44
45			$this->formatFields();
46			}
47
48			/**
49			* Attempt to reformat the current attribute items array
50			* into the most usable format (an Attribute Collection).
51			*
52			* @return void
53			*/
54			public function formatFields()
55			{
56			$items = $this->items;
57			$formattedItems = [];
58
59			foreach ($items as $name => $inner) {
60			$formattedItems[$name] = $this->formatInnerField($name, $inner);
61			}
62
63			$this->items = $formattedItems;
64
65			return $this;
66			}
67
68			/**
69			* Allows adding fields to the Attribute Collection
70			*
71			* @param array $items
72			*/
73			public function add($items = [])
74			{
75			if (!is_array($items) \|\| func_num_args() > 1) {
76			$items = func_get_args();
77			}
78
79			$this->push($this->formatInnerField(null, $items));
80			}
81
82			/**
83			* Format an Inner Field which can either be in the format
84			* of an Array, an instance of BaseAttribute or even an
85			* AttributeCollection object (which contains more!).
86			*
87			* @param mixed $name
88			* @param mixed $inner
89			*
90			* @return mixed
91			*/
92			protected function formatInnerField($name = null, $inner = [])
93			{
94			if ($inner instanceof BaseField) {
95			return $inner;
96			}
97
98			if ($inner instanceof AttributeCollection) {
99			$formattedItems = [];
100
101			foreach ($inner->toArray() as $name => $inner) {
102			$formattedItems[$name] = $this->formatInnerField($inner);
103			}
104
105			return $formattedItems;
106			}
107
108			if (is_scalar($inner) && $this->attributeManager->attributeTypeExists($inner)) {
109			return $this->attributeManager->createAttribute($inner, $name, [], $this->modelManager);
			0 ignored issues – show Bug introduced 2016-02-19 11:50 UTC by Report Bug Copy Issue Report The property `attributeManager` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
110			}
111
112			if (is_array($inner) && array_key_exists('type', $inner) && is_scalar($inner['type']) && $this->attributeManager->attributeTypeExists($inner['type'])) {
113			$type = $inner['type'];
114			array_forget($inner, 'type');
115			return $this->attributeManager->createAttribute($type, $name, $inner, $this->modelManager);
116			}
117
118			if (is_array($inner)) {
119			$formattedItems = [];
120
121			foreach ($inner as $name => $inner) {
122			$formattedItems[$name] = $this->formatInnerField($inner);
123			}
124
125			return $formattedItems;
126			}
127			}
128			}
129

GitHub Access Token became invalid

Push — master ( 978098...4d47d7 )

AttributeCollection::formatInnerField() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

laravelflare / flare

GitHub Access Token became invalid

Push — master ( 978098...4d47d7 )

AttributeCollection::formatInnerField() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like