Complex classes like ModelAdmin often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ModelAdmin, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 12 | class ModelAdmin extends Admin implements ModelQueryable |
||
| 13 | { |
||
| 14 | use ModelQuerying; |
||
| 15 | use ModelSaving; |
||
| 16 | |||
| 17 | /** |
||
| 18 | * Class of Model to Manage. |
||
| 19 | * |
||
| 20 | * @var string |
||
| 21 | */ |
||
| 22 | protected $managedModel; |
||
| 23 | |||
| 24 | /** |
||
| 25 | * Entiy Title . |
||
| 26 | * |
||
| 27 | * @var string |
||
| 28 | */ |
||
| 29 | protected $entityTitle; |
||
| 30 | |||
| 31 | /** |
||
| 32 | * Plural Entity Title. |
||
| 33 | * |
||
| 34 | * @var string |
||
| 35 | */ |
||
| 36 | protected $pluralEntityTitle; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * Validation Rules for onCreate, onEdit actions. |
||
| 40 | * |
||
| 41 | * @var array |
||
| 42 | */ |
||
| 43 | protected $rules = []; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * Columns for Model. |
||
| 47 | * |
||
| 48 | * Defines which fields to show in the listing tables output. |
||
| 49 | * |
||
| 50 | * @var array |
||
| 51 | */ |
||
| 52 | protected $columns = []; |
||
| 53 | |||
| 54 | /** |
||
| 55 | * Map Model Attributes to FieldTypes with |
||
| 56 | * additional parameters which will be output |
||
| 57 | * as fields when viewing, editing or adding |
||
| 58 | * a new model entry. |
||
| 59 | * |
||
| 60 | * @var array |
||
| 61 | */ |
||
| 62 | protected $fields = []; |
||
| 63 | |||
| 64 | /** |
||
| 65 | * Columns for Model are Sortable. |
||
| 66 | * |
||
| 67 | * @var bool |
||
| 68 | */ |
||
| 69 | protected $sortable = true; |
||
| 70 | |||
| 71 | /** |
||
| 72 | * The Controller to be used by the Model Admin. |
||
| 73 | * |
||
| 74 | * This defaults to parent::getController() |
||
| 75 | * if it has been left undefined. |
||
| 76 | * |
||
| 77 | * @var string |
||
| 78 | */ |
||
| 79 | protected $controller = '\LaravelFlare\Flare\Admin\Models\ModelAdminController'; |
||
| 80 | |||
| 81 | /** |
||
| 82 | * The Policy used for the Model Authorization logic. |
||
| 83 | * |
||
| 84 | * This class should implement the ModelAdminPoliceable which |
||
| 85 | * includes authorization checks for the create, view, edit and delete actions. |
||
| 86 | * |
||
| 87 | * @var string |
||
| 88 | */ |
||
| 89 | protected $policy = '\LaravelFlare\Flare\Permissions\ModelAdminPolicy'; |
||
| 90 | |||
| 91 | /** |
||
| 92 | * The current model to be managed. |
||
| 93 | * |
||
| 94 | * @var Model |
||
| 95 | */ |
||
| 96 | public $model; |
||
| 97 | |||
| 98 | /** |
||
| 99 | * __construct. |
||
| 100 | */ |
||
| 101 | public function __construct() |
||
| 107 | |||
| 108 | /** |
||
| 109 | * Returns a Model Instance. |
||
| 110 | * |
||
| 111 | * @return Model |
||
| 112 | */ |
||
| 113 | public function model() |
||
| 123 | |||
| 124 | /** |
||
| 125 | * Returns a New Model Instance. |
||
| 126 | * |
||
| 127 | * @return Model |
||
| 128 | */ |
||
| 129 | public function newModel() |
||
| 135 | |||
| 136 | /** |
||
| 137 | * Returns the Managed Model Class. |
||
| 138 | * |
||
| 139 | * @return string |
||
| 140 | */ |
||
| 141 | public function getManagedModel() |
||
| 149 | |||
| 150 | /** |
||
| 151 | * Set the Managed Model Class. |
||
| 152 | * |
||
| 153 | * @param string $managedModel |
||
| 154 | */ |
||
| 155 | public function setManagedModel($managedModel = null) |
||
| 159 | |||
| 160 | /** |
||
| 161 | * Get the Entity Title. |
||
| 162 | * |
||
| 163 | * @return string |
||
| 164 | */ |
||
| 165 | public function getEntityTitle() |
||
| 173 | |||
| 174 | /** |
||
| 175 | * Set Entity Title. |
||
| 176 | * |
||
| 177 | * @param string $entityTitle |
||
| 178 | */ |
||
| 179 | public function setTitle($entityTitle = null) |
||
| 183 | |||
| 184 | /** |
||
| 185 | * Plural Entity Title |
||
| 186 | * |
||
| 187 | * @return string |
||
| 188 | */ |
||
| 189 | public function getPluralEntityTitle() |
||
| 197 | |||
| 198 | /** |
||
| 199 | * Set Plural Title. |
||
| 200 | * |
||
| 201 | * @param string $pluralEntityTitle |
||
| 202 | */ |
||
| 203 | public function setPluralTitle($pluralEntityTitle = null) |
||
| 207 | |||
| 208 | |||
| 209 | /** |
||
| 210 | * Returns the Route Paramets. |
||
| 211 | * |
||
| 212 | * @return array |
||
| 213 | */ |
||
| 214 | public function routeParameters() |
||
| 215 | { |
||
| 216 | return array_merge(parent::routeParameters(), [ |
||
| 217 | 'model' => $this->managedModel, |
||
| 218 | ]); |
||
| 219 | } |
||
| 220 | |||
| 221 | /** |
||
| 222 | * Formats and returns the Columns. |
||
| 223 | * |
||
| 224 | * This is really gross, I'm removing it soon. |
||
| 225 | * |
||
| 226 | * @return |
||
| 227 | */ |
||
| 228 | public function getColumns() |
||
| 269 | |||
| 270 | /** |
||
| 271 | * Return the Validation Rules |
||
| 272 | * |
||
| 273 | * @return array |
||
| 274 | */ |
||
| 275 | public function getRules() |
||
| 279 | |||
| 280 | /** |
||
| 281 | * Return the Create Model Entry Validation Rules |
||
| 282 | * |
||
| 283 | * @return array |
||
| 284 | */ |
||
| 285 | public function getCreateRules() |
||
| 289 | |||
| 290 | /** |
||
| 291 | * Return the Update Model Entry Validation Rules |
||
| 292 | * |
||
| 293 | * @return array |
||
| 294 | */ |
||
| 295 | public function getUpdateRules() |
||
| 299 | |||
| 300 | /** |
||
| 301 | * Gets an Attribute by the provided key |
||
| 302 | * on either the current model or a provided model instance. |
||
| 303 | * |
||
| 304 | * @param string $key |
||
| 305 | * @param mixed $model |
||
| 306 | * |
||
| 307 | * @return mixed |
||
| 308 | */ |
||
| 309 | public function getAttribute($key, $model = false) |
||
| 331 | |||
| 332 | /** |
||
| 333 | * Determine if a get accessor exists for an attribute. |
||
| 334 | * |
||
| 335 | * @param string $key |
||
| 336 | * |
||
| 337 | * @return bool |
||
| 338 | */ |
||
| 339 | public function hasGetAccessor($key) |
||
| 340 | { |
||
| 341 | return method_exists($this, 'get'.Str::studly($key).'Attribute'); |
||
| 342 | } |
||
| 343 | |||
| 344 | /** |
||
| 345 | * Determines if a key resolved a related Model. |
||
| 346 | * |
||
| 347 | * @param string $key |
||
| 348 | * @param mixed $model |
||
| 349 | * |
||
| 350 | * @return bool |
||
| 351 | */ |
||
| 352 | public function hasRelatedKey($key, $model = false) |
||
| 353 | { |
||
| 354 | if (!$model) { |
||
| 355 | $model = $this->model; |
||
| 356 | } |
||
| 357 | |||
| 358 | if (($methodBreaker = strpos($key, '.')) !== false) { |
||
| 359 | $method = substr($key, 0, $methodBreaker); |
||
| 360 | if (method_exists($model, $method)) { |
||
| 361 | return true; |
||
| 362 | } |
||
| 363 | } |
||
| 364 | |||
| 365 | return false; |
||
| 366 | } |
||
| 367 | |||
| 368 | /** |
||
| 369 | * Resolves a relation based on the key provided, |
||
| 370 | * either on the current model or a provided model instance. |
||
| 371 | * |
||
| 372 | * @param string $key |
||
| 373 | * @param mixed $model |
||
| 374 | * |
||
| 375 | * @return mixed |
||
| 376 | */ |
||
| 377 | public function relatedKey($key, $model = false) |
||
| 378 | { |
||
| 379 | if (!$model) { |
||
| 380 | $model = $this->model; |
||
| 381 | } |
||
| 382 | |||
| 383 | if (($methodBreaker = strpos($key, '.')) !== false) { |
||
| 384 | $method = substr($key, 0, $methodBreaker); |
||
| 385 | if (method_exists($model, $method)) { |
||
| 386 | if (method_exists($model->$method, $submethod = str_replace($method.'.', '', $key))) { |
||
| 387 | return $model->$method->$submethod(); |
||
| 388 | } |
||
| 389 | |||
| 390 | if (isset($model->$method->$submethod)) { |
||
| 391 | return $model->$method->$submethod; |
||
| 392 | } |
||
| 393 | |||
| 394 | return $model->getRelationValue($method); |
||
| 395 | } |
||
| 396 | } |
||
| 397 | |||
| 398 | return false; |
||
| 399 | } |
||
| 400 | |||
| 401 | /** |
||
| 402 | * Set a given attribute on the model. |
||
| 403 | * |
||
| 404 | * @param string $key |
||
| 405 | * @param mixed $value |
||
| 406 | */ |
||
| 407 | public function setAttribute($key, $value) |
||
| 417 | |||
| 418 | /** |
||
| 419 | * Determine if a set mutator exists for an attribute. |
||
| 420 | * |
||
| 421 | * @param string $key |
||
| 422 | * |
||
| 423 | * @return bool |
||
| 424 | */ |
||
| 425 | public function hasSetMutator($key) |
||
| 429 | |||
| 430 | /** |
||
| 431 | * Determine if a get mutator exists for an attribute. |
||
| 432 | * |
||
| 433 | * @param string $key |
||
| 434 | * |
||
| 435 | * @return bool |
||
| 436 | */ |
||
| 437 | public function hasGetMutator($key) |
||
| 441 | |||
| 442 | /** |
||
| 443 | * Returns an array of Attribute Fields ready for output. |
||
| 444 | * |
||
| 445 | * @return array |
||
| 446 | */ |
||
| 447 | public function outputFields() |
||
| 451 | |||
| 452 | /** |
||
| 453 | * Gets the Managed Model Mapping. |
||
| 454 | * |
||
| 455 | * @return array |
||
| 456 | */ |
||
| 457 | public function getFields() |
||
| 463 | |||
| 464 | /** |
||
| 465 | * Sets the Managed Model Mapping. |
||
| 466 | * |
||
| 467 | * @param array $fields |
||
| 468 | */ |
||
| 469 | public function setFields($fields = []) |
||
| 475 | |||
| 476 | /** |
||
| 477 | * Format the provided Attribute Fields into a more usable format. |
||
| 478 | */ |
||
| 479 | protected function formatFields() |
||
| 489 | |||
| 490 | /** |
||
| 491 | * Determine if the Model Admin is sortable in it's list view. |
||
| 492 | * |
||
| 493 | * @return bool |
||
| 494 | */ |
||
| 495 | public function isSortable() |
||
| 499 | |||
| 500 | /** |
||
| 501 | * Determine if the Model Admin is sortable by a defined key / column. |
||
| 502 | * |
||
| 503 | * @param string $key |
||
| 504 | * |
||
| 505 | * @return bool |
||
| 506 | */ |
||
| 507 | public function isSortableBy($key) |
||
| 526 | |||
| 527 | /** |
||
| 528 | * Determine if the Model Admin has Viewing Capabilities. |
||
| 529 | * |
||
| 530 | * @return bool |
||
| 531 | */ |
||
| 532 | public function hasViewing() |
||
| 536 | |||
| 537 | /** |
||
| 538 | * Determine if the Model Admin has Creating Capabilities. |
||
| 539 | * |
||
| 540 | * @return bool |
||
| 541 | */ |
||
| 542 | public function hasCreating() |
||
| 546 | |||
| 547 | /** |
||
| 548 | * Determine if the Model Admin has Cloning Capabilities. |
||
| 549 | * |
||
| 550 | * @return bool |
||
| 551 | */ |
||
| 552 | public function hasCloning() |
||
| 556 | |||
| 557 | /** |
||
| 558 | * Determine if the Model Admin has Editing Capabilities. |
||
| 559 | * |
||
| 560 | * @return bool |
||
| 561 | */ |
||
| 562 | public function hasEditing() |
||
| 563 | { |
||
| 564 | return $this->hasTrait(\LaravelFlare\Flare\Admin\Models\Traits\ModelEditing::class); |
||
| 565 | } |
||
| 566 | |||
| 567 | /** |
||
| 568 | * Determine if the Model Admin has Deleting Capabilities. |
||
| 569 | * |
||
| 570 | * @return bool |
||
| 571 | */ |
||
| 572 | public function hasDeleting() |
||
| 576 | |||
| 577 | /** |
||
| 578 | * Determine if the Managed Model is using the SoftDeletes Trait. |
||
| 579 | * |
||
| 580 | * This is guarded by hasDeleting, since we shouldn't allow SoftDeleting |
||
| 581 | * without the deleting trait (even though it isn't really required). |
||
| 582 | * |
||
| 583 | * @return bool |
||
| 584 | */ |
||
| 585 | public function hasSoftDeleting() |
||
| 586 | { |
||
| 587 | if (!$this->hasDeleting()) { |
||
| 588 | return false; |
||
| 589 | } |
||
| 590 | |||
| 591 | $managedModelClass = $this->getManagedModel(); |
||
| 592 | |||
| 593 | return in_array( |
||
| 594 | \Illuminate\Database\Eloquent\SoftDeletes::class, class_uses_recursive(get_class(new $managedModelClass())) |
||
| 595 | ) && in_array( |
||
| 596 | \LaravelFlare\Flare\Admin\Models\Traits\ModelSoftDeleting::class, class_uses_recursive(get_class($this)) |
||
| 597 | ); |
||
| 598 | } |
||
| 599 | |||
| 600 | /** |
||
| 601 | * Determine if the Model Admin has Validating Capabilities. |
||
| 602 | * |
||
| 603 | * @return bool |
||
| 604 | */ |
||
| 605 | public function hasValidating() |
||
| 609 | |||
| 610 | /** |
||
| 611 | * Determine if the Managed Model has a Trait and Contract. |
||
| 612 | * |
||
| 613 | * @return bool |
||
| 614 | */ |
||
| 615 | public function hasTraitAndContract($trait = null, $contract = null) |
||
| 619 | |||
| 620 | /** |
||
| 621 | * Returns whether the current ModelAdmin has a given trait. |
||
| 622 | * |
||
| 623 | * @param string $trait |
||
| 624 | * |
||
| 625 | * @return bool |
||
| 626 | */ |
||
| 627 | public function hasTrait($trait = null) |
||
| 635 | |||
| 636 | /** |
||
| 637 | * Returns whether the current ModelAdmin has a given contract. |
||
| 638 | * |
||
| 639 | * @param string $contract |
||
| 640 | * |
||
| 641 | * @return bool |
||
| 642 | */ |
||
| 643 | public function hasContract($contract = null) |
||
| 651 | } |
||
| 652 |
This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug.