FlareServiceProvider::__construct() - Code Metrics - Inspection of "Fixes" - laravelflare/flare - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dbefab...228eac )

by Aden

created 2016-02-19 13:51 UTC

FlareServiceProvider::__construct() A

↳ Parent: FlareServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	8
rs	9.4285
cc	1
eloc	4
nc	1
nop	1

<?php

namespace LaravelFlare\Flare;

use Illuminate\Foundation\AliasLoader;
use Illuminate\Support\ServiceProvider;

class FlareServiceProvider extends ServiceProvider
{
    /**
     * Array of Flare Service Providers to be Registered.
     * 
     * @var array
     */
    protected $serviceProviders = [
        \LaravelFlare\Flare\Providers\AuthServiceProvider::class,
        \LaravelFlare\Flare\Providers\ArtisanServiceProvider::class,
        \LaravelFlare\Flare\Providers\EventServiceProvider::class,
        \LaravelFlare\Flare\Providers\RouteServiceProvider::class,

        // External Components
        \LaravelFlare\Fields\FieldServiceProvider::class,
    ];

    /**
     * Array of Flare assets and where they should be published to.
     * 
     * @var array
     */
    protected $assets = [
        'public/flare' => 'vendor/flare',
        'public/AdminLTE/dist' => 'vendor/flare',
        'public/AdminLTE/plugins' => 'vendor/flare/plugins',
        'public/AdminLTE/bootstrap' => 'vendor/flare/bootstrap',
    ];

    /**
     * Create a new service provider instance.
     *
     * @param  \Illuminate\Contracts\Foundation\Application  $app
     * @return void

     */
    public function __construct($app)
    {
        parent::__construct($app);

        $this->app->singleton('flare', function ($app) {
            return $app->make(\LaravelFlare\Flare\Flare::class, [$app]);
        });
    }

    /**
     * Perform post-registration booting of services.
     */
    public function boot()
    {
        $this->publishAssets();
        $this->publishConfig();
        $this->publishMigrations();
        $this->publishViews();

        $this->app->bind(
            \LaravelFlare\Flare\Contracts\Permissions\Permissionable::class,
            \Config::get('flare.config.permissions')
        );
    }

    /**
     * Register any package services.
     */
    public function register()
    {
        $this->registerFlareFacade();
        $this->registerServiceProviders();
    }

    /**
     * Register Service Providers.
     */
    protected function registerServiceProviders()
    {
        foreach ($this->serviceProviders as $class) {
            $this->app->register($class);
        }
    }

    /**
     * Register the Flare Facade.
     */
    protected function registerFlareFacade()
    {
        AliasLoader::getInstance()->alias('Flare', \LaravelFlare\Flare\Facades\Flare::class);
    }

    /**
     * Publishes the Flare Assets to the appropriate directories.
     */
    protected function publishAssets()
    {
        $assets = [];

        foreach ($this->assets as $location => $asset) {
            $assets[$this->basePath($location)] = base_path($asset);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        $this->publishes($assets, 'public');
    }

    /**
     * Publishes the Flare Config File.
     */
    protected function publishConfig()
    {
        $this->publishes([
            $this->basePath('config/flare/config.php') => config_path('flare/config.php'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        ]);
    }

    /**
     * Publishes the Flare Database Migrations.
     */
    protected function publishMigrations()
    {
        $this->publishes([
            $this->basePath('Flare/Database/Migrations') => base_path('database/migrations'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        ]);
    }

    /**
     * Publishes the Flare Views and defines the location
     * they should be looked for in the application.
     */
    protected function publishViews()
    {
        $this->loadViewsFrom($this->basePath('resources/views'), 'flare');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->publishes([
            $this->basePath('resources/views') => base_path('resources/views/vendor/flare'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        ]);
    }

    /**
     * Returns the path to a provided file within the Flare package.
     * 
     * @param bool $fiepath
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * 
     * @return string
     */
    private function basePath($filepath = false)
    {
        return __DIR__.'/../'.$filepath;
    }
}


1			<?php
2
3			namespace LaravelFlare\Flare;
4
5			use Illuminate\Foundation\AliasLoader;
6			use Illuminate\Support\ServiceProvider;
7
8			class FlareServiceProvider extends ServiceProvider
9			{
10			/**
11			* Array of Flare Service Providers to be Registered.
12			*
13			* @var array
14			*/
15			protected $serviceProviders = [
16			\LaravelFlare\Flare\Providers\AuthServiceProvider::class,
17			\LaravelFlare\Flare\Providers\ArtisanServiceProvider::class,
18			\LaravelFlare\Flare\Providers\EventServiceProvider::class,
19			\LaravelFlare\Flare\Providers\RouteServiceProvider::class,
20
21			// External Components
22			\LaravelFlare\Fields\FieldServiceProvider::class,
23			];
24
25			/**
26			* Array of Flare assets and where they should be published to.
27			*
28			* @var array
29			*/
30			protected $assets = [
31			'public/flare' => 'vendor/flare',
32			'public/AdminLTE/dist' => 'vendor/flare',
33			'public/AdminLTE/plugins' => 'vendor/flare/plugins',
34			'public/AdminLTE/bootstrap' => 'vendor/flare/bootstrap',
35			];
36
37			/**
38			* Create a new service provider instance.
39			*
40			* @param \Illuminate\Contracts\Foundation\Application $app
41			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-02-19 13:54 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
42			*/
43			public function __construct($app)
44			{
45			parent::__construct($app);
46
47			$this->app->singleton('flare', function ($app) {
48			return $app->make(\LaravelFlare\Flare\Flare::class, [$app]);
49			});
50			}
51
52			/**
53			* Perform post-registration booting of services.
54			*/
55			public function boot()
56			{
57			$this->publishAssets();
58			$this->publishConfig();
59			$this->publishMigrations();
60			$this->publishViews();
61
62			$this->app->bind(
63			\LaravelFlare\Flare\Contracts\Permissions\Permissionable::class,
64			\Config::get('flare.config.permissions')
65			);
66			}
67
68			/**
69			* Register any package services.
70			*/
71			public function register()
72			{
73			$this->registerFlareFacade();
74			$this->registerServiceProviders();
75			}
76
77			/**
78			* Register Service Providers.
79			*/
80			protected function registerServiceProviders()
81			{
82			foreach ($this->serviceProviders as $class) {
83			$this->app->register($class);
84			}
85			}
86
87			/**
88			* Register the Flare Facade.
89			*/
90			protected function registerFlareFacade()
91			{
92			AliasLoader::getInstance()->alias('Flare', \LaravelFlare\Flare\Facades\Flare::class);
93			}
94
95			/**
96			* Publishes the Flare Assets to the appropriate directories.
97			*/
98			protected function publishAssets()
99			{
100			$assets = [];
101
102			foreach ($this->assets as $location => $asset) {
103			$assets[$this->basePath($location)] = base_path($asset);
			0 ignored issues – show Documentation introduced 2016-02-02 22:13 UTC by Report Bug Copy Issue Report `$location` is of type `integer\|string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
104			}
105
106			$this->publishes($assets, 'public');
107			}
108
109			/**
110			* Publishes the Flare Config File.
111			*/
112			protected function publishConfig()
113			{
114			$this->publishes([
115			$this->basePath('config/flare/config.php') => config_path('flare/config.php'),
			0 ignored issues – show Documentation introduced 2016-02-02 22:13 UTC by Report Bug Copy Issue Report `'config/flare/config.php'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
116			]);
117			}
118
119			/**
120			* Publishes the Flare Database Migrations.
121			*/
122			protected function publishMigrations()
123			{
124			$this->publishes([
125			$this->basePath('Flare/Database/Migrations') => base_path('database/migrations'),
			0 ignored issues – show Documentation introduced 2016-02-02 22:13 UTC by Report Bug Copy Issue Report `'Flare/Database/Migrations'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
126			]);
127			}
128
129			/**
130			* Publishes the Flare Views and defines the location
131			* they should be looked for in the application.
132			*/
133			protected function publishViews()
134			{
135			$this->loadViewsFrom($this->basePath('resources/views'), 'flare');
			0 ignored issues – show Documentation introduced 2016-02-02 22:13 UTC by Report Bug Copy Issue Report `'resources/views'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
136			$this->publishes([
137			$this->basePath('resources/views') => base_path('resources/views/vendor/flare'),
			0 ignored issues – show Documentation introduced 2016-02-02 22:13 UTC by Report Bug Copy Issue Report `'resources/views'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
138			]);
139			}
140
141			/**
142			* Returns the path to a provided file within the Flare package.
143			*
144			* @param bool $fiepath
			0 ignored issues – show Documentation introduced 2016-02-02 22:13 UTC by Report Bug Copy Issue Report There is no parameter named `$fiepath`. Did you maybe mean `$filepath`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
145			*
146			* @return string
147			*/
148			private function basePath($filepath = false)
149			{
150			return __DIR__.'/../'.$filepath;
151			}
152			}
153

laravelflare / flare

GitHub Access Token became invalid

Push — master ( dbefab...228eac )

FlareServiceProvider::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like