Complex classes like ModelAdmin often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ModelAdmin, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 12 | class ModelAdmin extends Admin implements ModelQueryable |
||
| 13 | { |
||
| 14 | use ModelQuerying; |
||
| 15 | use ModelSaving; |
||
| 16 | |||
| 17 | /** |
||
| 18 | * Class of Model to Manage. |
||
| 19 | * |
||
| 20 | * @var string |
||
| 21 | */ |
||
| 22 | protected $managedModel; |
||
| 23 | |||
| 24 | /** |
||
| 25 | * Entiy Title . |
||
| 26 | * |
||
| 27 | * @var string |
||
| 28 | */ |
||
| 29 | protected $entityTitle; |
||
| 30 | |||
| 31 | /** |
||
| 32 | * Plural Entity Title. |
||
| 33 | * |
||
| 34 | * @var string |
||
| 35 | */ |
||
| 36 | protected $pluralEntityTitle; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * Validation Rules for onCreate, onEdit actions. |
||
| 40 | * |
||
| 41 | * @var array |
||
| 42 | */ |
||
| 43 | protected $rules = []; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * Columns for Model. |
||
| 47 | * |
||
| 48 | * Defines which fields to show in the listing tables output. |
||
| 49 | * |
||
| 50 | * @var array |
||
| 51 | */ |
||
| 52 | protected $columns = []; |
||
| 53 | |||
| 54 | /** |
||
| 55 | * Map Model Attributes to FieldTypes with |
||
| 56 | * additional parameters which will be output |
||
| 57 | * as fields when viewing, editting or adding |
||
| 58 | * a new model entry. |
||
| 59 | * |
||
| 60 | * @var array |
||
| 61 | */ |
||
| 62 | protected $fields = []; |
||
| 63 | |||
| 64 | /** |
||
| 65 | * Columns for Model are Sortable. |
||
| 66 | * |
||
| 67 | * @var bool |
||
| 68 | */ |
||
| 69 | protected $sortable = true; |
||
| 70 | |||
| 71 | /** |
||
| 72 | * The Controller to be used by the Model Admin. |
||
| 73 | * |
||
| 74 | * This defaults to parent::getController() |
||
| 75 | * if it has been left undefined. |
||
| 76 | * |
||
| 77 | * @var string |
||
| 78 | */ |
||
| 79 | protected $controller = '\LaravelFlare\Flare\Admin\Models\ModelAdminController'; |
||
| 80 | |||
| 81 | /** |
||
| 82 | * The Policy used for the Model Authorization logic. |
||
| 83 | * |
||
| 84 | * This class should implement the ModelAdminPoliceable which |
||
| 85 | * includes authorization checks for the create, view, edit and delete actions. |
||
| 86 | * |
||
| 87 | * @var string |
||
| 88 | */ |
||
| 89 | protected $policy = '\LaravelFlare\Flare\Permissions\ModelAdminPolicy'; |
||
| 90 | |||
| 91 | /** |
||
| 92 | * The current model to be managed. |
||
| 93 | * |
||
| 94 | * @var Model |
||
| 95 | */ |
||
| 96 | public $model; |
||
| 97 | |||
| 98 | /** |
||
| 99 | * __construct. |
||
| 100 | */ |
||
| 101 | public function __construct() |
||
| 107 | |||
| 108 | /** |
||
| 109 | * Returns a Model Instance. |
||
| 110 | * |
||
| 111 | * @return Model |
||
| 112 | */ |
||
| 113 | public function model() |
||
| 123 | |||
| 124 | /** |
||
| 125 | * Returns a New Model Instance. |
||
| 126 | * |
||
| 127 | * @return Model |
||
| 128 | */ |
||
| 129 | public function newModel() |
||
| 135 | |||
| 136 | /** |
||
| 137 | * Returns the Managed Model Class. |
||
| 138 | * |
||
| 139 | * @return string |
||
| 140 | */ |
||
| 141 | public function getManagedModel() |
||
| 149 | |||
| 150 | /** |
||
| 151 | * Set the Managed Model Class. |
||
| 152 | * |
||
| 153 | * @param string $managedModel |
||
| 154 | */ |
||
| 155 | public function setManagedModel($managedModel = null) |
||
| 159 | |||
| 160 | /** |
||
| 161 | * Get the Entity Title. |
||
| 162 | * |
||
| 163 | * @return string |
||
| 164 | */ |
||
| 165 | public function getEntityTitle() |
||
| 173 | |||
| 174 | /** |
||
| 175 | * Set Entity Title. |
||
| 176 | * |
||
| 177 | * @param string $entityTitle |
||
| 178 | */ |
||
| 179 | public function setTitle($entityTitle = null) |
||
| 183 | |||
| 184 | /** |
||
| 185 | * Plural Entity Title |
||
| 186 | * |
||
| 187 | * @return string |
||
| 188 | */ |
||
| 189 | public function getPluralEntityTitle() |
||
| 197 | |||
| 198 | /** |
||
| 199 | * Set Plural Title. |
||
| 200 | * |
||
| 201 | * @param string $pluralEntityTitle |
||
| 202 | */ |
||
| 203 | public function setPluralTitle($pluralEntityTitle = null) |
||
| 207 | |||
| 208 | |||
| 209 | /** |
||
| 210 | * Returns the Route Paramets. |
||
| 211 | * |
||
| 212 | * @return array |
||
| 213 | */ |
||
| 214 | public function routeParameters() |
||
| 220 | |||
| 221 | /** |
||
| 222 | * Formats and returns the Columns. |
||
| 223 | * |
||
| 224 | * This is really gross, I'm removing it soon. |
||
| 225 | * |
||
| 226 | * @return |
||
| 227 | */ |
||
| 228 | public function getColumns() |
||
| 269 | |||
| 270 | /** |
||
| 271 | * Gets an Attribute by the provided key |
||
| 272 | * on either the current model or a provided model instance. |
||
| 273 | * |
||
| 274 | * @param string $key |
||
| 275 | * @param mixed $model |
||
| 276 | * |
||
| 277 | * @return mixed |
||
| 278 | */ |
||
| 279 | public function getAttribute($key, $model = false) |
||
| 301 | |||
| 302 | /** |
||
| 303 | * Determine if a get accessor exists for an attribute. |
||
| 304 | * |
||
| 305 | * @param string $key |
||
| 306 | * |
||
| 307 | * @return bool |
||
| 308 | */ |
||
| 309 | public function hasGetAccessor($key) |
||
| 313 | |||
| 314 | /** |
||
| 315 | * Determines if a key resolved a related Model. |
||
| 316 | * |
||
| 317 | * @param string $key |
||
| 318 | * @param mixed $model |
||
| 319 | * |
||
| 320 | * @return bool |
||
| 321 | */ |
||
| 322 | public function hasRelatedKey($key, $model = false) |
||
| 337 | |||
| 338 | /** |
||
| 339 | * Resolves a relation based on the key provided, |
||
| 340 | * either on the current model or a provided model instance. |
||
| 341 | * |
||
| 342 | * @param string $key |
||
| 343 | * @param mixed $model |
||
| 344 | * |
||
| 345 | * @return mixed |
||
| 346 | */ |
||
| 347 | public function relatedKey($key, $model = false) |
||
| 370 | |||
| 371 | /** |
||
| 372 | * Set a given attribute on the model. |
||
| 373 | * |
||
| 374 | * @param string $key |
||
| 375 | * @param mixed $value |
||
| 376 | */ |
||
| 377 | public function setAttribute($key, $value) |
||
| 387 | |||
| 388 | /** |
||
| 389 | * Determine if a set mutator exists for an attribute. |
||
| 390 | * |
||
| 391 | * @param string $key |
||
| 392 | * |
||
| 393 | * @return bool |
||
| 394 | */ |
||
| 395 | public function hasSetMutator($key) |
||
| 399 | |||
| 400 | /** |
||
| 401 | * Determine if a get mutator exists for an attribute. |
||
| 402 | * |
||
| 403 | * @param string $key |
||
| 404 | * |
||
| 405 | * @return bool |
||
| 406 | */ |
||
| 407 | public function hasGetMutator($key) |
||
| 411 | |||
| 412 | /** |
||
| 413 | * Returns an array of Attribute Fields ready for output. |
||
| 414 | * |
||
| 415 | * @return array |
||
| 416 | */ |
||
| 417 | public function outputFields() |
||
| 421 | |||
| 422 | /** |
||
| 423 | * Gets the Managed Model Mapping. |
||
| 424 | * |
||
| 425 | * @return array |
||
| 426 | */ |
||
| 427 | public function getFields() |
||
| 433 | |||
| 434 | /** |
||
| 435 | * Sets the Managed Model Mapping. |
||
| 436 | * |
||
| 437 | * @param array $fields |
||
| 438 | */ |
||
| 439 | public function setFields($fields = []) |
||
| 445 | |||
| 446 | /** |
||
| 447 | * Format the provided Attribute Fields into a more usable format. |
||
| 448 | */ |
||
| 449 | protected function formatFields() |
||
| 459 | |||
| 460 | /** |
||
| 461 | * Determine if the Model Admin is sortable in it's list view. |
||
| 462 | * |
||
| 463 | * @return bool |
||
| 464 | */ |
||
| 465 | public function isSortable() |
||
| 469 | |||
| 470 | /** |
||
| 471 | * Determine if the Model Admin is sortable by a defined key / column. |
||
| 472 | * |
||
| 473 | * @param string $key |
||
| 474 | * |
||
| 475 | * @return bool |
||
| 476 | */ |
||
| 477 | public function isSortableBy($key) |
||
| 496 | |||
| 497 | /** |
||
| 498 | * Determine if the Model Admin has Viewing Capabilities. |
||
| 499 | * |
||
| 500 | * @return bool |
||
| 501 | */ |
||
| 502 | public function hasViewing() |
||
| 506 | |||
| 507 | /** |
||
| 508 | * Determine if the Model Admin has Creating Capabilities. |
||
| 509 | * |
||
| 510 | * @return bool |
||
| 511 | */ |
||
| 512 | public function hasCreating() |
||
| 516 | |||
| 517 | /** |
||
| 518 | * Determine if the Model Admin has Cloning Capabilities. |
||
| 519 | * |
||
| 520 | * @return bool |
||
| 521 | */ |
||
| 522 | public function hasCloning() |
||
| 526 | |||
| 527 | /** |
||
| 528 | * Determine if the Model Admin has Editting Capabilities. |
||
| 529 | * |
||
| 530 | * @return bool |
||
| 531 | */ |
||
| 532 | public function hasEditting() |
||
| 536 | |||
| 537 | /** |
||
| 538 | * Determine if the Model Admin has Deleting Capabilities. |
||
| 539 | * |
||
| 540 | * @return bool |
||
| 541 | */ |
||
| 542 | public function hasDeleting() |
||
| 546 | |||
| 547 | /** |
||
| 548 | * Determine if the Managed Model is using the SoftDeletes Trait. |
||
| 549 | * |
||
| 550 | * This is guarded by hasDeleting, since we shouldn't allow SoftDeleting |
||
| 551 | * without the deleting trait (even though it isn't really required). |
||
| 552 | * |
||
| 553 | * @return bool |
||
| 554 | */ |
||
| 555 | public function hasSoftDeleting() |
||
| 569 | |||
| 570 | /** |
||
| 571 | * Determine if the Model Admin has Validating Capabilities. |
||
| 572 | * |
||
| 573 | * @return bool |
||
| 574 | */ |
||
| 575 | public function hasValidating() |
||
| 579 | |||
| 580 | /** |
||
| 581 | * Determine if the Managed Model has a Trait and Contract. |
||
| 582 | * |
||
| 583 | * @return bool |
||
| 584 | */ |
||
| 585 | public function hasTraitAndContract($trait = null, $contract = null) |
||
| 589 | |||
| 590 | /** |
||
| 591 | * Returns whether the current ModelAdmin has a given trait. |
||
| 592 | * |
||
| 593 | * @param string $trait |
||
| 594 | * |
||
| 595 | * @return bool |
||
| 596 | */ |
||
| 597 | public function hasTrait($trait = null) |
||
| 605 | |||
| 606 | /** |
||
| 607 | * Returns whether the current ModelAdmin has a given contract. |
||
| 608 | * |
||
| 609 | * @param string $contract |
||
| 610 | * |
||
| 611 | * @return bool |
||
| 612 | */ |
||
| 613 | public function hasContract($contract = null) |
||
| 621 | } |
||
| 622 |
This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug.