ModuleAdminController::__construct() - Code Metrics - laravelflare/flare - Measure and Improve Code Quality continuously with Scrutinizer

ModuleAdminController::__construct() A
last analyzed 2019-02-11 23:01 UTC

↳ Parent: ModuleAdminController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

namespace LaravelFlare\Flare\Admin\Modules;

use LaravelFlare\Flare\Admin\AdminManager;
use LaravelFlare\Flare\Http\Controllers\FlareController;

class ModuleAdminController extends FlareController
{
    /**
     * Admin Instance.
     * 
     * @var 
     */
    protected $admin;

    /**
     * __construct.
     * 
     * @param AdminManager $adminManager
     */
    public function __construct(AdminManager $adminManager)
    {
        // Must call parent __construct otherwise 
        // we need to redeclare checkpermissions
        // middleware for authentication check
        parent::__construct($adminManager);

        $this->admin = $this->adminManager->getAdminInstance();

        view()->share('moduleAdmin', $this->admin);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Index page for Module.
     * 
     * @return \Illuminate\Http\Response
     */
    public function getIndex()
    {
        return view($this->admin->getView(), $this->admin->getViewData());
    }

    /**
     * Method is called when the appropriate controller
     * method is unable to be found or called.
     * 
     * @param array $parameters
     * 
     * @return
     */
    public function missingMethod($parameters = array())
    {
        return parent::missingMethod();
    }
}


1			<?php
2
3			namespace LaravelFlare\Flare\Admin\Modules;
4
5			use LaravelFlare\Flare\Admin\AdminManager;
6			use LaravelFlare\Flare\Http\Controllers\FlareController;
7
8			class ModuleAdminController extends FlareController
9			{
10			/**
11			* Admin Instance.
12			*
13			* @var
14			*/
15			protected $admin;
16
17			/**
18			* __construct.
19			*
20			* @param AdminManager $adminManager
21			*/
22			public function __construct(AdminManager $adminManager)
23			{
24			// Must call parent __construct otherwise
25			// we need to redeclare checkpermissions
26			// middleware for authentication check
27			parent::__construct($adminManager);
28
29			$this->admin = $this->adminManager->getAdminInstance();
30
31			view()->share('moduleAdmin', $this->admin);
			0 ignored issues – show Bug introduced 2015-11-29 15:51 UTC by Report Bug Copy Issue Report The method `share` does only exist in `Illuminate\Contracts\View\Factory`, but not in `Illuminate\View\View`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
32			}
33
34			/**
35			* Index page for Module.
36			*
37			* @return \Illuminate\Http\Response
38			*/
39			public function getIndex()
40			{
41			return view($this->admin->getView(), $this->admin->getViewData());
42			}
43
44			/**
45			* Method is called when the appropriate controller
46			* method is unable to be found or called.
47			*
48			* @param array $parameters
49			*
50			* @return
51			*/
52			public function missingMethod($parameters = array())
53			{
54			return parent::missingMethod();
55			}
56			}
57

laravelflare / flare

GitHub Access Token became invalid

ModuleAdminController::__construct() A last analyzed 2019-02-11 23:01 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

ModuleAdminController::__construct() A
last analyzed 2019-02-11 23:01 UTC