Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 8 | class RouteServiceProvider extends AbstractRouteServiceProvider |
||
| 9 | { |
||
| 10 | /** |
||
| 11 | * The compatibility version of this RouteServiceProvider. |
||
| 12 | * |
||
| 13 | * @var string |
||
| 14 | */ |
||
| 15 | protected $compatibilityVersion = 'LTS'; |
||
| 16 | |||
| 17 | /** |
||
| 18 | * Register all the Flare Provided Middleware and Middleware Groups. |
||
| 19 | * |
||
| 20 | * We define flarebase rather than extend an existing middleware stack |
||
| 21 | * since it is possible that a user has amended the default middleware |
||
| 22 | * of their application in a way that could break Flare. |
||
| 23 | * |
||
| 24 | * @param Router $router |
||
| 25 | */ |
||
| 26 | protected function registerMiddleware(Router $router) |
||
| 32 | |||
| 33 | /** |
||
| 34 | * Register the Defined Routes. |
||
| 35 | * |
||
| 36 | * This registers all the routes which have been defined by |
||
| 37 | * Admin sections defined in the Application's Flare Config |
||
| 38 | * (or in the runtime config if anotehr service provider |
||
| 39 | * has already started manipulating these dynamically). |
||
| 40 | * |
||
| 41 | * @param Router $router |
||
| 42 | */ |
||
| 43 | View Code Duplication | protected function registerDefinedRoutes(Router $router) |
|
| 57 | |||
| 58 | /** |
||
| 59 | * Register the Default Routes. |
||
| 60 | * |
||
| 61 | * This registers all the default routes which are included |
||
| 62 | * with Flare. These consist of things which will probably |
||
| 63 | * be included with every application such as the login, |
||
| 64 | * logout and password reset forms. |
||
| 65 | * |
||
| 66 | * The login form can however be hidden by setting the |
||
| 67 | * 'show' config for 'login' to false. |
||
| 68 | * |
||
| 69 | * @param Router $router |
||
| 70 | */ |
||
| 71 | protected function registerDefaultRoutes(Router $router) |
||
| 98 | } |
||
| 99 |