LaravelFlare\Flare\Permissions\Permissions

Complexity

Total Complexity

3

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	check()	0	8	2
A	denied()	0	4	1

<?php

namespace LaravelFlare\Flare\Permissions;

use LaravelFlare\Flare\Exceptions\PermissionsException;
use LaravelFlare\Flare\Contracts\Permissions\Permissionable;

class Permissions implements Permissionable
{
    /**
     * Checks if the currently Authenticated User
     * has access to a given action.
     *
     * @param string $class
     * @param string $action
     * 
     * @return
     */
    public static function check($class = null, $action = 'view')
    {
        if (!$class) {

The expression $class of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            return \Auth::user()->is_admin;
        }

        return \Auth::user()->is_admin;
    }

    /**
     * Method called when a User attempts to access
     * an area of the site or admin which they do 
     * not have the permissions to interact with.
     *
     * This is typically called from the CheckPermissions
     * Middleware during a request (see: \LaravelFlare\Flare\Http\Middleware\CheckPermissions::handle())
     * and can be used to throw an exception, return a 
     * view (abort() etc.) or anything else really.
     * 
     * @param string $class
     * @param string $action
     *
     * @return mixed
     */
    public static function denied($class = null, $action = 'view')

The parameter $class is not used and could be removed.

The parameter $action is not used and could be removed.

    {
        throw new PermissionsException('Permission denied!');
    }
}