AdminController - Code Metrics - laravelflare/flare - Measure and Improve Code Quality continuously with Scrutinizer

AdminController A
last analyzed 2019-02-11 23:01 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	131
Duplicated Lines	7.63 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

Metric	Value
wmc	11
lcom	1
cbo	8
dl	10
loc	131
rs	10
c	0
b	0
f	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getDashboard()	10	10	2
A	getLogin()	0	4	1
A	postLogin()	0	4	1
A	getLogout()	0	6	1
A	getEmail()	0	4	1
A	getReset()	0	4	1
A	loginRedirect()	0	9	2
A	missingMethod()	0	4	1

How to fix Duplicated Code

<?php

namespace LaravelFlare\Flare\Http\Controllers\Edge;

use Flare;
use Response;
use Illuminate\Http\Request;
use Illuminate\Contracts\Auth\Guard;
use LaravelFlare\Flare\Admin\AdminManager;
use Illuminate\Foundation\Bus\DispatchesJobs;
use Illuminate\Foundation\Auth\ResetsPasswords;
use LaravelFlare\Flare\Permissions\Permissions;
use Illuminate\Foundation\Auth\ThrottlesLogins;
use Illuminate\Foundation\Auth\AuthenticatesUsers;
use LaravelFlare\Flare\Http\Controllers\FlareController;
use LaravelFlare\Flare\Admin\Widgets\WidgetAdminManager;

class AdminController extends FlareController
{
    use AuthenticatesUsers {
        AuthenticatesUsers::redirectPath insteadof ResetsPasswords;
        AuthenticatesUsers::credentials insteadof ResetsPasswords;
        AuthenticatesUsers::guard insteadof ResetsPasswords;
    }
    use ResetsPasswords;
    use DispatchesJobs;

    /**
     * Auth.
     * 
     * @var Guard
     */
    protected $auth;

    /**
     * __construct.
     * 
     * @param Guard        $auth
     * @param AdminManager $adminManager
     */
    public function __construct(Guard $auth, AdminManager $adminManager)
    {
        parent::__construct($adminManager);

        $this->auth = $auth;
    }

    /**
     * Show the Dashboard.
     * 
     * @return \Illuminate\Http\Response
     */
    public function getDashboard()
    {
        $view = 'admin.dashboard';

        if (!view()->exists($view)) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            $view = 'flare::'.$view;
        }

        return view($view, ['widgets' => (new WidgetAdminManager())]);
    }

    /**
     * Show the login form.
     *
     * @return \Illuminate\Http\Response
     */
    public function getLogin()
    {
        return view('flare::admin.login');
    }

    /**
     * Show the login form.
     *
     * @return \Illuminate\Http\Response
     */
    public function postLogin(Request $request)
    {
        return $this->login($request);

    }

    /**
     * Log the user.
     *
     * @return \Illuminate\Http\RedirectReponse
     */
    public function getLogout()
    {
        $this->auth->logout();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        return redirect('/');
    }

    /**
     * Display the form to request a password reset link.
     *
     * @return \Illuminate\Http\Response
     */
    public function getEmail()
    {
        return view('flare::admin.password');
    }

    /**
     * Display the form to request a password reset link.
     *
     * @return \Illuminate\Http\Response
     */
    public function getReset()
    {
        return view('flare::admin.reset');
    }

    /**
     * Performs the login redirect action.
     *
     * If the authenticated user has admin permissions
     * then they will be redirected into the admin
     * panel. If they do no, they will be sent
     * to the homepage of the website.
     * 
     * @return \Illuminate\Http\RedirectReponse
     */
    protected function loginRedirect()
    {
        dd('here');
        if (Permissions::check()) {
            return redirect()->intended(Flare::adminUrl());
        }

        return redirect('/');
    }

    /**
     * Method is called when the appropriate controller
     * method is unable to be found or called.
     * 
     * @param array $parameters
     * 
     * @return \Illuminate\Http\Response
     */
    public function missingMethod($parameters = array())
    {
        return Response::view('flare::admin.404', [], 404);
    }
}


1		<?php
2
3		namespace LaravelFlare\Flare\Http\Controllers\Edge;
4
5		use Flare;
6		use Response;
7		use Illuminate\Http\Request;
8		use Illuminate\Contracts\Auth\Guard;
9		use LaravelFlare\Flare\Admin\AdminManager;
10		use Illuminate\Foundation\Bus\DispatchesJobs;
11		use Illuminate\Foundation\Auth\ResetsPasswords;
12		use LaravelFlare\Flare\Permissions\Permissions;
13		use Illuminate\Foundation\Auth\ThrottlesLogins;
14		use Illuminate\Foundation\Auth\AuthenticatesUsers;
15		use LaravelFlare\Flare\Http\Controllers\FlareController;
16		use LaravelFlare\Flare\Admin\Widgets\WidgetAdminManager;
17
18		class AdminController extends FlareController
19		{
20		use AuthenticatesUsers {
21		AuthenticatesUsers::redirectPath insteadof ResetsPasswords;
22		AuthenticatesUsers::credentials insteadof ResetsPasswords;
23		AuthenticatesUsers::guard insteadof ResetsPasswords;
24		}
25		use ResetsPasswords;
26		use DispatchesJobs;
27
28		/**
29		* Auth.
30		*
31		* @var Guard
32		*/
33		protected $auth;
34
35		/**
36		* __construct.
37		*
38		* @param Guard $auth
39		* @param AdminManager $adminManager
40		*/
41		public function __construct(Guard $auth, AdminManager $adminManager)
42		{
43		parent::__construct($adminManager);
44
45		$this->auth = $auth;
46		}
47
48		/**
49		* Show the Dashboard.
50		*
51		* @return \Illuminate\Http\Response
52		*/
53	View Code Duplication	public function getDashboard()
54		{
55		$view = 'admin.dashboard';
56
57		if (!view()->exists($view)) {
		0 ignored issues – show Bug introduced 2016-02-25 13:43 UTC by Report Bug Copy Issue Report The method `exists` does only exist in `Illuminate\Contracts\View\Factory`, but not in `Illuminate\View\View`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
58		$view = 'flare::'.$view;
59		}
60
61		return view($view, ['widgets' => (new WidgetAdminManager())]);
62		}
63
64		/**
65		* Show the login form.
66		*
67		* @return \Illuminate\Http\Response
68		*/
69		public function getLogin()
70		{
71		return view('flare::admin.login');
72		}
73
74		/**
75		* Show the login form.
76		*
77		* @return \Illuminate\Http\Response
78		*/
79		public function postLogin(Request $request)
80		{
81		return $this->login($request);
		0 ignored issues – show Bug Compatibility introduced 2017-01-30 15:02 UTC by Report Bug Copy Issue Report The expression `$this->login($request);` of type `Illuminate\Http\Redirect...lluminate\Http\Response` adds the type `Illuminate\Http\RedirectResponse` to the return on line 81 which is incompatible with the return type documented by `LaravelFlare\Flare\Http\...inController::postLogin` of type `Illuminate\Http\Response`. Loading history...
82		}
83
84		/**
85		* Log the user.
86		*
87		* @return \Illuminate\Http\RedirectReponse
88		*/
89		public function getLogout()
90		{
91		$this->auth->logout();
		0 ignored issues – show Bug introduced 2016-02-25 13:43 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Auth\Guard` as the method `logout()` does only exist in the following implementations of said interface: `Illuminate\Auth\SessionGuard`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
92
93		return redirect('/');
94		}
95
96		/**
97		* Display the form to request a password reset link.
98		*
99		* @return \Illuminate\Http\Response
100		*/
101		public function getEmail()
102		{
103		return view('flare::admin.password');
104		}
105
106		/**
107		* Display the form to request a password reset link.
108		*
109		* @return \Illuminate\Http\Response
110		*/
111		public function getReset()
112		{
113		return view('flare::admin.reset');
114		}
115
116		/**
117		* Performs the login redirect action.
118		*
119		* If the authenticated user has admin permissions
120		* then they will be redirected into the admin
121		* panel. If they do no, they will be sent
122		* to the homepage of the website.
123		*
124		* @return \Illuminate\Http\RedirectReponse
125		*/
126		protected function loginRedirect()
127		{
128		dd('here');
129		if (Permissions::check()) {
130		return redirect()->intended(Flare::adminUrl());
131		}
132
133		return redirect('/');
134		}
135
136		/**
137		* Method is called when the appropriate controller
138		* method is unable to be found or called.
139		*
140		* @param array $parameters
141		*
142		* @return \Illuminate\Http\Response
143		*/
144		public function missingMethod($parameters = array())
145		{
146		return Response::view('flare::admin.404', [], 404);
147		}
148		}
149

laravelflare / flare

GitHub Access Token became invalid

AdminController A last analyzed 2019-02-11 23:01 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

AdminController A
last analyzed 2019-02-11 23:01 UTC