ModelAdminController - Code Metrics - laravelflare/flare - Measure and Improve Code Quality continuously with Scrutinizer

ModelAdminController A
last analyzed 2019-02-11 23:01 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	262
Duplicated Lines	28.24 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
wmc	27
lcom	1
cbo	5
dl	74
loc	262
rs	10
c	0
b	0
f	0

14 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	14	1
A	getIndex()	0	8	1
A	getTrashed()	12	12	2
A	getAll()	12	12	2
A	getCreate()	0	8	2
A	postCreate()	10	10	2
A	getView()	0	12	2
A	getEdit()	0	10	2
A	postEdit()	10	10	2
A	getDelete()	0	14	3
A	postDelete()	10	10	2
A	getRestore()	0	8	2
A	postRestore()	10	10	2
A	getClone()	10	10	2

How to fix Duplicated Code

<?php

namespace LaravelFlare\Flare\Admin\Models;

use LaravelFlare\Flare\Events\ModelView;
use LaravelFlare\Flare\Admin\AdminManager;
use LaravelFlare\Flare\Http\Requests\ModelEditRequest;
use LaravelFlare\Flare\Http\Requests\ModelCreateRequest;
use LaravelFlare\Flare\Http\Controllers\FlareController;

class ModelAdminController extends FlareController
{
    /**
     * ModelAdmin instance which has been resolved.
     * 
     * @var ModelAdmin
     */
    protected $modelAdmin;

    /**
     * Model instance.
     * 
     * @var Model
     */
    protected $model;

    /**
     * __construct.
     * 
     * @param AdminManager $adminManager
     */
    public function __construct(AdminManager $adminManager)
    {
        // Must call parent __construct otherwise 
        // we need to redeclare checkpermissions
        // middleware for authentication check
        parent::__construct($adminManager);

        $this->middleware('checkmodelfound', ['only' => ['getView', 'edit', 'delete']]);

        $this->modelAdmin = $this->adminManager->getAdminInstance();
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->model = $this->modelAdmin->model();

        view()->share('modelAdmin', $this->modelAdmin);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Index page for ModelAdmin.
     * 
     * @return \Illuminate\Http\Response
     */
    public function getIndex()
    {
        return view('flare::admin.modeladmin.index', [
                                                        'modelItems' => $this->modelAdmin->items(),
                                                        'totals' => $this->modelAdmin->totals(),
                                                    ]
                                                );
    }

    /**
     * Lists Trashed Model Items.
     * 
     * @return \Illuminate\Http\Response
     */
    public function getTrashed()
    {
        if (!$this->modelAdmin->hasSoftDeleting()) {
            return $this->missingMethod();
        }

        return view('flare::admin.modeladmin.trashed', [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                                                        'modelItems' => $this->modelAdmin->onlyTrashedItems(),
                                                        'totals' => $this->modelAdmin->totals(),
                                                    ]
                                                );
    }

    /**
     * List All Model Items inc Trashed.
     * 
     * @return \Illuminate\Http\Response
     */
    public function getAll()
    {
        if (!$this->modelAdmin->hasSoftDeleting()) {
            return $this->missingMethod();
        }

        return view('flare::admin.modeladmin.all', [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                                                        'modelItems' => $this->modelAdmin->allItems(),
                                                        'totals' => $this->modelAdmin->totals(),
                                                    ]
                                            );
    }

    /**
     * Create a new Model Entry from ModelAdmin Create Page.
     * 
     * @return \Illuminate\Http\Response
     */
    public function getCreate()
    {
        if (!$this->modelAdmin->hasCreating()) {
            return $this->missingMethod();
        }

        return view('flare::admin.modeladmin.create', []);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Receive new Model Entry Post Data, validate it and return user.
     * 
     * @return \Illuminate\Http\RedirectResponse
     */
    public function postCreate(ModelCreateRequest $request)

    {
        if (!$this->modelAdmin->hasCreating()) {
            return $this->missingMethod();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $this->modelAdmin->create();

        return redirect($this->modelAdmin->currentUrl())->with('notifications_below_header', [['type' => 'success', 'icon' => 'check-circle', 'title' => 'Success!', 'message' => 'The '.$this->modelAdmin->getTitle().' was successfully created.', 'dismissable' => false]]);

    }

    /**
     * View a Model Entry from ModelAdmin View Page.
     * 
     * @return \Illuminate\Http\Response
     */
    public function getView($modelitemId)
    {
        if (!$this->modelAdmin->hasViewing()) {
$a = canBeFalseAndNull();

// Instead of
if ( ! $a) { }

// Better use one of the explicit versions:
if ($a !== null) { }
if ($a !== false) { }
if ($a !== null && $a !== false) { }
            return $this->missingMethod();
        }

        $this->modelAdmin->find($modelitemId);

        event(new ModelView($this->modelAdmin));

        return view('flare::admin.modeladmin.view', ['modelItem' => $this->modelAdmin->model]);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Edit Model Entry from ModelAdmin Edit Page.
     *
     * @param int $modelitemId
     * 
     * @return \Illuminate\Http\Response
     */
    public function getEdit($modelitemId)
    {
        if (!$this->modelAdmin->hasEditing()) {
            return $this->missingMethod();
        }

        $this->modelAdmin->find($modelitemId);

        return view('flare::admin.modeladmin.edit', ['modelItem' => $this->modelAdmin->model]);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Receive Model Entry Update Post Data, validate it and return user.
     * 
     * @param int $modelitemId
     * 
     * @return \Illuminate\Http\RedirectResponse
     */
    public function postEdit(ModelEditRequest $request, $modelitemId)

    {
        if (!$this->modelAdmin->hasEditing()) {
            return $this->missingMethod();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $this->modelAdmin->edit($modelitemId);

        return redirect($this->modelAdmin->currentUrl())->with('notifications_below_header', [['type' => 'success', 'icon' => 'check-circle', 'title' => 'Success!', 'message' => 'The '.$this->modelAdmin->getTitle().' was successfully updated.', 'dismissable' => false]]);

    }

    /**
     * Delete Model Entry from ModelAdmin Delete Page.
     *
     * @param int $modelitemId
     * 
     * @return \Illuminate\Http\Response
     */
    public function getDelete($modelitemId)
    {
        if (!$this->modelAdmin->hasDeleting()) {
            return $this->missingMethod();
        }

        if ($this->modelAdmin->hasSoftDeleting()) {
            $this->modelAdmin->findWithTrashed($modelitemId);

        } else {
            $this->modelAdmin->find($modelitemId);
        }

        return view('flare::admin.modeladmin.delete', ['modelItem' => $this->modelAdmin->model]);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Receive Model Entry Delete Post Data, validate it and return user.
     *
     * @param int $modelitemId
     * 
     * @return \Illuminate\Http\RedirectResponse
     */
    public function postDelete($modelitemId)
    {
        if (!$this->modelAdmin->hasDeleting()) {
            return $this->missingMethod();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $this->modelAdmin->delete($modelitemId);

        return redirect($this->modelAdmin->currentUrl())->with('notifications_below_header', [['type' => 'success', 'icon' => 'check-circle', 'title' => 'Success!', 'message' => 'The '.$this->modelAdmin->getTitle().' was successfully removed.', 'dismissable' => false]]);

    }

    /**
     * Restore a ModelItem.
     *
     * @param int $modelitemId
     * 
     * @return \Illuminate\Http\Response
     */
    public function getRestore($modelitemId)

    {
        if (!$this->modelAdmin->hasSoftDeleting()) {
            return $this->missingMethod();
        }

        return view('flare::admin.modeladmin.restore', ['modelItem' => $this->modelAdmin->model]);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Process Restore ModelItem Request.
     *
     * @param int $page_id
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * 
     * @return \Illuminate\Http\RedirectResponse
     */
    public function postRestore($modelitemId)
    {
        if (!$this->modelAdmin->hasSoftDeleting()) {
            return $this->missingMethod();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $this->modelAdmin->restore($modelitemId);


        return redirect($this->modelAdmin->currentUrl())->with('notifications_below_header', [['type' => 'success', 'icon' => 'check-circle', 'title' => 'Success!', 'message' => 'The '.$this->modelAdmin->getTitle().' was successfully restored.', 'dismissable' => false]]);

    }

    /**
     * Clone a Page.
     *
     * @param int $modelitemId
     * 
     * @return \Illuminate\Http\Response
     */
    public function getClone($modelitemId)
    {
        if (!$this->modelAdmin->hasCloning()) {
            return $this->missingMethod();
        }

        $this->modelAdmin->clone($modelitemId);


        return redirect($this->modelAdmin->currentUrl())->with('notifications_below_header', [['type' => 'success', 'icon' => 'check-circle', 'title' => 'Success!', 'message' => 'The '.$this->modelAdmin->getTitle().' was successfully cloned.', 'dismissable' => false]]);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


GitHub Access Token became invalid

ModelAdminController A
last analyzed 2019-02-11 23:01 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

1			<?php
2
3			namespace LaravelFlare\Flare\Admin\Models;
4
5			use LaravelFlare\Flare\Events\ModelView;
6			use LaravelFlare\Flare\Admin\AdminManager;
7			use LaravelFlare\Flare\Http\Requests\ModelEditRequest;
8			use LaravelFlare\Flare\Http\Requests\ModelCreateRequest;
9			use LaravelFlare\Flare\Http\Controllers\FlareController;
10
11			class ModelAdminController extends FlareController
12			{
13			/**
14			* ModelAdmin instance which has been resolved.
15			*
16			* @var ModelAdmin
17			*/
18			protected $modelAdmin;
19
20			/**
21			* Model instance.
22			*
23			* @var Model
24			*/
25			protected $model;
26
27			/**
28			* __construct.
29			*
30			* @param AdminManager $adminManager
31			*/
32			public function __construct(AdminManager $adminManager)
33			{
34			// Must call parent __construct otherwise
35			// we need to redeclare checkpermissions
36			// middleware for authentication check
37			parent::__construct($adminManager);
38
39			$this->middleware('checkmodelfound', ['only' => ['getView', 'edit', 'delete']]);
40

laravelflare / flare

GitHub Access Token became invalid

ModelAdminController A last analyzed 2019-02-11 23:01 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like

ModelAdminController A
last analyzed 2019-02-11 23:01 UTC