Issues in SelfUpdateCommand.php (stable) - Issues in stable - laravel-zero/framework - Measure and Improve Code Quality continuously with Scrutinizer

Issues (21)

src/Components/Updater/SelfUpdateCommand.php (1 issue)

Labels

Bug 1

Severity

Minor 1

<?php

declare(strict_types=1);

/**
 * This file is part of Laravel Zero.
 *
 * (c) Nuno Maduro <[email protected]>
 *
 *  For the full copyright and license information, please view the LICENSE
 *  file that was distributed with this source code.
 */

namespace LaravelZero\Framework\Components\Updater;

use LaravelZero\Framework\Commands\Command;

class SelfUpdateCommand extends Command
{
    /**
     * {@inheritdoc}
     */
    protected $name = 'self-update';

    /**
     * {@inheritdoc}
     */
    protected $description = 'Allows to self-update a build application';

    /**
     * {@inheritdoc}
     */
    public function handle(Updater $updater)
    {
        $this->output->title('Checking for a new version...');

        $result = $updater->update($this->output);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/**
6			* This file is part of Laravel Zero.
7			*
8			* (c) Nuno Maduro <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace LaravelZero\Framework\Components\Updater;
15
16			use LaravelZero\Framework\Commands\Command;
17
18			class SelfUpdateCommand extends Command
19			{
20			/**
21			* {@inheritdoc}
22			*/
23			protected $name = 'self-update';
24
25			/**
26			* {@inheritdoc}
27			*/
28			protected $description = 'Allows to self-update a build application';
29
30			/**
31			* {@inheritdoc}
32			*/
33			public function handle(Updater $updater)
34			{
35			$this->output->title('Checking for a new version...');
36
37			$result = $updater->update($this->output);
			0 ignored issues – show Bug introduced 2019-03-10 17:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$result` is correct as `$updater->update($this->output)` targeting `LaravelZero\Framework\Co...dater\Updater::update()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
38			}
39			}
40

laravel-zero / framework

Issues (21)

src/Components/Updater/SelfUpdateCommand.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like