Builder - Code Metrics - Inspection of "Merge pull request #222 from wouter2203/fix-file-i..." - laravel-zero/framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — stable ( db17bb...1635ea )

by Nuno

created 2018-03-04 17:06 UTC

Builder A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	235
Duplicated Lines	4.26 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

88.75%

Importance

Changes

Metric	Value
wmc	18
lcom	1
cbo	2
dl	10
loc	235
ccs	71
cts	80
cp	0.8875
rs	10
c	0
b	0
f	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	handle()	0	13	3
A	build()	0	18	1
B	compile()	0	32	3
A	getCompiler()	0	12	2
A	makeBuildsFolder()	0	8	2
A	setPermissions()	0	6	1
B	prepare()	5	29	2
A	clear()	5	16	2
A	__destruct()	0	7	2

How to fix Duplicated Code

<?php

/**
 * This file is part of Laravel Zero.
 *
 * (c) Nuno Maduro <[email protected]>
 *
 *  For the full copyright and license information, please view the LICENSE
 *  file that was distributed with this source code.
 */

namespace LaravelZero\Framework\Commands\App;

use Phar;
use FilesystemIterator;
use UnexpectedValueException;
use Illuminate\Support\Facades\File;
use LaravelZero\Framework\Commands\Command;
use LaravelZero\Framework\Contracts\Providers\Composer;

/**
 * This is the Laravel Zero Framework Builder Command implementation.
 */
class Builder extends Command
{
    /**
     * {@inheritdoc}
     */
    protected $signature = 'app:build {name=application : The build name} {--with-dev : Whether the dev dependencies should be included}';

    /**
     * {@inheritdoc}
     */
    protected $description = 'Perform an application build';

    /**
     * Contains the default app structure.
     *
     * @var string[]
     */
    protected $structure = [
        'app'.DIRECTORY_SEPARATOR,
        'bootstrap'.DIRECTORY_SEPARATOR,
        'vendor'.DIRECTORY_SEPARATOR,
        'config'.DIRECTORY_SEPARATOR,
        'composer.json',
        'builder-stub',
        '.env',
    ];

    /**
     * Holds the stub name.
     *
     * @var string
     */
    protected $stub = 'builder-stub';

    /**
     * Holds the configuration on is original state.
     *
     * @var string
     */
    protected static $config;

    /**
     * {@inheritdoc}
     */
    public function handle(): void
    {
        $this->info('Building the application...');

        if (Phar::canWrite()) {
            $this->build($this->input->getArgument('name') ?: static::BUILD_NAME);
        } else {
            $this->error(
                'Unable to compile a phar because of php\'s security settings. '.'phar.readonly must be disabled in php.ini. '.PHP_EOL.PHP_EOL.'You will need to edit '.php_ini_loaded_file(
                ).' and add or set'.PHP_EOL.PHP_EOL.'    phar.readonly = Off'.PHP_EOL.PHP_EOL.'to continue. Details here: http://php.net/manual/en/phar.configuration.php'
            );
        }
    }

    /**
     * Builds the application into a single file.
     *
     * @param string $name The file name.
     *
     * @return $this
     */
    protected function build(string $name): Builder
    {
        /*
         * We prepare the application for a build, moving it to production. Then,
         * after compile all the code to a single file, we move the built file
         * to the builds folder with the correct permissions.
         */
        $this->prepare()
            ->compile($name)
            ->setPermissions($name)
            ->clear();

        $this->info(
            sprintf('Application built into a single file: %s', $this->app->buildsPath($name))
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        );

        return $this;
    }

    /**
     * @param string $name
     *
     * @return $this
     */
    protected function compile(string $name): Builder
    {
        $compiler = $this->makeBuildsFolder()
            ->getCompiler($name);

        $structure = config('app.structure') ?: $this->structure;

        $regex = '#'.implode('|', $structure).'#';

        if (stristr(PHP_OS, 'WINNT') !== false) { // For windows:
            $compiler->buildFromDirectory($this->app->basePath(), str_replace('\\', '/', $regex));
        } else { // Linux, OS X:
            $compiler->buildFromDirectory($this->app->basePath(), $regex);
        }

        $this->task('Compiling code', function () use ($compiler) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $compiler->setStub(
                "#!/usr/bin/env php \n".$compiler->createDefaultStub(
                    $this->stub
                )
            );
        });

        // Unset the compiler to fix a "file in use" error on Windows.
        unset($compiler);

        $file = $this->app->buildsPath($name);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        File::move("$file.phar", $file);

        return $this;
    }

    /**
     * Gets a new instance of the compiler.
     *
     * @param string $name
     *
     * @return \Phar
     */
    protected function getCompiler(string $name): \Phar
    {
        try {
            return new Phar(
                $this->app->buildsPath($name.'.phar'),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                FilesystemIterator::CURRENT_AS_FILEINFO | FilesystemIterator::KEY_AS_FILENAME,
                $name
            );
        } catch (UnexpectedValueException $e) {
            $this->app->abort(401, 'Unauthorized.');
        }
    }

    /**
     * @return $this
     */
    protected function makeBuildsFolder(): Builder
    {
        if (! File::exists($this->app->buildsPath())) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            File::makeDirectory($this->app->buildsPath());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }

        return $this;
    }

    /**
     * Sets the executable mode on the single application file.
     *
     * @param string $name
     *
     * @return $this
     */
    protected function setPermissions($name): Builder
    {
        chmod($this->app->buildsPath($name), 0755);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        return $this;
    }

    /**
     * @return $this
     */
    protected function prepare(): Builder
    {
        $file = $this->app->configPath('app.php');
        static::$config = File::get($file);
        $config = include $file;

        $config['production'] = true;

        $this->task('Moving application to production mode', function () use ($file, $config) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            File::put($file, '<?php return '.var_export($config, true).';'.PHP_EOL);
        });

        if ($this->option('with-dev') === false) {

            $this->task('Temporarily removing dev dependencies', function () {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                $this->app[Composer::class]->install(['--no-dev']);
            });
        }

        $stub = str_replace('#!/usr/bin/env php', '', File::get($this->app->basePath(ARTISAN_BINARY)));


        // Remove first line.
        $stubAsArray = explode("\n", $stub);
        array_shift($stubAsArray);
        $stub = implode("\n", $stubAsArray);

        File::put($this->app->basePath($this->stub), $stub);


        return $this;
    }

    /**
     * @return $this
     */
    protected function clear(): Builder
    {
        File::put($this->app->configPath('app.php'), static::$config);

        File::delete($this->app->basePath($this->stub));


        if ($this->option('with-dev') === false) {

            $this->task('Reinstalling dev dependencies', function () {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                $this->app[Composer::class]->install();
            });
        }

        static::$config = null;

        return $this;
    }

    /**
     * Makes sure that the `clear` is performed even
     * if the command fails.
     *
     * @return void
     */
    public function __destruct()
    {
        if (static::$config !== null) {
            $this->clear();
            $this->error('Something went wrong.');
        }
    }
}


Push — stable ( db17bb...1635ea )

Builder A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

laravel-zero / framework

Push — stable ( db17bb...1635ea )

Builder A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like