BaseLoadConfiguration::getConfigurationFiles() - Code Metrics - Inspection of "Adds phpstan for static analyses" - laravel-zero/framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — develop (b36b95)

by Nuno

created 2018-06-24 21:46 UTC

BaseLoadConfiguration::getConfigurationFiles() A

↳ Parent: BaseLoadConfiguration

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	19
ccs	12
cts	12
cp	1
rs	9.6333
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2

<?php

declare(strict_types=1);

/**
 * This file is part of Laravel Zero.
 *
 * (c) Nuno Maduro <[email protected]>
 *
 *  For the full copyright and license information, please view the LICENSE
 *  file that was distributed with this source code.
 */

namespace LaravelZero\Framework\Bootstrap;

use function ksort;
use function basename;
use Symfony\Component\Finder\Finder;
use Illuminate\Foundation\Bootstrap\LoadConfiguration;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Illuminate\Contracts\Foundation\Application as ApplicationContract;

final class BaseLoadConfiguration extends LoadConfiguration
{
    /**
     * Get all of the configuration files for the application.
     *
     * @param  \Illuminate\Contracts\Foundation\Application $app
     *
     * @return array
     */
    protected function getConfigurationFiles(ApplicationContract $app): array
    {
        $files = [];

        $configPath = $app->configPath();

        $configFiles = Finder::create()
            ->files()
            ->name('*.php')
            ->in($configPath);

        foreach ($configFiles as $file) {
            $directory = $this->getNestedDirectory($file, $configPath);
            $files[$directory.basename($file->getPathname(), '.php')] = $file->getPathname();
        }

        ksort($files, SORT_NATURAL);

        return $files;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/**
6		* This file is part of Laravel Zero.
7		*
8		* (c) Nuno Maduro <[email protected]>
9		*
10		* For the full copyright and license information, please view the LICENSE
11		* file that was distributed with this source code.
12		*/
13
14		namespace LaravelZero\Framework\Bootstrap;
15
16		use function ksort;
17		use function basename;
18		use Symfony\Component\Finder\Finder;
19		use Illuminate\Foundation\Bootstrap\LoadConfiguration;
		0 ignored issues – show Bug introduced 2018-06-24 21:48 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `LaravelZero\Framework\Bootstrap\LoadConfiguration`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
20		use Illuminate\Contracts\Foundation\Application as ApplicationContract;
21
22		final class BaseLoadConfiguration extends LoadConfiguration
23		{
24		/**
25		* Get all of the configuration files for the application.
26		*
27		* @param \Illuminate\Contracts\Foundation\Application $app
28		*
29		* @return array
30		*/
31	29	protected function getConfigurationFiles(ApplicationContract $app): array
32		{
33	29	$files = [];
34
35	29	$configPath = $app->configPath();
36
37	29	$configFiles = Finder::create()
38	29	->files()
39	29	->name('*.php')
40	29	->in($configPath);
41
42	29	foreach ($configFiles as $file) {
43	29	$directory = $this->getNestedDirectory($file, $configPath);
44	29	$files[$directory.basename($file->getPathname(), '.php')] = $file->getPathname();
45		}
46
47	29	ksort($files, SORT_NATURAL);
48
49	29	return $files;
50		}
51		}
52

laravel-zero / framework

Branch — develop (b36b95)

BaseLoadConfiguration::getConfigurationFiles() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like