HelpersTest::config_path_helper() - Code Metrics - Inspection of "Apply fixes from StyleCI" - laravel-zero/framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — stable (#145)

by Nuno

created 2018-01-05 22:42 UTC

HelpersTest::config_path_helper() A

↳ Parent: HelpersTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	8
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	12
rs	9.4285

<?php

namespace Tests;

use LaravelZero\Framework\Container;

class HelpersTest extends TestCase
{
    /** @test */
    public function abort_helper(): void
    {
        $containerMock = $this->createMock(Container::class);

        $containerMock->expects($this->once())->method('abort')->with(404, 'Foo');

        Container::setInstance($containerMock);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        abort(404, 'Foo');
    }

    /** @test */
    public function abort_if_helper(): void

    {
        abort_if(false, 123, 'Foo');

        $this->assertTrue(true);

        $containerMock = $this->createMock(Container::class);

        $containerMock->expects($this->once())->method('abort')->with(456, 'Bar');

        Container::setInstance($containerMock);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        abort_if(true, 456, 'Bar');
    }

    /** @test */
    public function abort_unless_helper(): void

    {
        abort_unless(true, 123, 'Foo');

        $this->assertTrue(true);

        $containerMock = $this->createMock(Container::class);

        $containerMock->expects($this->once())->method('abort')->with(456, 'Bar');

        Container::setInstance($containerMock);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        abort_unless(false, 456, 'Bar');
    }

    /** @test */
    public function app_helper(): void
    {
        $this->assertSame(app(), Container::getInstance());

        Container::getInstance()->bind('foo', function () {
            return 'bar';
        });

        $this->assertEquals(app('foo'), 'bar');
    }

    /** @test */
    public function app_path_helper(): void
    {
        $this->assertSame(app_path(), app('path'));

        $this->assertEquals(app_path('foo'), app('path').DIRECTORY_SEPARATOR.'foo');
    }

    /** @test */
    public function config_helper(): void
    {
        $this->assertSame(config(), app('config'));

        config(['foo' => 'bar']);

        $this->assertEquals(app('config')->get('foo'), 'bar');

        $this->assertEquals(app('config')->get('foo2', 2), 2);
    }

    /** @test */
    public function event_helper(): void
    {
        // @todo ...
        $this->assertTrue(true);
    }

    /** @test */
    public function base_path_helper(): void
    {
        $this->assertEquals(BASE_PATH, base_path());
        $this->assertEquals(
            BASE_PATH.DIRECTORY_SEPARATOR.'some'.DIRECTORY_SEPARATOR.'directory',
            base_path('some'.DIRECTORY_SEPARATOR.'directory')
        );
    }

    /** @test */
    public function config_path_helper(): void
    {
        $this->assertEquals(BASE_PATH.DIRECTORY_SEPARATOR.'config', config_path());
        $this->assertEquals(
            BASE_PATH.DIRECTORY_SEPARATOR.'config'.DIRECTORY_SEPARATOR.'vendor',
            config_path('vendor')
        );
        $this->assertEquals(
            BASE_PATH.DIRECTORY_SEPARATOR.'config'.DIRECTORY_SEPARATOR.'custom.php',
            config_path('custom.php')
        );
    }

    /** @test */
    public function database_path_helper(): void

    {
        $this->assertEquals(BASE_PATH.DIRECTORY_SEPARATOR.'database', database_path());
        $this->assertEquals(
            BASE_PATH.DIRECTORY_SEPARATOR.'database'.DIRECTORY_SEPARATOR.'seeds',
            database_path('seeds')
        );
        $this->assertEquals(
            BASE_PATH.DIRECTORY_SEPARATOR.'database'.DIRECTORY_SEPARATOR.'seeds'.DIRECTORY_SEPARATOR.'DatabaseSeeder.php',
            database_path('seeds'.DIRECTORY_SEPARATOR.'DatabaseSeeder.php')
        );
    }

    /** @test */
    public function resource_path_helper(): void
    {
        $this->assertEquals(BASE_PATH.DIRECTORY_SEPARATOR.'resources', resource_path());
        $this->assertEquals(
            BASE_PATH.DIRECTORY_SEPARATOR.'resources'.DIRECTORY_SEPARATOR.'assets'.DIRECTORY_SEPARATOR.'js',
            resource_path('assets'.DIRECTORY_SEPARATOR.'js')
        );
        $this->assertEquals(
            BASE_PATH.DIRECTORY_SEPARATOR.'resources'.DIRECTORY_SEPARATOR.'assets'.DIRECTORY_SEPARATOR.'js'.DIRECTORY_SEPARATOR.'app.php',
            resource_path('assets'.DIRECTORY_SEPARATOR.'js'.DIRECTORY_SEPARATOR.'app.php')
        );
    }

    /** @test */
    public function storage_path_helper(): void

    {
        $this->assertEquals(BASE_PATH.DIRECTORY_SEPARATOR.'storage', storage_path());
        $this->assertEquals(
            BASE_PATH.DIRECTORY_SEPARATOR.'storage'.DIRECTORY_SEPARATOR.'logs',
            storage_path('logs')
        );
        $this->assertEquals(
            BASE_PATH.DIRECTORY_SEPARATOR.'storage'.DIRECTORY_SEPARATOR.'logs'.DIRECTORY_SEPARATOR.'laravel.log',
            storage_path('logs'.DIRECTORY_SEPARATOR.'laravel.log')
        );
    }
}


1		<?php
2
3		namespace Tests;
4
5		use LaravelZero\Framework\Container;
6
7		class HelpersTest extends TestCase
8		{
9		/** @test */
10		public function abort_helper(): void
11		{
12		$containerMock = $this->createMock(Container::class);
13
14		$containerMock->expects($this->once())->method('abort')->with(404, 'Foo');
15
16		Container::setInstance($containerMock);
		0 ignored issues – show Documentation introduced 2018-01-05 22:44 UTC by Report Bug Copy Issue Report `$containerMock` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `null\|object<Illuminate\C...ts\Container\Container>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
17
18		abort(404, 'Foo');
19		}
20
21		/** @test */
22	View Code Duplication	public function abort_if_helper(): void
		0 ignored issues – show Duplication introduced 2018-01-05 22:44 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		{
24		abort_if(false, 123, 'Foo');
25
26		$this->assertTrue(true);
27
28		$containerMock = $this->createMock(Container::class);
29
30		$containerMock->expects($this->once())->method('abort')->with(456, 'Bar');
31
32		Container::setInstance($containerMock);
		0 ignored issues – show Documentation introduced 2018-01-05 22:44 UTC by Report Bug Copy Issue Report `$containerMock` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `null\|object<Illuminate\C...ts\Container\Container>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33
34		abort_if(true, 456, 'Bar');
35		}
36
37		/** @test */
38	View Code Duplication	public function abort_unless_helper(): void
		0 ignored issues – show Duplication introduced 2018-01-05 22:44 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
39		{
40		abort_unless(true, 123, 'Foo');
41
42		$this->assertTrue(true);
43
44		$containerMock = $this->createMock(Container::class);
45
46		$containerMock->expects($this->once())->method('abort')->with(456, 'Bar');
47
48		Container::setInstance($containerMock);
		0 ignored issues – show Documentation introduced 2018-01-05 22:44 UTC by Report Bug Copy Issue Report `$containerMock` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `null\|object<Illuminate\C...ts\Container\Container>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
49
50		abort_unless(false, 456, 'Bar');
51		}
52
53		/** @test */
54		public function app_helper(): void
55		{
56		$this->assertSame(app(), Container::getInstance());
57
58		Container::getInstance()->bind('foo', function () {
59		return 'bar';
60		});
61
62		$this->assertEquals(app('foo'), 'bar');
63		}
64
65		/** @test */
66		public function app_path_helper(): void
67		{
68		$this->assertSame(app_path(), app('path'));
69
70		$this->assertEquals(app_path('foo'), app('path').DIRECTORY_SEPARATOR.'foo');
71		}
72
73		/** @test */
74		public function config_helper(): void
75		{
76		$this->assertSame(config(), app('config'));
77
78		config(['foo' => 'bar']);
79
80		$this->assertEquals(app('config')->get('foo'), 'bar');
81
82		$this->assertEquals(app('config')->get('foo2', 2), 2);
83		}
84
85		/** @test */
86		public function event_helper(): void
87		{
88		// @todo ...
89		$this->assertTrue(true);
90		}
91
92		/** @test */
93		public function base_path_helper(): void
94		{
95		$this->assertEquals(BASE_PATH, base_path());
96		$this->assertEquals(
97		BASE_PATH.DIRECTORY_SEPARATOR.'some'.DIRECTORY_SEPARATOR.'directory',
98		base_path('some'.DIRECTORY_SEPARATOR.'directory')
99		);
100		}
101
102		/** @test */
103		public function config_path_helper(): void
104		{
105		$this->assertEquals(BASE_PATH.DIRECTORY_SEPARATOR.'config', config_path());
106		$this->assertEquals(
107		BASE_PATH.DIRECTORY_SEPARATOR.'config'.DIRECTORY_SEPARATOR.'vendor',
108		config_path('vendor')
109		);
110		$this->assertEquals(
111		BASE_PATH.DIRECTORY_SEPARATOR.'config'.DIRECTORY_SEPARATOR.'custom.php',
112		config_path('custom.php')
113		);
114		}
115
116		/** @test */
117	View Code Duplication	public function database_path_helper(): void
		0 ignored issues – show Duplication introduced 2017-11-27 21:59 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
118		{
119		$this->assertEquals(BASE_PATH.DIRECTORY_SEPARATOR.'database', database_path());
120		$this->assertEquals(
121		BASE_PATH.DIRECTORY_SEPARATOR.'database'.DIRECTORY_SEPARATOR.'seeds',
122		database_path('seeds')
123		);
124		$this->assertEquals(
125		BASE_PATH.DIRECTORY_SEPARATOR.'database'.DIRECTORY_SEPARATOR.'seeds'.DIRECTORY_SEPARATOR.'DatabaseSeeder.php',
126		database_path('seeds'.DIRECTORY_SEPARATOR.'DatabaseSeeder.php')
127		);
128		}
129
130		/** @test */
131		public function resource_path_helper(): void
132		{
133		$this->assertEquals(BASE_PATH.DIRECTORY_SEPARATOR.'resources', resource_path());
134		$this->assertEquals(
135		BASE_PATH.DIRECTORY_SEPARATOR.'resources'.DIRECTORY_SEPARATOR.'assets'.DIRECTORY_SEPARATOR.'js',
136		resource_path('assets'.DIRECTORY_SEPARATOR.'js')
137		);
138		$this->assertEquals(
139		BASE_PATH.DIRECTORY_SEPARATOR.'resources'.DIRECTORY_SEPARATOR.'assets'.DIRECTORY_SEPARATOR.'js'.DIRECTORY_SEPARATOR.'app.php',
140		resource_path('assets'.DIRECTORY_SEPARATOR.'js'.DIRECTORY_SEPARATOR.'app.php')
141		);
142		}
143
144		/** @test */
145	View Code Duplication	public function storage_path_helper(): void
		0 ignored issues – show Duplication introduced 2017-11-27 21:59 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
146		{
147		$this->assertEquals(BASE_PATH.DIRECTORY_SEPARATOR.'storage', storage_path());
148		$this->assertEquals(
149		BASE_PATH.DIRECTORY_SEPARATOR.'storage'.DIRECTORY_SEPARATOR.'logs',
150		storage_path('logs')
151		);
152		$this->assertEquals(
153		BASE_PATH.DIRECTORY_SEPARATOR.'storage'.DIRECTORY_SEPARATOR.'logs'.DIRECTORY_SEPARATOR.'laravel.log',
154		storage_path('logs'.DIRECTORY_SEPARATOR.'laravel.log')
155		);
156		}
157		}
158

laravel-zero / framework

Pull Request — stable (#145)

HelpersTest::config_path_helper() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like