ApplicationTest::it_can_abort() - Code Metrics - Inspection of "Merge branch 'release-5.6.0' into stable" - laravel-zero/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — stable ( 86ecc3...3a45ea )

by Nuno

created 2018-02-18 21:18 UTC

ApplicationTest::it_can_abort() A

↳ Parent: ApplicationTest

Complexity

Conditions	3
Paths	4

Size

Total Lines	20
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	20
rs	9.4285
cc	3
eloc	13
nc	4
nop	0

<?php

namespace Tests;

use LaravelZero\Framework\Contracts\Exceptions\ConsoleException;
use Symfony\Component\Console\Exception\CommandNotFoundException;

class ApplicationTest extends TestCase
{
    /** @test */
    public function it_has_environment_getter()
    {
        $this->assertSame('Test version', $this->app->version());
    }

    /** @test */
    public function it_confirms_the_running_in_console()
    {
        $this->assertTrue(
            $this->app->runningInConsole()
        );
    }

    /** @test */
    public function it_confirms_that_is_not_down_for_maintenance()
    {
        $this->assertFalse(
            $this->app->isDownForMaintenance()
        );
    }

    /** @test */
    public function it_can_abort(): void
    {
        try {
            $this->app->abort(404, 'Foo');
        } catch (CommandNotFoundException $notFoundException) {

        }

        $this->assertInstanceOf(CommandNotFoundException::class, $notFoundException);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        $this->assertEquals($notFoundException->getMessage(), 'Foo');

        try {
            abort(200, 'Bar', ['Foo' => 'Bar']);
        } catch (ConsoleException $consoleException) {

        }

        $this->assertInstanceOf(ConsoleException::class, $consoleException);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        $this->assertEquals($consoleException->getExitCode(), 200);
        $this->assertEquals($consoleException->getMessage(), 'Bar');
        $this->assertEquals($consoleException->getHeaders(), ['Foo' => 'Bar']);
    }
}


1			<?php
2
3			namespace Tests;
4
5			use LaravelZero\Framework\Contracts\Exceptions\ConsoleException;
6			use Symfony\Component\Console\Exception\CommandNotFoundException;
7
8			class ApplicationTest extends TestCase
9			{
10			/** @test */
11			public function it_has_environment_getter()
12			{
13			$this->assertSame('Test version', $this->app->version());
14			}
15
16			/** @test */
17			public function it_confirms_the_running_in_console()
18			{
19			$this->assertTrue(
20			$this->app->runningInConsole()
21			);
22			}
23
24			/** @test */
25			public function it_confirms_that_is_not_down_for_maintenance()
26			{
27			$this->assertFalse(
28			$this->app->isDownForMaintenance()
29			);
30			}
31
32			/** @test */
33			public function it_can_abort(): void
34			{
35			try {
36			$this->app->abort(404, 'Foo');
37			} catch (CommandNotFoundException $notFoundException) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-01-05 22:44 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
38			}
39
40			$this->assertInstanceOf(CommandNotFoundException::class, $notFoundException);
			0 ignored issues – show Bug introduced 2018-01-05 22:44 UTC by Report Bug Copy Issue Report The variable `$notFoundException` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
41			$this->assertEquals($notFoundException->getMessage(), 'Foo');
42
43			try {
44			abort(200, 'Bar', ['Foo' => 'Bar']);
45			} catch (ConsoleException $consoleException) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-01-05 22:44 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
46			}
47
48			$this->assertInstanceOf(ConsoleException::class, $consoleException);
			0 ignored issues – show Bug introduced 2018-01-05 22:44 UTC by Report Bug Copy Issue Report The variable `$consoleException` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
49			$this->assertEquals($consoleException->getExitCode(), 200);
50			$this->assertEquals($consoleException->getMessage(), 'Bar');
51			$this->assertEquals($consoleException->getHeaders(), ['Foo' => 'Bar']);
52			}
53			}
54

laravel-zero / framework

Push — stable ( 86ecc3...3a45ea )

ApplicationTest::it_can_abort() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like