CardExpirationDate::passes() - Code Metrics - Inspection of "[WIP] beta" - laravel-validation-rules/credit-card - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 02b308...987bda )

by Darius

created 2017-09-21 11:40 UTC

CardExpirationDate::passes() A

↳ Parent: CardExpirationDate

Complexity

Conditions	2
Paths	3

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	14
ccs	6
cts	6
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	8
nc	3
nop	2
crap	2

<?php

namespace LVR\CreditCard;

use Illuminate\Support\Carbon;
use LVR\CreditCard\Cards\Card;
use Illuminate\Contracts\Validation\Rule;

class CardExpirationDate implements Rule
{
    const MSG_CARD_EXPIRATION_DATE_INVALID = 'validation.credit_card.card_expiation_date_invalid';
    const MSG_CARD_EXPIRATION_DATE_FORMAT_INVALID = 'validation.credit_card.card_expiation_date_format_invalid';

    protected $message;

    /**
     * Date field format.
     *
     * @var string
     */
    protected $format;

    /**
     * CardExpirationDate constructor.
     *
     * @param string $format Date format
     */
    public function __construct(string $format)
    {
        $this->message = static::MSG_CARD_EXPIRATION_DATE_INVALID;
        $this->format = $format;
    }

    /**
     * Determine if the validation rule passes.
     *
     * @param  string $attribute
     * @param  mixed $value
     *
     * @return bool
     */
    public function passes($attribute, $value)
    {
        try {
            $date = Carbon::createFromFormat($this->format, $value);

            return Card::isValidExpirationDate($date->year, $date->month);
        } catch (\InvalidArgumentException $ex) {
            $this->message = static::MSG_CARD_EXPIRATION_DATE_FORMAT_INVALID;

            return false;
        }

        return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    /**
     * Get the validation error message.
     *
     * @return string
     */
    public function message()
    {
        return $this->message;
    }
}


1		<?php
2
3		namespace LVR\CreditCard;
4
5		use Illuminate\Support\Carbon;
6		use LVR\CreditCard\Cards\Card;
7		use Illuminate\Contracts\Validation\Rule;
8
9		class CardExpirationDate implements Rule
10		{
11		const MSG_CARD_EXPIRATION_DATE_INVALID = 'validation.credit_card.card_expiation_date_invalid';
12		const MSG_CARD_EXPIRATION_DATE_FORMAT_INVALID = 'validation.credit_card.card_expiation_date_format_invalid';
13
14		protected $message;
15
16		/**
17		* Date field format.
18		*
19		* @var string
20		*/
21		protected $format;
22
23		/**
24		* CardExpirationDate constructor.
25		*
26		* @param string $format Date format
27		*/
28	1	public function __construct(string $format)
29		{
30	1	$this->message = static::MSG_CARD_EXPIRATION_DATE_INVALID;
31	1	$this->format = $format;
32	1	}
33
34		/**
35		* Determine if the validation rule passes.
36		*
37		* @param string $attribute
38		* @param mixed $value
39		*
40		* @return bool
41		*/
42	1	public function passes($attribute, $value)
43		{
44		try {
45	1	$date = Carbon::createFromFormat($this->format, $value);
46
47	1	return Card::isValidExpirationDate($date->year, $date->month);
48	1	} catch (\InvalidArgumentException $ex) {
49	1	$this->message = static::MSG_CARD_EXPIRATION_DATE_FORMAT_INVALID;
50
51	1	return false;
52		}
53
54		return false;
		0 ignored issues – show Unused Code introduced 2017-09-21 11:41 UTC by Report Bug Copy Issue Report `return false;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
55		}
56
57		/**
58		* Get the validation error message.
59		*
60		* @return string
61		*/
62	1	public function message()
63		{
64	1	return $this->message;
65		}
66		}
67

laravel-validation-rules / credit-card

Push — master ( 02b308...987bda )

CardExpirationDate::passes() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like